From: Chuck Lever III <chuck.lever@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Files in include/trace/events
Date: Sat, 12 Nov 2022 15:57:57 +0000 [thread overview]
Message-ID: <23D84506-BC58-4269-BD71-A88DDBCC92BA@oracle.com> (raw)
In-Reply-To: <20221112072742.065df70a@rorschach.local.home>
> On Nov 12, 2022, at 7:27 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Hi Chuck,
>
> I was just looking over some files in include/trace/events/ and noticed
> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
>
> The include/trace/events/ directory should only hold files that are to
> create events, not headers that hold helper functions.
>
> Can you please move them out of include/trace/events/ as that directory
> is "special" in the creation of events.
>
> Perhaps we could create a new directory include/linux/trace/ or
> include/trace/linux/ specific for these types of files?
I can take responsibility for moving the helper files I created.
IIRC there are a few from the RDMA core subsystem as well.
But let's first decide on a proper destination for such files.
A sister directory to include/trace/events, like
include/trace/ < something >
makes sense to me.
--
Chuck Lever
prev parent reply other threads:[~2022-11-12 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 12:27 Files in include/trace/events Steven Rostedt
2022-11-12 12:33 ` Steven Rostedt
2022-11-22 10:23 ` Vlastimil Babka
2022-11-12 15:57 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23D84506-BC58-4269-BD71-A88DDBCC92BA@oracle.com \
--to=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.