All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	tglx@linutronix.de, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] rtc: mc146818-lib: fix RTC presence check" failed to apply to 5.16-stable tree
Date: Mon, 24 Jan 2022 17:27:16 +0100	[thread overview]
Message-ID: <23a5748e-55ca-69af-c9ff-d68a413a331d@o2.pl> (raw)
In-Reply-To: <Ye69PKB2V/R/NxN8@kroah.com>

W dniu 24.01.2022 o 15:52, Greg KH pisze:
> On Mon, Jan 24, 2022 at 03:45:30PM +0100, Mateusz Jończyk wrote:
>> W dniu 24.01.2022 o 14:08, gregkh@linuxfoundation.org pisze:
>>> The patch below does not apply to the 5.16-stable tree.
>>> If someone wants it applied there, or to any other stable or longterm
>>> tree, then please email the backport, including the original git commit
>>> id to <stable@vger.kernel.org>.
>>>
>>> thanks,
>>>
>>> greg k-h
>> Wait, this patch was not intended for submission into stable yet, at least not in this form.
>> Why did it end up in the stable queue?
> Because it was marked with a "Fixes:" tag and I reviewed it and it
> looked like it actually fixed an issue.
>
> Is this not the case?

Yes, that's correct. But I'm afraid that this patch will cause regressions on some systems.
(Mr Alexandre Belloni said something similar of my series). So I'd like to wait till at least Linux 5.17 (final) is
released to see if it causes any trouble.

>> The return values from mc146818_get_time() changed in between,
>> so it is natural that it does not apply.
>>
>> See
>> commit d35786b3a28dee20 ("rtc: mc146818-lib: change return values of mc146818_get_time()")
> Ok, so will a working backport be sent sometime in the future?
> thanks,
>
> greg k-h

Greetings,

Mateusz


  reply	other threads:[~2022-01-24 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 13:08 FAILED: patch "[PATCH] rtc: mc146818-lib: fix RTC presence check" failed to apply to 5.16-stable tree gregkh
2022-01-24 14:45 ` Mateusz Jończyk
2022-01-24 14:52   ` Greg KH
2022-01-24 16:27     ` Mateusz Jończyk [this message]
2022-01-26 13:56       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23a5748e-55ca-69af-c9ff-d68a413a331d@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.