From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D6F7C433FE for ; Wed, 2 Nov 2022 09:39:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7095A10E466; Wed, 2 Nov 2022 09:39:35 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id B57BE10E44F for ; Wed, 2 Nov 2022 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=ayLxoterv5qOKZ9jzr8BpY6aHyfH2K5eT7UdvAsZ3harUSJrhKy5fYl0mEL11bhC0z2Kfd W9TDzjae0Y8V5xOQGYRAtyrcM6GiGQf6tkWIkc8nSnwGI4e18IGVU5BznlwXt0GIad7pIR 8g2Xz8rUrq2+o0xlPrHIbQzqlWaCs7U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-315-vB2YSYD4ME-4xuBp6hr_pw-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: vB2YSYD4ME-4xuBp6hr_pw-1 Received: by mail-wm1-f71.google.com with SMTP id c5-20020a1c3505000000b003c56da8e894so862057wma.0 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=nYe1Y1aU2BjmQ6S4SiVU78Vjmpl8nhFQCJaKT2RB0LNZV61rUxH7OVqY8yZVWkCB78 gyWjgwbvtRWMY0NLWClzqFUZMsE/usmFzuMsvOx8+2ok2zjCGR6vPOi7NpZxLZeZ7rUv 0X4+iuLM24LK2XSkHy1MGE80JLJXeza/jebGx0UvpI7GD31o06cn78GyX2ms5B7NRSJb Nls2gUn49O7FBuUn7qLUXGo9kLj7Z+AjthfkNtSvJ/RzLmO/D9Ta2RhxXs2EBHuTBMIf Q07oiNN005mFRFes+y5SmSv9RI0BRVkkOT95Yz5tgJjATt/qplWuIxW0UUvLMpsm4Xyv vQPA== X-Gm-Message-State: ACrzQf3j0P4xgZHyoQkWfXcTnfBhnkZ3X+rrzOsIRb5icmulpKhTC3rB 4pvoHCAmbwe/qO6xgdyvTe+nK7PWgvZyKh2RI4Nm0EjLDhv9QQm4seCM4J91c+rIQINdMJAjhr8 a8+44NZhkzZ8OT290zHo+FrmX/g== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871549wrq.355.1667381964722; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 913A5C4332F for ; Wed, 2 Nov 2022 09:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=USGLM1NSTLpTkbfu0FAST/NARUcxDcqnOzMgikEZogs=; b=uE7bUDI+Hc37Qd gQwLmr8NvQILw/ak/aXwe5WtFMWT0MdDmfKFxI43jKJB19cAZhTlDYDiKNlmQpEJBqqq028TjU8Eu ifYAqtzHZeMuyh1eUIeQ0tfSn0n5ksegrGxXlzgPaaF5T4rJAUNR53PNIQ/OC5uDOyZHHVQkI8wdK tHtz4WJ/LLynTWHNEr65XvPNXlMU/bMUcWcP0x8c8qlPAIxabRaxiyTocKLLzSySx4WBBR4MbRyco 2uAcJradC8LD7CW1J+vt6+yRdm6hkXlyUNVE4DXv+IRS/GHs8FaSzr/n/Riizs8mpN8PkAOm6aTTH 1F3LKgfArnDANcMVtJlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADs-00AJo1-5i; Wed, 02 Nov 2022 09:39:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADZ-00AJeY-Oy for linux-rockchip@lists.infradead.org; Wed, 02 Nov 2022 09:39:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=GMyX23M7aSNGVk82b+SS7It6CTJk/lQ9QoLZb9G3GYWekXX3VxOsAJVSu7ooUEr4DTltcb QBjTHqWzOXxUVb6VYtMzNUbr20bi2FhXiLrJSfo076/gQdN8zQvLvWce+OT0c/d0DcdHaG gdlrxhAn/5YwbQH37x36RDrY0Izpm+4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-532-YAxtlPr5MFySe0c4HTVgTA-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: YAxtlPr5MFySe0c4HTVgTA-1 Received: by mail-wm1-f69.google.com with SMTP id 1-20020a05600c028100b003cf7833293cso845590wmk.3 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=qFCfjKAjnxG//MJQQaH1xrAVWZxCT9Y7Nzi5/1xc47cAUbFPjfXnbqGQ8fslPrZWot 4/Ir2+XW9ShxKT0u2PNkQEHVtIx9qMLo6DfPqI2kWSuuj5cXE5jc/MfNuHJLbptPdU9D TRDmzRb7E7HnkZ/QT+fcg0swt0KzcbTlDNrOVu3lT5tL0QsbMt12VqQloQ+LkGy47swf dnR9eRO7kKk3lZD2SYFBSzi66z1e5YmMOy189aCPuXFHKzO62RKW8Em2RGINkW0yUgQr HKUbgR2gN8yp39/3kvJ5AlgAdRihDXkUwvzZ0Q3O0fsLLUCGFS9lNblPxT7uv7dbeFIz 1OFQ== X-Gm-Message-State: ACrzQf1f4YOLqQXdq4YtHLS/9dsG1c93npU4NPlm0rymvR1cShKPW7Ot tvCb3FHthTlJmPjzEWC63oXVa1yPFUDB7rvBb1FlTSoidCaNn/uDsXpI8b75siSSUHkg0aeuEdj NJ4hCdeBB1L47r6N3eIJKCLTGeEScHcfT X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871545wrq.355.1667381964721; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_023929_926724_5F4A0F10 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F7007ED for ; Wed, 2 Nov 2022 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=GMyX23M7aSNGVk82b+SS7It6CTJk/lQ9QoLZb9G3GYWekXX3VxOsAJVSu7ooUEr4DTltcb QBjTHqWzOXxUVb6VYtMzNUbr20bi2FhXiLrJSfo076/gQdN8zQvLvWce+OT0c/d0DcdHaG gdlrxhAn/5YwbQH37x36RDrY0Izpm+4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-90-GfrjWkAtPTiDaD7V4r-MEg-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: GfrjWkAtPTiDaD7V4r-MEg-1 Received: by mail-wm1-f71.google.com with SMTP id r187-20020a1c44c4000000b003c41e9ae97dso834504wma.6 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=fLYf8ToI1FNuHuGXqRW2g2O5+58gVRB2o7bsM3sP4r3XHbWl4JCXWrr//EP1d9hS9B ShWGYpBQXdsfua1t+ETD4zGhlVaooX782DQxZM6bIPDAhh1466mWksqFaPqO3tJIujtQ kdSfTFCwAT4bXjQfeMWKu1GKErymU1CdsoInsIhhQ8pqITujKJxkjZ075Lx3xlIpVVib sTbI5WuItBC9/TDodHweftKtfWvxHCh9o9MUKmPBCgQQ4WrJ+Dn21itDJ91Sgx6rnqJY P16+ONeo/gv5xOUAJC8h3TYqj8GTSRf0PnUTUwzTogwEsC+f9iIruVEWygZmxtFoXi9q 4rwQ== X-Gm-Message-State: ACrzQf2U3sPXDdOmXZaMrbzrsvaBPLnjeJt2j+PQFGZZCmPE5LZHxThh 9p7FkIu9CUTPxnVLUGJBP+QqaBxVpy5n5JazwY5gbuFE9HlN47h1LXyYqJbVmuMfSzZYPReC/hh zQFi40FkKnA+tD727YdUiwW0= X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871564wrq.355.1667381964727; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A36A2C4332F for ; Wed, 2 Nov 2022 09:39:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6068110E463; Wed, 2 Nov 2022 09:39:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E440210E44F for ; Wed, 2 Nov 2022 09:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=Jio9JFQacF7FMi0mPUb743H5F84vjCUoxUEdOs4aCfEtqSNexXzNQhBZqnP+aEdEkKHJXh URmHGjTMdLlBZMQtpImG0Y4/SH1ck9czoq54M3olm1njxLJsVz+LHQL3sTJgt66SNaM5Ds +mvqMM0BCfe4PNY5ygcY3NKi7w2CfF8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-627-Agq9t36BOAihiZCb-aJWsw-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: Agq9t36BOAihiZCb-aJWsw-1 Received: by mail-wm1-f70.google.com with SMTP id 9-20020a1c0209000000b003cf6fce8005so151518wmc.9 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=ktlk70dXjSD7ZIXZbHkBOHM0Y5/84L5nif2D7tynHdOIUZfnsb3JciVEK8l/ax+uGf 76QMZti47hjlbb0HdVB0QjqL17+JHPzHGQaZcpgbih11pqgSepUiOxhuEGL3mjxVeN3x Z3dX3JJT2Twf6+HTNs6rJLTdQuAj2glC6xKFBnsJxNe+EvKprsghAnax0TsXQ0IfN0MI phi8AFIb2HHC7UbsUYnF5q3u9p4qmckcMkUyve6btz3TqoKycn5qlweZEEbJA8uxXFJ/ TaOZd0dvZKdhYz+RePY3IBDugMS7TWryfNlUhFBAKillSOzE8XaftdBhLY8Vbeh9ZmS3 DL2g== X-Gm-Message-State: ACrzQf2AGfD59wudzaurkf9q468DiRTSPTLZl0eFN/LJbOYtu48qGQa6 zsPMYh0D97HNJYrnkOaUy6RhuAwzVs/zjyi8HFjf68hnMvWSBnr1moWUhVMkGpFqX4wsDAA/wx1 r+9iXYN0CdAUDQMCI1c2J0DE3bXb8 X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871542wrq.355.1667381964721; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50235C4332F for ; Wed, 2 Nov 2022 09:39:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE3EF10E461; Wed, 2 Nov 2022 09:39:35 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BB9C10E461 for ; Wed, 2 Nov 2022 09:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=Jio9JFQacF7FMi0mPUb743H5F84vjCUoxUEdOs4aCfEtqSNexXzNQhBZqnP+aEdEkKHJXh URmHGjTMdLlBZMQtpImG0Y4/SH1ck9czoq54M3olm1njxLJsVz+LHQL3sTJgt66SNaM5Ds +mvqMM0BCfe4PNY5ygcY3NKi7w2CfF8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-627-lX0CkCslPLWSK3NNMoeldQ-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: lX0CkCslPLWSK3NNMoeldQ-1 Received: by mail-wr1-f70.google.com with SMTP id w23-20020adf8bd7000000b002358f733307so4634400wra.17 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=Y+f2WmD25YyOyEGB1DUAtXIcq5FLz6OetobjU9wLPST7IpRFbrh0axrdbyytrRpuIi s9NCUo6Ph8cklipkiqXcZiMDa8jrdI+Pn25Txq1SsX56H8peijWknRUXWeA4HxXTCBLB ADU1Nt0QkCPC+lExtG/6td5HV6XKfu76hGnUMi7hHDZ1az8/+iBeQZvrx5mc1MmBdC5L GVd+fmvhH9kr23rTwW3TXI5xCY99PkSq2dK6y6rg6UZX+8Pt0UKNrOKos2CLGl0RiomC cN//vWiKtJwt/itBsO2L8JV/EtnQ895H5ghVeDxPYuoihuH37AfgeQARNLah6BIuOG/R 1zZA== X-Gm-Message-State: ACrzQf3aynMSFLOoCA+Vg1lFIpiYbTWfmRE1LrBsQmR4MHj9NYy5Sedn 4CrihWFLplR88ir+XWc7h6uKSoXzNUp1BSZ02I8TrmLkZd6jHFf7tFwiSUp2OeeLcc6ovYilTXp VzXideQmJmjyiib8w7/E4u1BhONnY X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871559wrq.355.1667381964727; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F865C4332F for ; Wed, 2 Nov 2022 09:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dmg3AN1l14nun9DV8T8vClnxhyvyKzIePOVL8DoBgEc=; b=KPUVEVW1uDkGZ6 sltKqRphOSI5ka4c1BzNB2+J+xwkTEPVUzG06asBm67np6CIHgxMmWpgNAYobnQuLwZU3lV1F/Jvg 0QLrN9GCTKsxBwtOhC4hZaDMVG/H6cyrd/EvHexQpWhnhzYKYtoYk1QWN6VVpEXkgw0enJ0kGv7Q2 4M76LfloRPSRZshzd3R3k4uG9362IjjBHlvu46gyph0wpBSBMsMuoW0rnFdq+Yd1KdxBbDJ8guqJw kh2AVCsHtiOxkF2R+0HVG6ZYWGp+SZ8ivyknkydhAVOyLZ4rDL0CbUxvO6uGTdOfyQWhD1a9cSV+y WBOzdJu9G9N9iK5y6w7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADb-00AJfr-Nx; Wed, 02 Nov 2022 09:39:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADY-00AJcx-3a for linux-amlogic@lists.infradead.org; Wed, 02 Nov 2022 09:39:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=NUjdYV3rW79cPv/AK0PWPgFBCxIqQyzjJC7+TBixeJ+GrpLhAetFvre/jNHsDh3WHN9fkN qIhEY98vXVKVZTpwUluv7G52Vnd8YgeNxFTFPzB3yb/3+/YOCi5unhZSaBadHvPIVkGGCS Fqf/xQJxT9DKpbUnMs09sSYNx4qfjBQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-656-kNt-ZJVrOEiJVCqTyJflew-1; Wed, 02 Nov 2022 05:39:25 -0400 X-MC-Unique: kNt-ZJVrOEiJVCqTyJflew-1 Received: by mail-wm1-f70.google.com with SMTP id m34-20020a05600c3b2200b003cf549cb32bso849155wms.1 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=ZGDo19RRvBdWGk7DCHZDwdH4w4VcQT2p4nL5hEcgC1pLvaRj2Dvif3YuN+lb2ZYXOv +hqD9lI6sO5v35GvtO9VkIaauGpXIIBapEaErWstimZGLsnznBOwbaKMixbF0ktpIhlZ PBQZnYIL1ZQV3Dlm5K692FDM6tVTLpJ+PgUh7IxtGf7rPfO1MSkCe4ATW/APk1U/QBqy UwV2nquuz8N1BP3QpdORg9dEJW+2TGDnRVChJMXCpvowIgmintUmbqF7zwmUTPEfylR4 gzdpKayxZxeUPxllEVekzfliN2+7FqoNAkicmf7v3jVEmWsPMZmskna7vPF/PkcyiW8E nbkA== X-Gm-Message-State: ACrzQf2m21VYDcW16i0N1Dr4n1yVzLhASH1fKcO77bBHmCo3HieTquMo uyNEwyTEcRYMgGxPNF04nCa0hu4U84Q178Hp7kVWLxLQ4QEmejcbyjyMBmg1SnX93CK6bNlnpFU LpVY8LxBTCrmNtEahghgplC5PijQlsww= X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871552wrq.355.1667381964723; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_023928_302811_02E1D332 X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAB9CC433FE for ; Wed, 2 Nov 2022 09:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAa+r/tZ+0y0TMlGBQ+pSTOGdbM/O+w3kVxPcy3h6pI=; b=1uIMNpg9jKdDiG 8uFt0U5rdtAysE4mUzSZwhoXDgJ/A1cv5HnhVNBUATWxy0xLTjCyZIZAWru7TjSKsvD1QKxwbDiP5 +cdJha//Rp7eXQRX2eW/2SuXbaHuU5ZwnkIVdr8vTxH34p9M+y/pFiNXdFD/bmx1WHwm58RoL52Zc 9JAZNb7X/R9XbNgVi4pha0k8JiYZwzbkY60COZzUbGjQHkqvcTgA281dHSDnHPI4io+E6vlBXsOfq bNE+cUz5puASyQJKaeE8MNWSYj3Rbpie5SpXlQ1B9u2v/E18XyHg20/ed4nSTmLpEBymo73ZySu4Z B8xUebHnPtXHj77BpwYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADg-00AJha-NA; Wed, 02 Nov 2022 09:39:37 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqADY-00AJcz-3N for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 09:39:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667381967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=NUjdYV3rW79cPv/AK0PWPgFBCxIqQyzjJC7+TBixeJ+GrpLhAetFvre/jNHsDh3WHN9fkN qIhEY98vXVKVZTpwUluv7G52Vnd8YgeNxFTFPzB3yb/3+/YOCi5unhZSaBadHvPIVkGGCS Fqf/xQJxT9DKpbUnMs09sSYNx4qfjBQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-313-VbUnZ5dnNWWfmfolej91zA-1; Wed, 02 Nov 2022 05:39:26 -0400 X-MC-Unique: VbUnZ5dnNWWfmfolej91zA-1 Received: by mail-wm1-f70.google.com with SMTP id j2-20020a05600c1c0200b003cf7397fc9bso3118965wms.5 for ; Wed, 02 Nov 2022 02:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RgeOXsRJ+XKaYoOYvxoyhBylXQrWD/HUrGfmQUHOZZs=; b=RvJm9PGU3IZ7+GtwG8Pnh8ng8k9SdjB5foFBmKUz7yDy1vtS+D+bO7pKseUuytimyk R6b029WjT10jHIASCx6wZLnFK/yfQO3ipejZBRF54VQEVig0sQkrRX9vOX6B1q56qW7J UQ5KBvk/7CQTVmYL3Z6JNsfAVvaW9r7ltNM9Tqp3AVQuvQZpEi21G/ZqXWwID6rEv28a LZrKuLhOUsxAic0ejE56WrzOEc0ptDEmII+XSw15olzL93VO4n19IAhG9z9qgyQojVVt 0G9mBoBhsZcT/QBqyUfqtwcw+qA6qNgKEGm+QUHXxw9zyRZ9GvmCSLEpnssIhLi9KsRk wvwg== X-Gm-Message-State: ACrzQf0sQ5d3Jp6SiF/PbjDrfNv/G0DIE3bs5AHvSZKczlPcGuJ5uSa0 J5DptKSrerROKl+DvCYiZjJ0tV3DO7Be1Fo/hS4kALWZbpp6q98k1pn+6LrUAnbfkB32g/PLyJx OQoGzDgbPzRtgerzSerAnuqv6nVj9P0PrtVo= X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871547wrq.355.1667381964722; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/k2KHrjikPXyIbTE3cWGjPi0EsRobUeOg55XAJjnO250x+w4Sp4JFFeS1nRK3GUJGY3QPnQ== X-Received: by 2002:a5d:40d1:0:b0:236:786d:611e with SMTP id b17-20020a5d40d1000000b00236786d611emr14871522wrq.355.1667381964509; Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id dn12-20020a05600c654c00b003cf537ec2efsm1653185wmb.36.2022.11.02.02.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:39:24 -0700 (PDT) Message-ID: <23b6c3ca-828a-5376-ae80-0b04202e190b@redhat.com> Date: Wed, 2 Nov 2022 10:39:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-19-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-19-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_023928_319521_52A48401 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/24/22 13:19, Thomas Zimmermann wrote: > Pull the test for fb_dirty into the caller to avoid extra work > if no callback has been set. In this case no damage handling is > required and no damage area needs to be computed. Print a warning > if the damage worker runs without getting an fb_dirty callback. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas But I've a trivial comment below: > drivers/gpu/drm/drm_fb_helper.c | 90 ++++++++++++++++++++++----------- > 1 file changed, 60 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 836523aef6a27..fbc5c5445fdb0 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -449,12 +449,13 @@ static int drm_fb_helper_damage_blit(struct drm_fb_helper *fb_helper, > static void drm_fb_helper_damage_work(struct work_struct *work) > { > struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); > + struct drm_device *dev = helper->dev; You removed this in patch #15, maybe just leaving it in that patch if you plan to use it again here? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel