From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E791C07E9B for ; Wed, 21 Jul 2021 11:08:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EA2860720 for ; Wed, 21 Jul 2021 11:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238789AbhGUK1w (ORCPT ); Wed, 21 Jul 2021 06:27:52 -0400 Received: from foss.arm.com ([217.140.110.172]:51724 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238935AbhGUKSs (ORCPT ); Wed, 21 Jul 2021 06:18:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAA7631B; Wed, 21 Jul 2021 03:58:46 -0700 (PDT) Received: from [10.163.64.235] (unknown [10.163.64.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3935E3F99C; Wed, 21 Jul 2021 03:58:42 -0700 (PDT) Subject: Re: [PATCH v3 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args From: Anshuman Khandual To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com, Christophe Leroy , Gerald Schaefer , Qian Cai , "Aneesh Kumar K.V" References: <20210719130613.334901-1-gshan@redhat.com> <20210719130613.334901-2-gshan@redhat.com> <280a5740-b5dc-4b78-3a38-67e5adbb0afd@redhat.com> Message-ID: <23bb5363-fd36-5161-0ba2-da1efc3e3018@arm.com> Date: Wed, 21 Jul 2021 16:29:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/21 4:09 PM, Anshuman Khandual wrote: > > On 7/21/21 3:50 PM, Gavin Shan wrote: >> Hi Anshuman, >> >> On 7/21/21 3:44 PM, Anshuman Khandual wrote: >>> On 7/19/21 6:36 PM, Gavin Shan wrote: >>>> In debug_vm_pgtable(), there are many local variables introduced to >>>> track the needed information and they are passed to the functions for >>>> various test cases. It'd better to introduce a struct as place holder >>>> for these information. With it, what the functions for various test >>>> cases need is the struct, to simplify the code. It also makes code >>>> easier to be maintained. >>>> >>>> Besides, set_xxx_at() could access the data on the corresponding pages >>>> in the page table modifying tests. So the accessed pages in the tests >>>> should have been allocated from buddy. Otherwise, we're accessing pages >>>> that aren't owned by us. This causes issues like page flag corruption. >>>> >>>> This introduces "struct pgtable_debug_args". The struct is initialized >>>> and destroyed, but the information in the struct isn't used yet. They >>>> will be used in subsequent patches. >>>> >>>> Signed-off-by: Gavin Shan >>>> --- >>>>   mm/debug_vm_pgtable.c | 197 +++++++++++++++++++++++++++++++++++++++++- >>>>   1 file changed, 196 insertions(+), 1 deletion(-) >>>> >> I saw you've finished the review on PATCH[v3 01/12] and PATCH[v3 02/12]. >> I will wait to integrate your comments to v4 until you finish the review >> on all patches in v3 series > Yes, please do wait for the complete review and test before going for V4. > Also please add the following emails on copy next time, so that we might > have some more reviews here. Thank you. > > + Christophe Leroy > + Gerald Schaefer This one instead. Gerald Schaefer