From: Steven Price <steven.price@arm.com>
To: 20191213123942.22891-1-ezequiel@collabora.com,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel@lists.freedesktop.org
Cc: kernel@collabora.com, Ezequiel Garcia <ezequiel@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH v2] drm/panfrost: Prefix interrupt handlers' names
Date: Mon, 16 Dec 2019 09:52:21 +0000 [thread overview]
Message-ID: <23c51097-298c-f620-3457-7f5158b3a267@arm.com> (raw)
In-Reply-To: <20191214045952.9452-1-ezequiel@collabora.com>
On 14/12/2019 04:59, Ezequiel Garcia wrote:
> Currently, the interrupt lines requested by Panfrost
> use unmeaningful names, which adds some obscurity
> to interrupt introspection (i.e. any tool based
> on procfs' interrupts file).
>
> In order to improve this, prefix each requested
> interrupt with the module name: panfrost-{gpu,job,mmu}.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
LGTM
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> v2:
> * Use consistent naming, as suggested by Alyssa, Neil and Robin.
>
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 +-
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 6 ++++--
> 3 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index f67ed925c0ef..af2aa6b3bce3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -348,7 +348,7 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
> return -ENODEV;
>
> err = devm_request_irq(pfdev->dev, irq, panfrost_gpu_irq_handler,
> - IRQF_SHARED, "gpu", pfdev);
> + IRQF_SHARED, KBUILD_MODNAME "-gpu", pfdev);
> if (err) {
> dev_err(pfdev->dev, "failed to request gpu irq");
> return err;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 05c85f45a0de..3bd79ebb6c40 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -480,7 +480,7 @@ int panfrost_job_init(struct panfrost_device *pfdev)
> return -ENODEV;
>
> ret = devm_request_irq(pfdev->dev, irq, panfrost_job_irq_handler,
> - IRQF_SHARED, "job", pfdev);
> + IRQF_SHARED, KBUILD_MODNAME "-job", pfdev);
> if (ret) {
> dev_err(pfdev->dev, "failed to request job irq");
> return ret;
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index 842bdd7cf6be..806958434726 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -612,9 +612,11 @@ int panfrost_mmu_init(struct panfrost_device *pfdev)
> if (irq <= 0)
> return -ENODEV;
>
> - err = devm_request_threaded_irq(pfdev->dev, irq, panfrost_mmu_irq_handler,
> + err = devm_request_threaded_irq(pfdev->dev, irq,
> + panfrost_mmu_irq_handler,
> panfrost_mmu_irq_handler_thread,
> - IRQF_SHARED, "mmu", pfdev);
> + IRQF_SHARED, KBUILD_MODNAME "-mmu",
> + pfdev);
>
> if (err) {
> dev_err(pfdev->dev, "failed to request mmu irq");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-16 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 4:59 [PATCH v2] drm/panfrost: Prefix interrupt handlers' names Ezequiel Garcia
2019-12-16 9:52 ` Steven Price [this message]
2019-12-16 15:22 ` Alyssa Rosenzweig
2020-01-20 17:55 ` Ezequiel Garcia
2020-01-21 16:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23c51097-298c-f620-3457-7f5158b3a267@arm.com \
--to=steven.price@arm.com \
--cc=20191213123942.22891-1-ezequiel@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=kernel@collabora.com \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.