From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FDDC432C0 for ; Mon, 2 Dec 2019 02:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3689820725 for ; Mon, 2 Dec 2019 02:58:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="jDceI3nu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="O4z1YV2Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727298AbfLBC6d (ORCPT ); Sun, 1 Dec 2019 21:58:33 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:35687 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727313AbfLBC6d (ORCPT ); Sun, 1 Dec 2019 21:58:33 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 1B3AC7454; Sun, 1 Dec 2019 21:58:32 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Sun, 01 Dec 2019 21:58:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=va9zds2kkUShR4/2SREiF7f/aOZtuH3 Ys0/FEp1ZZwk=; b=jDceI3nutGxbAnXwraCwd0awJdlJLIV6nu86POF1goIGjwj fkJTh25UjJHlQ7tXafJZFsFI7NHapbjsnmJhewc+lZxxF/haezryPBwkxhJLop5U 2UPj59fTtotjlzuHBMUeoCOkC3vJDcLZUY0hE1681x9X84llYSxPii7CAwkO0JRD Y3Kf1A3UWbGqD+cJwqjZ2uXFFj0BO7X+BsTE0zwsDmEZjJfCER0OWUCE271npCWc omInFVhWsmqjRr4VKbndggzaTqhD6FLfznHTRAdvFA+BDRTQrNRl4pBHiwdqLxKu kb/NB1LeH5iDZcLuMkDIY7jVeKrHDAg7ALZi65Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=va9zds 2kkUShR4/2SREiF7f/aOZtuH3Ys0/FEp1ZZwk=; b=O4z1YV2ZcKXlyoADN68i23 fUWjLMPJSxjjrRkBoFgZfVXyFpLVKUdJ2SCkWjXAW8tDpCxh2KA0TQ9MoOF/HKRc yJTW8o05RhhK4QkGB+utHy2CrVKHoUOg19Rv1AiYXlSU1g6snDXKy0Jp85UCyVrq 5BrNdunwfP3AH4ygvU/2X1J2s5iDgvMHtpgww2UsTIY03Svvt2ZSXtiXdqu+TTZx BMWYb+c41h8ePkOmieAulbCZ0DeQhWrCmFZboQ7vp+XhOjjJTBj7GU3wqXVXJO6K m3DIGYhkyxN72TEnNcFGIhWJcIoriJSMDkORVOdJbjEsxFgNqmLhTs9w9Ke9yItg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudejgedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuffhomh grihhnpehlkhhmlhdrohhrghenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvgif segrjhdrihgurdgruhenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D3C7AE00A2; Sun, 1 Dec 2019 21:58:31 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1 Mime-Version: 1.0 Message-Id: <23d79dff-6577-4fba-b7e6-d494ec7b8a93@www.fastmail.com> In-Reply-To: <20191129172537.31410-3-m.felsch@pengutronix.de> References: <20191129172537.31410-1-m.felsch@pengutronix.de> <20191129172537.31410-3-m.felsch@pengutronix.de> Date: Mon, 02 Dec 2019 13:30:04 +1030 From: "Andrew Jeffery" To: "Marco Felsch" , support.opensource@diasemi.com, "Lee Jones" , "Rob Herring" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" , lgirdwood@gmail.com, broonie@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, "Pengutronix Kernel Team" Subject: =?UTF-8?Q?Re:_[PATCH_v3_2/6]_gpio:_make_gpiod=5Fto=5Foffset()_available_?= =?UTF-8?Q?for_other_users?= Content-Type: text/plain Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote: > Currently gpiod_to_offset() is a gpio-subsystem private function which > is used by the gpiolib itself and by the aspeed gpio driver. The time > has shown that there are other drivers as well which need this > information in some special cases e.g. MFD drivers. The patch makes the > function public but you need to explicit add the > include. See discussion [1] for more information. > > [1] https://lkml.org/lkml/2019/11/27/357 > > Signed-off-by: Marco Felsch > --- > v3: > - former patch description was "gpio: add support to get local gpio number" > - adapt commit message and description to reflect new state > - don't add wrapper instead use the already existing gpiod_to_offset > - move gpiod_to_offset from gpiolib.h into gpiolib.c > - move declaration into linux/gpio/private.h > --- > drivers/gpio/gpio-aspeed.c | 11 +++++------ Reviewed-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E2CC432C0 for ; Mon, 2 Dec 2019 02:58:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A76A2146E for ; Mon, 2 Dec 2019 02:58:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OadAGQUC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="jDceI3nu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="O4z1YV2Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A76A2146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ua/3lZSRxl5ovAFNYanD3ceTHL9QEmi+7TiXQ7oDhwA=; b=OadAGQUCVqQPby MyHdd32NfavpvrHkXWJQcHRsJzzVCqk2ES7303KzqBZCx7oO02KX2guOuJUKMB4qsYmJxaQeFPYGe sv4ZvcWCnZKv3syJsTikl+IDXpf0taEYVXArlDC+AVOFobd1lCmyNKQZen7hdnBvyomemV4vZq3lJ fpQRd8NdcczdCrcP+yWJ818laxyqTDrqNbwuJo1Ar3Bjre8RPOcNdXEWUuMMhKPNLGZhz9GWLw8sO 4U5x4vTXKgUWCz850rWbZwwlm/AEjuE8wdgXruO5ovWMsOyLU3kT5zDU45bkPkTBz9EogMiOykCfg VL77JR8aCHDoJ5CGXX1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibbv2-0006VJ-5V; Mon, 02 Dec 2019 02:58:36 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibbuy-0006Uk-VI for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2019 02:58:34 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 1B3AC7454; Sun, 1 Dec 2019 21:58:32 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Sun, 01 Dec 2019 21:58:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=va9zds2kkUShR4/2SREiF7f/aOZtuH3 Ys0/FEp1ZZwk=; b=jDceI3nutGxbAnXwraCwd0awJdlJLIV6nu86POF1goIGjwj fkJTh25UjJHlQ7tXafJZFsFI7NHapbjsnmJhewc+lZxxF/haezryPBwkxhJLop5U 2UPj59fTtotjlzuHBMUeoCOkC3vJDcLZUY0hE1681x9X84llYSxPii7CAwkO0JRD Y3Kf1A3UWbGqD+cJwqjZ2uXFFj0BO7X+BsTE0zwsDmEZjJfCER0OWUCE271npCWc omInFVhWsmqjRr4VKbndggzaTqhD6FLfznHTRAdvFA+BDRTQrNRl4pBHiwdqLxKu kb/NB1LeH5iDZcLuMkDIY7jVeKrHDAg7ALZi65Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=va9zds 2kkUShR4/2SREiF7f/aOZtuH3Ys0/FEp1ZZwk=; b=O4z1YV2ZcKXlyoADN68i23 fUWjLMPJSxjjrRkBoFgZfVXyFpLVKUdJ2SCkWjXAW8tDpCxh2KA0TQ9MoOF/HKRc yJTW8o05RhhK4QkGB+utHy2CrVKHoUOg19Rv1AiYXlSU1g6snDXKy0Jp85UCyVrq 5BrNdunwfP3AH4ygvU/2X1J2s5iDgvMHtpgww2UsTIY03Svvt2ZSXtiXdqu+TTZx BMWYb+c41h8ePkOmieAulbCZ0DeQhWrCmFZboQ7vp+XhOjjJTBj7GU3wqXVXJO6K m3DIGYhkyxN72TEnNcFGIhWJcIoriJSMDkORVOdJbjEsxFgNqmLhTs9w9Ke9yItg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudejgedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuffhomh grihhnpehlkhhmlhdrohhrghenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvgif segrjhdrihgurdgruhenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D3C7AE00A2; Sun, 1 Dec 2019 21:58:31 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-578-g826f590-fmstable-20191119v1 Mime-Version: 1.0 Message-Id: <23d79dff-6577-4fba-b7e6-d494ec7b8a93@www.fastmail.com> In-Reply-To: <20191129172537.31410-3-m.felsch@pengutronix.de> References: <20191129172537.31410-1-m.felsch@pengutronix.de> <20191129172537.31410-3-m.felsch@pengutronix.de> Date: Mon, 02 Dec 2019 13:30:04 +1030 From: "Andrew Jeffery" To: "Marco Felsch" , support.opensource@diasemi.com, "Lee Jones" , "Rob Herring" , "Linus Walleij" , "Bartosz Golaszewski" , "Joel Stanley" , lgirdwood@gmail.com, broonie@kernel.org Subject: =?UTF-8?Q?Re:_[PATCH_v3_2/6]_gpio:_make_gpiod=5Fto=5Foffset()_available_?= =?UTF-8?Q?for_other_users?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191201_185833_143639_93E3F72F X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote: > Currently gpiod_to_offset() is a gpio-subsystem private function which > is used by the gpiolib itself and by the aspeed gpio driver. The time > has shown that there are other drivers as well which need this > information in some special cases e.g. MFD drivers. The patch makes the > function public but you need to explicit add the > include. See discussion [1] for more information. > > [1] https://lkml.org/lkml/2019/11/27/357 > > Signed-off-by: Marco Felsch > --- > v3: > - former patch description was "gpio: add support to get local gpio number" > - adapt commit message and description to reflect new state > - don't add wrapper instead use the already existing gpiod_to_offset > - move gpiod_to_offset from gpiolib.h into gpiolib.c > - move declaration into linux/gpio/private.h > --- > drivers/gpio/gpio-aspeed.c | 11 +++++------ Reviewed-by: Andrew Jeffery _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel