From: Dave Hansen <dave.hansen@intel.com>
To: Borislav Petkov <bp@alien8.de>, Babu Moger <babu.moger@amd.com>
Cc: corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, pbonzini@redhat.com,
sean.j.christopherson@intel.com, x86@kernel.org,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, mchehab+samsung@kernel.org,
changbin.du@intel.com, namit@vmware.com, bigeasy@linutronix.de,
yang.shi@linux.alibaba.com, asteinhauser@google.com,
anshuman.khandual@arm.com, jan.kiszka@siemens.com,
akpm@linux-foundation.org, steven.price@arm.com,
rppt@linux.vnet.ibm.com, peterx@redhat.com,
dan.j.williams@intel.com, arjunroy@google.com,
logang@deltatee.com, thellstrom@vmware.com, aarcange@redhat.com,
justin.he@arm.com, robin.murphy@arm.com, ira.weiny@intel.com,
keescook@chromium.org, jgross@suse.com,
andrew.cooper3@citrix.com, pawan.kumar.gupta@linux.intel.com,
fenghua.yu@intel.com, vineela.tummalapalli@intel.com,
yamada.masahiro@socionext.com, sam@ravnborg.org, acme@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v5] arch/x86: Update config and kernel doc for MPK feature on AMD
Date: Tue, 26 May 2020 08:33:36 -0700 [thread overview]
Message-ID: <23ee5cfa-22ec-a367-04f2-4bca8edcfa9e@intel.com> (raw)
In-Reply-To: <20200523122149.GF27431@zn.tnic>
On 5/23/20 5:21 AM, Borislav Petkov wrote:
>> +config X86_MEMORY_PROTECTION_KEYS
>> + # Set the "INTEL_"-free option whenever the "INTEL_" one is set.
>> + # The "INTEL_" one should be removed and replaced by this option
>> + # after 5.10. This avoids exposing most 'oldconfig' users to this
>> + # churn.
>> + def_bool X86_INTEL_MEMORY_PROTECTION_KEYS
> I only picked up the discussion from the sidelines but why do we need
> this at all? If we don't want to have churn, then we can leave it be
> called X86_INTEL_MEMORY_PROTECTION_KEYS, not change the manpage and
> have this depend on CPU_SUP_AMD too so that people can select it on AMD
> machines, and get on with our lives.
>
> So what's up?
Thanks for pointing that out. I think this ended up mixing together the
two alternative, which doesn't make much sense.
Babu, let's just leave the config option _naming_ entirely in place.
The only change should be to the dependencies and the description text.
prev parent reply other threads:[~2020-05-26 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 22:39 [PATCH v5] arch/x86: Update config and kernel doc for MPK feature on AMD Babu Moger
2020-05-13 22:44 ` Dave Hansen
2020-05-23 12:21 ` Borislav Petkov
2020-05-26 15:33 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ee5cfa-22ec-a367-04f2-4bca8edcfa9e@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=anshuman.khandual@arm.com \
--cc=arjunroy@google.com \
--cc=asteinhauser@google.com \
--cc=babu.moger@amd.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=changbin.du@intel.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=jan.kiszka@siemens.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=justin.he@arm.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sam@ravnborg.org \
--cc=sean.j.christopherson@intel.com \
--cc=steven.price@arm.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
--cc=vineela.tummalapalli@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.