From: Guoyang Zhou <zhouguoyang@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <bluca@debian.org>,
<cloud.wangxiaoyun@huawei.com>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <luojiachen@huawei.com>,
<zhouguoyang@huawei.com>, <chenlizhong@huawei.com>,
<zhaohui8@huawei.com>, <chenchanghu@huawei.com>,
<stevex.yang@intel.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v1 2/3] net/hinic/base: fix the problem of LRO
Date: Fri, 16 Jul 2021 17:54:29 +0800 [thread overview]
Message-ID: <23f4b28a1d1c8b3b3f1b74665030f6a6a4c84b9d.1626429126.git.zhouguoyang@huawei.com> (raw)
In-Reply-To: <cover.1626429126.git.zhouguoyang@huawei.com>
The rx queue must config as ceq disable, and must set msix
state disable. Otherwise when lro is enable, there will be
problems with packet aggregation because of firmware.
Fixes: 9d02f40d6503 ("net/hinic: fix LRO")
Cc: stable@dpdk.org
Signed-off-by: Guoyang Zhou <zhouguoyang@huawei.com>
---
drivers/net/hinic/base/hinic_pmd_nicio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hinic/base/hinic_pmd_nicio.c b/drivers/net/hinic/base/hinic_pmd_nicio.c
index 162308b..ad5db9f 100644
--- a/drivers/net/hinic/base/hinic_pmd_nicio.c
+++ b/drivers/net/hinic/base/hinic_pmd_nicio.c
@@ -230,8 +230,8 @@ static void hinic_rq_prepare_ctxt(struct hinic_rq *rq,
wq_block_pfn_hi = upper_32_bits(wq_block_pfn);
wq_block_pfn_lo = lower_32_bits(wq_block_pfn);
- /* must config as ceq enable but do not generate ceq */
- rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(1, EN) |
+ /* config as ceq disable, but must set msix state disable */
+ rq_ctxt->ceq_attr = RQ_CTXT_CEQ_ATTR_SET(0, EN) |
RQ_CTXT_CEQ_ATTR_SET(1, OWNER);
rq_ctxt->pi_intr_attr = RQ_CTXT_PI_SET(pi_start, IDX) |
--
1.8.3.1
next prev parent reply other threads:[~2021-07-16 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 9:54 [dpdk-dev] [PATCH v1 0/3] fix some problems of mtu, vlan, lro Guoyang Zhou
2021-07-16 9:54 ` [dpdk-dev] [PATCH v1 1/3] net/hinic: increase the protection of the VLAN Guoyang Zhou
2021-07-16 9:54 ` Guoyang Zhou [this message]
2021-07-16 9:54 ` [dpdk-dev] [PATCH v1 3/3] net/hinic: fix the problem of MTU inconsistent Guoyang Zhou
2021-07-23 13:39 ` [dpdk-dev] [PATCH v1 0/3] fix some problems of mtu, vlan, lro Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f4b28a1d1c8b3b3f1b74665030f6a6a4c84b9d.1626429126.git.zhouguoyang@huawei.com \
--to=zhouguoyang@huawei.com \
--cc=bluca@debian.org \
--cc=chenchanghu@huawei.com \
--cc=chenlizhong@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=luojiachen@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=yin.yinshi@huawei.com \
--cc=zhaohui8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.