From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F324428 for ; Tue, 9 Aug 2022 15:28:58 +0000 (UTC) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4M2H326hdJz67hYm; Tue, 9 Aug 2022 23:26:06 +0800 (CST) Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 9 Aug 2022 17:28:49 +0200 Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2375.024; Tue, 9 Aug 2022 17:28:49 +0200 From: Roberto Sassu To: Arnaldo Carvalho de Melo , Andres Freund , Daniel Borkmann CC: "quentin@isovalent.com" , "ast@kernel.org" , "andrii@kernel.org" , "martin.lau@linux.dev" , "song@kernel.org" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@google.com" , "peterz@infradead.org" , "mingo@redhat.com" , "terrelln@fb.com" , "nathan@kernel.org" , "ndesaulniers@google.com" , "bpf@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , "llvm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , Jiri Olsa Subject: RE: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto Thread-Topic: [PATCH 4/4] build: Switch to new openssl API for test-libcrypto Thread-Index: AQHYm5HfT/KQ8BwklE+dy083QuWM9q2lK0sAgAAmxQCAAVr4gIAAAaGAgAAjZQA= Date: Tue, 9 Aug 2022 15:28:49 +0000 Message-ID: <23f8c56f584b4da8acf15d050c0443b6@huawei.com> References: <20220719170555.2576993-1-roberto.sassu@huawei.com> <20220719170555.2576993-4-roberto.sassu@huawei.com> <5f867295-10d2-0085-d1dc-051f56e7136a@iogearbox.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.81.201.209] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CFilter-Loop: Reflected > From: Arnaldo Carvalho de Melo [mailto:acme@kernel.org] > Sent: Tuesday, August 9, 2022 5:21 PM > Em Tue, Aug 09, 2022 at 12:15:25PM -0300, Arnaldo Carvalho de Melo escrev= eu: > > Em Mon, Aug 08, 2022 at 03:33:34PM -0300, Arnaldo Carvalho de Melo > escreveu: > > > Em Mon, Aug 08, 2022 at 06:14:48PM +0200, Daniel Borkmann escreveu: > > > > Hi Arnaldo, > > > > > > > > On 7/19/22 7:05 PM, Roberto Sassu wrote: > > > > > Switch to new EVP API for detecting libcrypto, as Fedora 36 retur= ns an > > > > > error when it encounters the deprecated function MD5_Init() and t= he > others. > > > > > The error would be interpreted as missing libcrypto, while in rea= lity it is > > > > > not. > > > > > > > > > > Signed-off-by: Roberto Sassu > > > > > > > > Given rest of the tooling fixes from Andres Freund went via perf tr= ee and > the > > > > below is perf related as well, I presume you'll pick this up, too? > > > > > > Sure. > > > > > > > [0] > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=3Dp= erf/cor > e > > > > So I fixed up the first one, minor fuzzes, the second I had to fix > > conflicts with the patchset from Andres, ended up as below, will test > > build it then in my container kit. >=20 > So I backtracked, the way it works needs further consideration with > regard to the patchkit from Andres, that is already upstream, so it > would be good for Roberto to take a look at what is in torvalds/master > now and see if we have to removed that styled thing from Andres. Will do. Thanks Arnaldo for adapting the patch. Roberto > Andres, if you could take a look at Roberto's patchkit as well that > would be great. >=20 > - Arnaldo >=20 > > commit bea955a0256e20cc18e87087e42f2a903b9a8b84 > > Author: Roberto Sassu > > Date: Tue Jul 19 19:05:53 2022 +0200 > > > > bpftool: Complete libbfd feature detection > > > > Commit 6e8ccb4f624a7 ("tools/bpf: properly account for libbfd varia= tions") > > sets the linking flags depending on which flavor of the libbfd feat= ure was > > detected. > > > > However, the flavors except libbfd cannot be detected, as they are = not in > > the feature list. > > > > Complete the list of features to detect by adding libbfd-liberty an= d > > libbfd-liberty-z. > > > > Committer notes: > > > > Adjust conflict with with: > > > > 1e1613f64cc8a09d ("tools bpftool: Don't display disassembler-four= -args > feature test") > > 600b7b26c07a070d ("tools bpftool: Fix compilation error with new > binutils") > > > > Fixes: 6e8ccb4f624a73c5 ("tools/bpf: properly account for libbfd va= riations") > > Signed-off-by: Roberto Sassu > > Cc: Alexei Starovoitov > > Cc: Andres Freund > > Cc: Andrii Nakryiko > > Cc: bpf@vger.kernel.org > > Cc: Daniel Borkmann > > Cc: Ingo Molnar > > Cc: John Fastabend > > Cc: KP Singh > > Cc: llvm@lists.linux.dev > > Cc: Martin KaFai Lau > > Cc: Nathan Chancellor > > Cc: Nick Desaulniers > > Cc: Nick Terrell > > Cc: Peter Zijlstra > > Cc: Quentin Monnet > > Cc: Song Liu > > Cc: Stanislav Fomichev > > Link: https://lore.kernel.org/r/20220719170555.2576993-2- > roberto.sassu@huawei.com > > Signed-off-by: Arnaldo Carvalho de Melo > > > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > > index 04d733e98bffbc08..9cc132277150c534 100644 > > --- a/tools/bpf/bpftool/Makefile > > +++ b/tools/bpf/bpftool/Makefile > > @@ -93,9 +93,11 @@ INSTALL ?=3D install > > RM ?=3D rm -f > > > > FEATURE_USER =3D .bpftool > > -FEATURE_TESTS =3D libbfd disassembler-four-args disassembler-init-styl= ed > libcap \ > > +FEATURE_TESTS =3D libbfd libbfd-liberty libbfd-liberty-z > > + disassembler-four-args disassembler-init-styled libcap \ > > clang-bpf-co-re > > -FEATURE_DISPLAY =3D libbfd libcap clang-bpf-co-re > > +FEATURE_DISPLAY =3D libbfd libbfd-liberty libbfd-liberty-z > > + libcap clang-bpf-co-re > > > > check_feat :=3D 1 > > NON_CHECK_FEAT_TARGETS :=3D clean uninstall doc doc-clean doc-install = doc- > uninstall >=20 > -- >=20 > - Arnaldo