All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: MichelleJin <shjy180909@gmail.com>,
	davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
	dsahern@kernel.org, johannes@sipsolutions.net
Cc: saeedm@nvidia.com, leon@kernel.org, roid@nvidia.com,
	paulb@nvidia.com, ozsh@nvidia.com, vladbu@nvidia.com,
	lariel@nvidia.com, cmi@nvidia.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] net: ipv6: check return value of rhashtable_init
Date: Sat, 25 Sep 2021 10:38:41 -0600	[thread overview]
Message-ID: <23ffeeb2-6795-dcb5-8bfb-9e385d9960d9@gmail.com> (raw)
In-Reply-To: <20210925061037.4555-3-shjy180909@gmail.com>

On 9/25/21 12:10 AM, MichelleJin wrote:
> diff --git a/net/ipv6/seg6_hmac.c b/net/ipv6/seg6_hmac.c
> index 687d95dce085..a78554993163 100644
> --- a/net/ipv6/seg6_hmac.c
> +++ b/net/ipv6/seg6_hmac.c
> @@ -403,9 +403,13 @@ EXPORT_SYMBOL(seg6_hmac_init);
>  
>  int __net_init seg6_hmac_net_init(struct net *net)
>  {
> +	int err;
> +
>  	struct seg6_pernet_data *sdata = seg6_pernet(net);
>  
> -	rhashtable_init(&sdata->hmac_infos, &rht_params);
> +	err = rhashtable_init(&sdata->hmac_infos, &rht_params);
> +	if (err)
> +		return err;
>  
>  	return 0;

Just:

return rhashtable_init(&sdata->hmac_infos, &rht_params);

  reply	other threads:[~2021-09-25 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  6:10 [PATCH net-next v3 0/3] check return value of rhashtable_init in mlx5e, ipv6, mac80211 MichelleJin
2021-09-25  6:10 ` [PATCH net-next v3 1/3] net/mlx5e: check return value of rhashtable_init MichelleJin
2021-09-25  6:10 ` [PATCH net-next v3 2/3] net: ipv6: " MichelleJin
2021-09-25 16:38   ` David Ahern [this message]
2021-09-25  6:10 ` [PATCH net-next v3 3/3] net: mac80211: " MichelleJin
2021-09-25  7:26 ` [PATCH net-next v3 0/3] check return value of rhashtable_init in mlx5e, ipv6, mac80211 진성희
  -- strict thread matches above, loose matches on Subject: below --
2021-09-25  6:05 MichelleJin
2021-09-25  6:05 ` [PATCH net-next v3 2/3] net: ipv6: check return value of rhashtable_init MichelleJin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23ffeeb2-6795-dcb5-8bfb-9e385d9960d9@gmail.com \
    --to=dsahern@gmail.com \
    --cc=cmi@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=lariel@nvidia.com \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ozsh@nvidia.com \
    --cc=paulb@nvidia.com \
    --cc=roid@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=shjy180909@gmail.com \
    --cc=vladbu@nvidia.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.