From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B778C47080 for ; Mon, 31 May 2021 17:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFD34610A1 for ; Mon, 31 May 2021 17:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232611AbhEaRsc (ORCPT ); Mon, 31 May 2021 13:48:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231637AbhEaRrx (ORCPT ); Mon, 31 May 2021 13:47:53 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D768C0612B0 for ; Mon, 31 May 2021 10:24:43 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id z8so6491000wrp.12 for ; Mon, 31 May 2021 10:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=npCJsIAlG0AK9KBENp32ZM+mC6ayXbFk+En/Omp/21w=; b=lo6+BR3ozPLp5b6btwKr8E00QvJKGphA3AdNvgEKPrH7TDIss2jrGGXYW+GpRyUYKS bnFhsI2foJPLq2md028wP3qWQrv+cy/fdaDfWqpOrqn48W1u84Y2190CL+SGarkTIDGz 4IGMmFu29XPRhMmtaryBKD4ShkENOHfGBJjSK3Lv6zidffPaiC3icEq7zkXMxV2JqXNs Z773X2cjcHvLd2DwU3TmeZ3df/PMIKlUvUTgUyG3n96yf818zWY+KK8gxHiLhOu3OtX5 gaPEQ1YCCTwYc9J+AtSlqQgeT9HSDbR5D1BojK7ShZzcLPLlwg60GCLQHlmHast4byds upuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=npCJsIAlG0AK9KBENp32ZM+mC6ayXbFk+En/Omp/21w=; b=ENVgNLUjRYpR8QqHryyV7P11yrAzrLXjmkYpxwFj7cgxvBqn/V3YR2UqHgw0zdMd9a M/rPDiafUv3OI9fNq0CjkIh+wkN4ScuCgJFVkE+iC5wCzCU6wdcVNl6x6aTz4mnd28iL u+grOQ+ETB2gPEDbXpSD2IFwdBCeo7O9CwatH5pjVCfAq6jhgSm8BqDjHv584+FfCMRn cuzL7aj5EVbhIS57f6yoTHZXYq22IHcV/aMxjqcq63Aeimc+EW3Qod+tar01C5trQ09n I7SsJgH3b+MmgPHaj9XbOtit9Au0NYQabPcIk6O2knclJhvlmbMUXWEeeObIuKE5dc01 vavg== X-Gm-Message-State: AOAM5339dzjk0nJrEYzosaGB3yNwTJJTp0tsQzwxcXUoohovY9SgYq63 QVv383cgiCYE/F0uHP+GiZAmr9e1aRvxIQ== X-Google-Smtp-Source: ABdhPJwfIhebaxVtlRqoOrfF4WPi9JPXzuniJFs+svcj4biNbP9l8Xc5FO9VQ1eFURCiKU0dCa8mDw== X-Received: by 2002:a5d:4d05:: with SMTP id z5mr22877966wrt.127.1622481881791; Mon, 31 May 2021 10:24:41 -0700 (PDT) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net. [86.58.17.133]) by smtp.gmail.com with ESMTPSA id b135sm90191wmb.5.2021.05.31.10.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 10:24:41 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Roman Stratiienko Cc: mripard@kernel.org, wens@csie.org, jernej.skrabec@siol.net, megous@megous.com, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Roman Stratiienko Subject: Re: [PATCH v4 1/2] drm/sun4i: Add mode_set callback to the engine Date: Mon, 31 May 2021 19:24:40 +0200 Message-ID: <2404786.ubhusWIBXB@kista> In-Reply-To: <20210528203036.17999-2-r.stratiienko@gmail.com> References: <20210528203036.17999-1-r.stratiienko@gmail.com> <20210528203036.17999-2-r.stratiienko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Dne petek, 28. maj 2021 ob 22:30:35 CEST je Roman Stratiienko napisal(a): > Create callback to allow updating engine's registers on mode change. > > Signed-off-by: Roman Stratiienko > Reviewed-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++ > drivers/gpu/drm/sun4i/sunxi_engine.h | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/ sun4i_crtc.c > index 45d9eb552d86..8f01a6b2bbef 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c > +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c > @@ -146,6 +146,9 @@ static void sun4i_crtc_mode_set_nofb(struct drm_crtc *crtc) > struct sun4i_crtc *scrtc = drm_crtc_to_sun4i_crtc(crtc); > > sun4i_tcon_mode_set(scrtc->tcon, encoder, mode); > + > + if (scrtc->engine->ops->mode_set) > + scrtc->engine->ops->mode_set(scrtc->engine, mode); > } > > static const struct drm_crtc_helper_funcs sun4i_crtc_helper_funcs = { > diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/ sunxi_engine.h > index 548710a936d5..7faa844646ff 100644 > --- a/drivers/gpu/drm/sun4i/sunxi_engine.h > +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h > @@ -9,6 +9,7 @@ > struct drm_plane; > struct drm_device; > struct drm_crtc_state; > +struct drm_display_mode; > > struct sunxi_engine; > > @@ -108,6 +109,17 @@ struct sunxi_engine_ops { > * This function is optional. > */ > void (*vblank_quirk)(struct sunxi_engine *engine); > + > + /** > + * @mode_set: > + * > + * This callback is used to update engine registers that > + * responsible for display frame size and other mode attributes. > + * > + * This function is optional. > + */ > + void (*mode_set)(struct sunxi_engine *engine, > + struct drm_display_mode *mode); Mark mode as const. Best regards, Jernej > }; > > /** > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75ADC47082 for ; Mon, 31 May 2021 21:20:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FC396124B for ; Mon, 31 May 2021 21:20:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FC396124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 464F46E580; Mon, 31 May 2021 21:20:11 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CFC06E511 for ; Mon, 31 May 2021 17:24:43 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id q5so11611020wrs.4 for ; Mon, 31 May 2021 10:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=npCJsIAlG0AK9KBENp32ZM+mC6ayXbFk+En/Omp/21w=; b=lo6+BR3ozPLp5b6btwKr8E00QvJKGphA3AdNvgEKPrH7TDIss2jrGGXYW+GpRyUYKS bnFhsI2foJPLq2md028wP3qWQrv+cy/fdaDfWqpOrqn48W1u84Y2190CL+SGarkTIDGz 4IGMmFu29XPRhMmtaryBKD4ShkENOHfGBJjSK3Lv6zidffPaiC3icEq7zkXMxV2JqXNs Z773X2cjcHvLd2DwU3TmeZ3df/PMIKlUvUTgUyG3n96yf818zWY+KK8gxHiLhOu3OtX5 gaPEQ1YCCTwYc9J+AtSlqQgeT9HSDbR5D1BojK7ShZzcLPLlwg60GCLQHlmHast4byds upuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=npCJsIAlG0AK9KBENp32ZM+mC6ayXbFk+En/Omp/21w=; b=B66RrkIk7BDjtu4U+vcpoTUJ9mccrLN0QJbNOtT79b5X5NZv4oQ/s6Tr6t8nBJPAX9 NY+ggcQqth2GgCQSaP7ioXFj6SOqT7yX/K8G/urH9wxuONgLmjFudaMFDPvIsH4fTADw CVNvnaMSZloqjIZkRVNjG4NE044ZPwX8Tnw3AMgZ0TpKQ0pWcK1M4wT/x3iskmG+3UJa UPiEFriI6psnZavGQA7bCWdNd2acqodiWhIB22YY39IgDMlkjDLCKYUhOu73bIO3SzRc yxyaEQptETayk3j72qEfiSWSKJzs6acjIm/e1YjCuhFWqlR9lDxHcDxo1F+tZWBBtnlU xglg== X-Gm-Message-State: AOAM531SPzelcNRtLRwCf/Yd8j8A9U3YLf/VtWiHDLut6SqZBz5kNHdI ZX3lZBNjQclYV3ivZI0GDU8= X-Google-Smtp-Source: ABdhPJwfIhebaxVtlRqoOrfF4WPi9JPXzuniJFs+svcj4biNbP9l8Xc5FO9VQ1eFURCiKU0dCa8mDw== X-Received: by 2002:a5d:4d05:: with SMTP id z5mr22877966wrt.127.1622481881791; Mon, 31 May 2021 10:24:41 -0700 (PDT) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net. [86.58.17.133]) by smtp.gmail.com with ESMTPSA id b135sm90191wmb.5.2021.05.31.10.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 10:24:41 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Roman Stratiienko Subject: Re: [PATCH v4 1/2] drm/sun4i: Add mode_set callback to the engine Date: Mon, 31 May 2021 19:24:40 +0200 Message-ID: <2404786.ubhusWIBXB@kista> In-Reply-To: <20210528203036.17999-2-r.stratiienko@gmail.com> References: <20210528203036.17999-1-r.stratiienko@gmail.com> <20210528203036.17999-2-r.stratiienko@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Mailman-Approved-At: Mon, 31 May 2021 21:20:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: megous@megous.com, jernej.skrabec@siol.net, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, wens@csie.org, Roman Stratiienko Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi! Dne petek, 28. maj 2021 ob 22:30:35 CEST je Roman Stratiienko napisal(a): > Create callback to allow updating engine's registers on mode change. > > Signed-off-by: Roman Stratiienko > Reviewed-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++ > drivers/gpu/drm/sun4i/sunxi_engine.h | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/ sun4i_crtc.c > index 45d9eb552d86..8f01a6b2bbef 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c > +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c > @@ -146,6 +146,9 @@ static void sun4i_crtc_mode_set_nofb(struct drm_crtc *crtc) > struct sun4i_crtc *scrtc = drm_crtc_to_sun4i_crtc(crtc); > > sun4i_tcon_mode_set(scrtc->tcon, encoder, mode); > + > + if (scrtc->engine->ops->mode_set) > + scrtc->engine->ops->mode_set(scrtc->engine, mode); > } > > static const struct drm_crtc_helper_funcs sun4i_crtc_helper_funcs = { > diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/ sunxi_engine.h > index 548710a936d5..7faa844646ff 100644 > --- a/drivers/gpu/drm/sun4i/sunxi_engine.h > +++ b/drivers/gpu/drm/sun4i/sunxi_engine.h > @@ -9,6 +9,7 @@ > struct drm_plane; > struct drm_device; > struct drm_crtc_state; > +struct drm_display_mode; > > struct sunxi_engine; > > @@ -108,6 +109,17 @@ struct sunxi_engine_ops { > * This function is optional. > */ > void (*vblank_quirk)(struct sunxi_engine *engine); > + > + /** > + * @mode_set: > + * > + * This callback is used to update engine registers that > + * responsible for display frame size and other mode attributes. > + * > + * This function is optional. > + */ > + void (*mode_set)(struct sunxi_engine *engine, > + struct drm_display_mode *mode); Mark mode as const. Best regards, Jernej > }; > > /** >