Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com, fady@mellanox.com,
	Narcisa.Vasile@microsoft.com, dmitry.kozliuk@gmail.com,
	ferruh.yigit@intel.com, jingjing.wu@intel.com,
	beilei.xing@intel.com, ranjit.menon@intel.com,
	shivanshu.shukla@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random
Date: Thu, 30 Sep 2021 18:46:29 +0200	[thread overview]
Message-ID: <2407308.xtS4jV28jI@thomas> (raw)
In-Reply-To: <20210909232321.5091-3-pallavi.kadam@intel.com>

10/09/2021 01:23, Pallavi Kadam:
> IAVF PMD needs to generate a random MAC address if it is not configured
> by host.
> 'random' is now supported on Windows.

This patch can be the first of this series
to respect the dependency order.

> Fixes: 16f0d03098cb ("net: build on Windows")
> Cc: fady@mellanox.com
> Cc: stable@dpdk.org

This commit log does not explain why it was disabled before,
and what makes it possible now, but for sure,
there is no need to backport.
I will remove above lines.

> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  rte_eth_random_addr(uint8_t *addr)
>  {
> -#ifdef RTE_EXEC_ENV_WINDOWS /* FIXME: random is not supported */
> -	RTE_SET_USED(addr);
> -#else
>  	uint64_t rand = rte_rand();
>  	uint8_t *p = (uint8_t *)&rand;
>  
>  	rte_memcpy(addr, p, RTE_ETHER_ADDR_LEN);
>  	addr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR;	/* clear multicast bit */
>  	addr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR;	/* set local assignment bit */
> -#endif
>  }