On 15.09.2016 18:10, Peter Maydell wrote: > On 14 September 2016 at 17:40, Max Reitz wrote: >> The following changes since commit 507e4ddc3abf67391bcbc9624fd60b969c159b78: >> >> Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2016-09-13 17:55:35 +0100) >> >> are available in the git repository at: >> >> git://github.com/XanClic/qemu.git tags/pull-block-2016-09-14 >> >> for you to fetch changes up to 262a8020cf666ae7108040683038cc46be4c48d2: >> >> iotest 055: refactor and speed up (2016-09-14 17:56:42 +0200) >> >> ---------------------------------------------------------------- >> Block patches for 2.8 >> >> ---------------------------------------------------------------- > > Compile failure on 32 bit: > CC util/qemu-option.o > /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialization_size': > /home/petmay01/qemu/util/hbitmap.c:439:5: error: passing argument 5 of > 'serialization_chunk' from incompatible pointer type [-Werror] > serialization_chunk(hb, start, count, &cur, &el_count); > ^ > /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *' > but argument is of type 'uint64_t *' > static void serialization_chunk(const HBitmap *hb, > ^ > /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_serialize_part': > /home/petmay01/qemu/util/hbitmap.c:453:5: error: passing argument 5 of > 'serialization_chunk' from incompatible pointer type [-Werror] > serialization_chunk(hb, start, count, &cur, &el_count); > ^ > /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *' > but argument is of type 'uint64_t *' > static void serialization_chunk(const HBitmap *hb, > ^ > /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_part': > /home/petmay01/qemu/util/hbitmap.c:476:5: error: passing argument 5 of > 'serialization_chunk' from incompatible pointer type [-Werror] > serialization_chunk(hb, start, count, &cur, &el_count); > ^ > /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *' > but argument is of type 'uint64_t *' > static void serialization_chunk(const HBitmap *hb, > ^ > /home/petmay01/qemu/util/hbitmap.c: In function 'hbitmap_deserialize_zeroes': > /home/petmay01/qemu/util/hbitmap.c:505:5: error: passing argument 5 of > 'serialization_chunk' from incompatible pointer type [-Werror] > serialization_chunk(hb, start, count, &first, &el_count); > ^ > /home/petmay01/qemu/util/hbitmap.c:410:13: note: expected 'size_t *' > but argument is of type 'uint64_t *' > static void serialization_chunk(const HBitmap *hb, > ^ > cc1: all warnings being treated as errors > > > Test failure on big-endian ppc64be: > > /hbitmap/serialize/granularity: OK > /hbitmap/serialize/basic: ** > ERROR:/home/pm215/qemu/tests/test-hbitmap.c:774:hbitmap_test_serialize_range: > assertion failed: (is_set) > FAIL > GTester: last random seed: R02Se8652df9788b7a1ec926da1717ff2d26 > (pid=34146) > /hbitmap/serialize/part: ** > ERROR:/home/pm215/qemu/tests/test-hbitmap.c:843:test_hbitmap_serialize_part: > assertion failed (should_set == test_bit(j, (unsigned long *)buf)): (1 > == 0) > FAIL > GTester: last random seed: R02S3e07d1d6dcda6b90721e062eca26e6b9 > (pid=34147) > /hbitmap/serialize/zeroes: OK > FAIL: tests/test-hbitmap Thank you! That looks interesting. I'll drop the series in question from my queue and send a v2. Max