From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649F371 for ; Sat, 10 Apr 2021 09:56:51 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id g17so8555358edm.6 for ; Sat, 10 Apr 2021 02:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R7rBJwvSAC/U1G/3zxbwR8KyBOKUXLbBfKOEweX//uY=; b=NErw0TlHpG+ciy/hxMying/Srgf0B9zekhOJhuYaDR23UNAPrZEdMoXSrijuTarJET 5WMeRO26b30orBqbL9eYFdLuEV5UcnlYTInKiZiaqup4J9LWLq/SBoKdJpaFhHDHPzCU fPFx9k0zEJ6HyxVRelnydGHG7ZOiAJ+EPwVoZHj03/UHHDtFleHXEokYwOCoN8ZoSuRJ HKyTHpSrG/89jlzjEKiD8u6jH/L5OYfiStV6da+NAjsvzYBEHuwogdo2/7lidszjIXxQ tksN3r0yIy+3q4+vZy5lZd9JbWFt4KAsbmMbGJDpdd3a7Qi95yV+OCH8RrpDbE6m5MT6 AVAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R7rBJwvSAC/U1G/3zxbwR8KyBOKUXLbBfKOEweX//uY=; b=ezvbFRNvt6HAL8Vyw5zBYjeyjPEkRgX/W0vYzfCV6OgNCAqkEquepUX690hqxKJH+f +CWBcZSPJhERPAYVnV53QprqPG2Kl7aB1KyQ9AzkqNkMg0VIKQDeMjTmiC7wOM5XZklN 7mB10F4qRKLIZCwyTx+eVSrqeN1/ebMB90SJHOb2Hj947qfG1NeekQRLGRthL/W9OsZj jtDL985uPdCukGhq/m83USWdMEnT3yBtExP/KumOi8zQJv9qGiYRCCX3qLd3BrZlze7C wqwzj9G4CJF8+pHkRKdsiedudPz5Ny2guefSGJgbg8uApTQMN0hO3+ujwhrf1KhwXbqy 3pGQ== X-Gm-Message-State: AOAM530SYFpcph51QD0Fw6b7k5/i5wc9Of2IOjpFAR7frZ3FpU+ur9DY 7nN+WJod3Ktxl/gRogwtQl0= X-Google-Smtp-Source: ABdhPJyq0zgm5wR9LvWiesZ3tQROh+rNBKo1IgyXHhG5GB+hK/nkqpnsHWeEj15Vyp2t3dAT1QQ8Eg== X-Received: by 2002:a05:6402:104c:: with SMTP id e12mr20648735edu.108.1618048609947; Sat, 10 Apr 2021 02:56:49 -0700 (PDT) Received: from localhost.localdomain (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id p4sm2209078edr.43.2021.04.10.02.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 02:56:49 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg KH Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable Date: Sat, 10 Apr 2021 11:56:48 +0200 Message-ID: <24152421.bNubvhIgUM@localhost.localdomain> In-Reply-To: References: <20210410092232.15155-1-fmdefrancesco@gmail.com> <20210410092232.15155-5-fmdefrancesco@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Saturday, April 10, 2021 11:31:16 AM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > > Change the type of fw_current_in_ps_mode from u8 to bool, because > > it is used everywhere as a bool and, accordingly, it should be > > declared as a bool. Shorten the controlling > > expression of an 'if' statement. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c > > b/drivers/staging/rtl8723bs/hal/hal_intf.c index > > 96fe172ced8d..8dc4dd8c6d4c 100644 > > --- a/drivers/staging/rtl8723bs/hal/hal_intf.c > > +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c > > @@ -348,7 +348,7 @@ void rtw_hal_dm_watchdog(struct adapter *padapter) > > > > void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter) > > { > > > > - if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode == true) { > > + if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) { > > > > if (padapter->HalFunc.hal_dm_watchdog_in_lps) > > > > padapter- >HalFunc.hal_dm_watchdog_in_lps(padapter); /* this > > function caller is in interrupt context */> > > } > > > > diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index > > 0a48f1653be5..0767dbb84199 100644 > > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > @@ -203,7 +203,7 @@ struct pwrctrl_priv { > > > > u8 LpsIdleCount; > > u8 power_mgnt; > > u8 org_power_mgnt; > > > > - u8 fw_current_in_ps_mode; > > + bool fw_current_in_ps_mode; > > > > unsigned long DelayLPSLastTimeStamp; > > s32 pnp_current_pwr_state; > > u8 pnp_bstop_trx; > > If this is only checked, how can it ever be true? Who ever sets this > value? > You're right. It is not set, therefore the "if" control expression cannot ever be "true". Can I delete this statement in a new patch? Or you prefer I send the whole series again with this change in patch 4/4? Thanks, Fabio > > thanks, > > greg k-h