All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, Michael Straube <straube.linux@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	martin@kaiser.cx, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: Re: [PATCH v2 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e
Date: Wed, 15 Sep 2021 15:34:23 +0200	[thread overview]
Message-ID: <2416232.Kz4EfdPaPr@localhost.localdomain> (raw)
In-Reply-To: <20210915090156.4169-1-straube.linux@gmail.com>

On Wednesday, September 15, 2021 11:01:52 AM CEST Michael Straube wrote:
> This series removes some unused fields from struct hal_data_8188eu.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> v1 -> v2
> Fixed a typo in the subject line of patch 3/4.
> 
> Michael Straube (4):
>   staging: r8188eu: remove unused macros from rtl8188e_hal.h
>   staging: r8188eu: remove write-only fields from struct hal_data_8188e
>   staging: r8188eu: remove unused enums from rtl8188e_hal.h
>   staging: r8188eu: remove unused field from struct hal_data_8188e
> 
>  .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  5 -----
>  .../staging/r8188eu/include/rtl8188e_hal.h    | 22 -------------------
>  2 files changed, 27 deletions(-)
> 
> -- 
> 2.33.0

Hi Michael,

Due to your removals, this driver is now about a third lighter. After fixing  
that little issue that Philip noticed, this series looks as good as any of 
yours. So...

Acked-by:  Fabio M. De Francesco <fmdefrancesco@gmail.com>

Thanks,

Fabio




  parent reply	other threads:[~2021-09-15 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:01 [PATCH v2 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2021-09-15  9:01 ` [PATCH v2 1/4] staging: r8188eu: remove unused macros from rtl8188e_hal.h Michael Straube
2021-09-15  9:01 ` [PATCH v2 2/4] staging: r8188eu: remove write-only fields from struct hal_data_8188e Michael Straube
2021-09-15  9:01 ` [PATCH v2 3/4] staging: r8188eu: remove unused enums from rtl8188e_hal.h Michael Straube
2021-09-15  9:01 ` [PATCH v2 4/4] staging: r8188eu: remove unused field from struct hal_data_8188e Michael Straube
2021-09-15 13:34 ` Fabio M. De Francesco [this message]
2021-09-15 15:49   ` [PATCH v2 0/4] staging: r8188eu: remove unused fields " Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2416232.Kz4EfdPaPr@localhost.localdomain \
    --to=fmdefrancesco@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.