All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
@ 2022-01-04 14:09 ` Lad Prabhakar
  0 siblings, 0 replies; 8+ messages in thread
From: Lad Prabhakar @ 2022-01-04 14:09 UTC (permalink / raw)
  To: Ludovic Desroches, Linus Walleij, Nicolas Ferre, Alexandre Belloni
  Cc: Rob Herring, Andy Shevchenko, Prabhakar, Lad Prabhakar,
	linux-arm-kernel, linux-gpio, linux-kernel

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
prints an error message upon error.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
* Switched using platform_get_irq()
* Replaced dev_err() with dev_dbg()

v1: https://lore.kernel.org/lkml/20211224145748.18754-3-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 drivers/pinctrl/pinctrl-at91-pio4.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
index fafd1f55cba7..517f2a6330ad 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -1045,7 +1045,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
 	const char **group_names;
 	const struct of_device_id *match;
 	int i, ret;
-	struct resource	*res;
 	struct atmel_pioctrl *atmel_pioctrl;
 	const struct atmel_pioctrl_data *atmel_pioctrl_data;
 
@@ -1164,16 +1163,15 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
 
 	/* There is one controller but each bank has its own irq line. */
 	for (i = 0; i < atmel_pioctrl->nbanks; i++) {
-		res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
-		if (!res) {
-			dev_err(dev, "missing irq resource for group %c\n",
+		ret = platform_get_irq(pdev, i);
+		if (ret < 0) {
+			dev_dbg(dev, "missing irq resource for group %c\n",
 				'A' + i);
-			return -EINVAL;
+			return ret;
 		}
-		atmel_pioctrl->irqs[i] = res->start;
-		irq_set_chained_handler_and_data(res->start,
-			atmel_gpio_irq_handler, atmel_pioctrl);
-		dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
+		atmel_pioctrl->irqs[i] = ret;
+		irq_set_chained_handler_and_data(ret, atmel_gpio_irq_handler, atmel_pioctrl);
+		dev_dbg(dev, "bank %i: irq=%d\n", i, ret);
 	}
 
 	atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
@ 2022-01-04 14:09 ` Lad Prabhakar
  0 siblings, 0 replies; 8+ messages in thread
From: Lad Prabhakar @ 2022-01-04 14:09 UTC (permalink / raw)
  To: Ludovic Desroches, Linus Walleij, Nicolas Ferre, Alexandre Belloni
  Cc: Rob Herring, Andy Shevchenko, Prabhakar, Lad Prabhakar,
	linux-arm-kernel, linux-gpio, linux-kernel

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
prints an error message upon error.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
* Switched using platform_get_irq()
* Replaced dev_err() with dev_dbg()

v1: https://lore.kernel.org/lkml/20211224145748.18754-3-prabhakar.mahadev-lad.rj@bp.renesas.com/
---
 drivers/pinctrl/pinctrl-at91-pio4.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
index fafd1f55cba7..517f2a6330ad 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -1045,7 +1045,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
 	const char **group_names;
 	const struct of_device_id *match;
 	int i, ret;
-	struct resource	*res;
 	struct atmel_pioctrl *atmel_pioctrl;
 	const struct atmel_pioctrl_data *atmel_pioctrl_data;
 
@@ -1164,16 +1163,15 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
 
 	/* There is one controller but each bank has its own irq line. */
 	for (i = 0; i < atmel_pioctrl->nbanks; i++) {
-		res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
-		if (!res) {
-			dev_err(dev, "missing irq resource for group %c\n",
+		ret = platform_get_irq(pdev, i);
+		if (ret < 0) {
+			dev_dbg(dev, "missing irq resource for group %c\n",
 				'A' + i);
-			return -EINVAL;
+			return ret;
 		}
-		atmel_pioctrl->irqs[i] = res->start;
-		irq_set_chained_handler_and_data(res->start,
-			atmel_gpio_irq_handler, atmel_pioctrl);
-		dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
+		atmel_pioctrl->irqs[i] = ret;
+		irq_set_chained_handler_and_data(ret, atmel_gpio_irq_handler, atmel_pioctrl);
+		dev_dbg(dev, "bank %i: irq=%d\n", i, ret);
 	}
 
 	atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
  2022-01-04 14:09 ` Lad Prabhakar
@ 2022-01-16  0:00   ` Linus Walleij
  -1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-01-16  0:00 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Ludovic Desroches, Nicolas Ferre, Alexandre Belloni, Rob Herring,
	Andy Shevchenko, Prabhakar, linux-arm-kernel, linux-gpio,
	linux-kernel

On Tue, Jan 4, 2022 at 3:10 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> * Switched using platform_get_irq()
> * Replaced dev_err() with dev_dbg()

Looks good to me but I'd like some ACK from a Microchip person
before I merge this (for v5.18).

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
@ 2022-01-16  0:00   ` Linus Walleij
  0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-01-16  0:00 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Alexandre Belloni, linux-kernel, Ludovic Desroches, linux-gpio,
	Andy Shevchenko, Rob Herring, Prabhakar, linux-arm-kernel

On Tue, Jan 4, 2022 at 3:10 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> * Switched using platform_get_irq()
> * Replaced dev_err() with dev_dbg()

Looks good to me but I'd like some ACK from a Microchip person
before I merge this (for v5.18).

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
  2022-01-04 14:09 ` Lad Prabhakar
@ 2022-01-17  8:00   ` Tudor.Ambarus
  -1 siblings, 0 replies; 8+ messages in thread
From: Tudor.Ambarus @ 2022-01-17  8:00 UTC (permalink / raw)
  To: prabhakar.mahadev-lad.rj, Ludovic.Desroches, linus.walleij,
	Nicolas.Ferre, alexandre.belloni
  Cc: robh+dt, andy.shevchenko, prabhakar.csengg, linux-arm-kernel,
	linux-gpio, linux-kernel

On 1/4/22 4:09 PM, Lad Prabhakar wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
> 
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>

thanks,
ta
> ---
> v1->v2
> * Switched using platform_get_irq()
> * Replaced dev_err() with dev_dbg()
> 
> v1: https://lore.kernel.org/lkml/20211224145748.18754-3-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index fafd1f55cba7..517f2a6330ad 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -1045,7 +1045,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
>         const char **group_names;
>         const struct of_device_id *match;
>         int i, ret;
> -       struct resource *res;
>         struct atmel_pioctrl *atmel_pioctrl;
>         const struct atmel_pioctrl_data *atmel_pioctrl_data;
> 
> @@ -1164,16 +1163,15 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
> 
>         /* There is one controller but each bank has its own irq line. */
>         for (i = 0; i < atmel_pioctrl->nbanks; i++) {
> -               res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
> -               if (!res) {
> -                       dev_err(dev, "missing irq resource for group %c\n",
> +               ret = platform_get_irq(pdev, i);
> +               if (ret < 0) {
> +                       dev_dbg(dev, "missing irq resource for group %c\n",
>                                 'A' + i);
> -                       return -EINVAL;
> +                       return ret;
>                 }
> -               atmel_pioctrl->irqs[i] = res->start;
> -               irq_set_chained_handler_and_data(res->start,
> -                       atmel_gpio_irq_handler, atmel_pioctrl);
> -               dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
> +               atmel_pioctrl->irqs[i] = ret;
> +               irq_set_chained_handler_and_data(ret, atmel_gpio_irq_handler, atmel_pioctrl);
> +               dev_dbg(dev, "bank %i: irq=%d\n", i, ret);
>         }
> 
>         atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,
> --
> 2.17.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
@ 2022-01-17  8:00   ` Tudor.Ambarus
  0 siblings, 0 replies; 8+ messages in thread
From: Tudor.Ambarus @ 2022-01-17  8:00 UTC (permalink / raw)
  To: prabhakar.mahadev-lad.rj, Ludovic.Desroches, linus.walleij,
	Nicolas.Ferre, alexandre.belloni
  Cc: robh+dt, andy.shevchenko, prabhakar.csengg, linux-arm-kernel,
	linux-gpio, linux-kernel

On 1/4/22 4:09 PM, Lad Prabhakar wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
> 
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>

thanks,
ta
> ---
> v1->v2
> * Switched using platform_get_irq()
> * Replaced dev_err() with dev_dbg()
> 
> v1: https://lore.kernel.org/lkml/20211224145748.18754-3-prabhakar.mahadev-lad.rj@bp.renesas.com/
> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index fafd1f55cba7..517f2a6330ad 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -1045,7 +1045,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
>         const char **group_names;
>         const struct of_device_id *match;
>         int i, ret;
> -       struct resource *res;
>         struct atmel_pioctrl *atmel_pioctrl;
>         const struct atmel_pioctrl_data *atmel_pioctrl_data;
> 
> @@ -1164,16 +1163,15 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
> 
>         /* There is one controller but each bank has its own irq line. */
>         for (i = 0; i < atmel_pioctrl->nbanks; i++) {
> -               res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
> -               if (!res) {
> -                       dev_err(dev, "missing irq resource for group %c\n",
> +               ret = platform_get_irq(pdev, i);
> +               if (ret < 0) {
> +                       dev_dbg(dev, "missing irq resource for group %c\n",
>                                 'A' + i);
> -                       return -EINVAL;
> +                       return ret;
>                 }
> -               atmel_pioctrl->irqs[i] = res->start;
> -               irq_set_chained_handler_and_data(res->start,
> -                       atmel_gpio_irq_handler, atmel_pioctrl);
> -               dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
> +               atmel_pioctrl->irqs[i] = ret;
> +               irq_set_chained_handler_and_data(ret, atmel_gpio_irq_handler, atmel_pioctrl);
> +               dev_dbg(dev, "bank %i: irq=%d\n", i, ret);
>         }
> 
>         atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,
> --
> 2.17.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
  2022-01-04 14:09 ` Lad Prabhakar
@ 2022-01-19 16:12   ` Linus Walleij
  -1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-01-19 16:12 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Ludovic Desroches, Nicolas Ferre, Alexandre Belloni, Rob Herring,
	Andy Shevchenko, Prabhakar, linux-arm-kernel, linux-gpio,
	linux-kernel

On Tue, Jan 4, 2022 at 3:10 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt
@ 2022-01-19 16:12   ` Linus Walleij
  0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2022-01-19 16:12 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Alexandre Belloni, linux-kernel, Ludovic Desroches, linux-gpio,
	Andy Shevchenko, Rob Herring, Prabhakar, linux-arm-kernel

On Tue, Jan 4, 2022 at 3:10 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:

> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
> prints an error message upon error.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch applied!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-01-19 16:13 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 14:09 [PATCH v2] pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt Lad Prabhakar
2022-01-04 14:09 ` Lad Prabhakar
2022-01-16  0:00 ` Linus Walleij
2022-01-16  0:00   ` Linus Walleij
2022-01-17  8:00 ` Tudor.Ambarus
2022-01-17  8:00   ` Tudor.Ambarus
2022-01-19 16:12 ` Linus Walleij
2022-01-19 16:12   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.