From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB7DC61DA4 for ; Fri, 3 Feb 2023 08:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WF4g9TBSvhdmExXJpg9IauiL0yANHsiYFxm5RH4o22Q=; b=l2YO7uAXbeuRjc aX84nK/Hy5QE/aN23DOiT1jPhMUbAvViglTkGkESKVojEmePyUd8vF53Hv49EL7vvQLy/eidzBoLs VERdTfafTF3Egw4fAYxWQQSN2w4WO1xlWjYuNm61md6a9ztQkLMNXXCZFAxZ1Axa2L1SZp0YZUJjr eyd8ytKFTXoiAvzUFuLGLqSq30eR0hv6kMDfV7m0Qt4auGFse+zsaGRfTDgyUXQ2V/XRDAYfvSyNG fjLWm+1fAeu/HdWYPCtDc3QHzXJBTBslySx7tgMdvwrkvLpd+ZRtSjMYE7golGxjj8MuM4NURgcgl EEnk3GYLUiajckX84QBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrIw-000zaF-BG; Fri, 03 Feb 2023 08:20:18 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrIt-000zYF-2v for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 08:20:16 +0000 Received: by mail-wr1-x435.google.com with SMTP id j25so378239wrc.4 for ; Fri, 03 Feb 2023 00:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=45Tnhfu0pAuxepjnBLmTM16w/DDLwSO1jhjjoAKVus8=; b=OUGU+d2plzG4JQUvTzSTt/pZc/bAsHxNbwp/HWH8vk4+Gh4xG+LPYlHI9CElCcbnxB 4JDHm9QJB31ixhJ2S/EnpQRLSQiHIawt5YAt8wKciDlOxVsmFgrVMH70GBKd4MjfvUEa Sauy8zaw2OPEWV/GU41j/70NzI+Tkyhc45sFA+dm/p9w6/WmfHTmmnyFnx4zHLnPcCs2 iYMOEDqqEiIFTMYYQwHgSP9972H0KdOufjFJyEGejeWeVoaOIMOImooURU1xPI1dyZcj jrgnPWg80CPQJv5gw/ywY3J3zM+nN5lT91wuINZmtsNCA+f7DZoDqineBN9NTx3yKkw+ f/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=45Tnhfu0pAuxepjnBLmTM16w/DDLwSO1jhjjoAKVus8=; b=napcS27xzzvYTj+yIhlvJQEiQePGuaUF5HlP1zRVYm/sQZAA196Mz0Que8+u12W9iy p6k4KnvL5wXnJ5D/TWq0lDu/7zXDpszJiwGEKs5MhHBp2Fv0epMOklfl3jjiS5NGJlku wQC40HRyYO/WeUacKiTudMGSaKM7n56//h36490XgJpncTY+oIRZE2DZqdIveO+jY3zW PA6/puyBfdULdfRYYh0rdgW4dqKOR95aYfps0UUGsbRXSB49L19RjjRg9pCsxcV9eOCX uttpzHz/vz39bHIf72+3d7FwpzbMsYODhn9wDRJXa9ERC2JuufsAOoPBprzrKunlD7ij fbWA== X-Gm-Message-State: AO0yUKWoX8jVYH50TCatav5MVs9CI/r9+YJYuZca0LLwR0SksVKIFufF La9FxixHD+r3dS9w+3bw/pW7gw== X-Google-Smtp-Source: AK7set+EHfIJ8oVMvuan/LXh1dEkhymKWZxpfR3L3yw2Z1sdfrUNYRGI4me9tY8RpOo4+CdlFbpKHA== X-Received: by 2002:a05:6000:1889:b0:2bf:c5e4:1af4 with SMTP id a9-20020a056000188900b002bfc5e41af4mr10438931wri.15.1675412412036; Fri, 03 Feb 2023 00:20:12 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c12-20020a5d4ccc000000b002bddac15b3dsm1378894wrt.33.2023.02.03.00.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 00:20:11 -0800 (PST) Message-ID: <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> Date: Fri, 3 Feb 2023 09:20:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 13/13] USB: gadget: s3c2410_udc: fix memory leak with using debugfs_lookup() Content-Language: en-US To: Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: Alim Akhtar , Linus Walleij , Jakob Koschel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> <20230202153235.2412790-13-gregkh@linuxfoundation.org> From: Krzysztof Kozlowski In-Reply-To: <20230202153235.2412790-13-gregkh@linuxfoundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_002015_171795_CFD7B7C2 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/02/2023 16:32, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. To make things simpler, just > call debugfs_lookup_and_remove() instead which handles all of the logic > at once. > Hi Greg, This driver will be removed in v6.3 via Arnd's tree: https://lore.kernel.org/all/20221021203329.4143397-13-arnd@kernel.org/ I think we can skip any work on this. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27D4C636CC for ; Fri, 3 Feb 2023 08:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbjBCIWc (ORCPT ); Fri, 3 Feb 2023 03:22:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232838AbjBCIWL (ORCPT ); Fri, 3 Feb 2023 03:22:11 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC56C991CF for ; Fri, 3 Feb 2023 00:20:34 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id m14so3877470wrg.13 for ; Fri, 03 Feb 2023 00:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=45Tnhfu0pAuxepjnBLmTM16w/DDLwSO1jhjjoAKVus8=; b=OUGU+d2plzG4JQUvTzSTt/pZc/bAsHxNbwp/HWH8vk4+Gh4xG+LPYlHI9CElCcbnxB 4JDHm9QJB31ixhJ2S/EnpQRLSQiHIawt5YAt8wKciDlOxVsmFgrVMH70GBKd4MjfvUEa Sauy8zaw2OPEWV/GU41j/70NzI+Tkyhc45sFA+dm/p9w6/WmfHTmmnyFnx4zHLnPcCs2 iYMOEDqqEiIFTMYYQwHgSP9972H0KdOufjFJyEGejeWeVoaOIMOImooURU1xPI1dyZcj jrgnPWg80CPQJv5gw/ywY3J3zM+nN5lT91wuINZmtsNCA+f7DZoDqineBN9NTx3yKkw+ f/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=45Tnhfu0pAuxepjnBLmTM16w/DDLwSO1jhjjoAKVus8=; b=7FPxgofA5sQZZElMFJjNhvB1Xaqr36AG86NrkRXGdkcxq/6IprJE/Yeo0NY+5esl6A UPd3eKVEHeg5gdbH9Gpx76GFI5YK1roY6jWs5W9c/p8cvutsYHaE0UuD5qPQgHeq59h8 jG7/hPcSw26WaJHS5N57Owj1eDVYp1pJDP1aatG9Bof1h2CA49e+9nwEgCaBL2yvJATH z3ycfdRT/WpeVUwXySg6pOQR8FhZA/+BUPekPtPCsaBY8ahzEjHdyWZn/ZdnqJZG1dA1 Zg8eKS/Gu5bZD5oF287SPvJf6DiCeqOkI8YmPWPqH6Qw6L6cH1L4AotbGE/JzaUZ7dRU eEyg== X-Gm-Message-State: AO0yUKWjc91MloQv5BszGtIcJq5m3sJgU2Ph4KpjPfbxlXVXpmLR4yuZ 9xn0OPvDbbHLJ/pcuXKpGLgbhA== X-Google-Smtp-Source: AK7set+EHfIJ8oVMvuan/LXh1dEkhymKWZxpfR3L3yw2Z1sdfrUNYRGI4me9tY8RpOo4+CdlFbpKHA== X-Received: by 2002:a05:6000:1889:b0:2bf:c5e4:1af4 with SMTP id a9-20020a056000188900b002bfc5e41af4mr10438931wri.15.1675412412036; Fri, 03 Feb 2023 00:20:12 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c12-20020a5d4ccc000000b002bddac15b3dsm1378894wrt.33.2023.02.03.00.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 00:20:11 -0800 (PST) Message-ID: <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> Date: Fri, 3 Feb 2023 09:20:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 13/13] USB: gadget: s3c2410_udc: fix memory leak with using debugfs_lookup() Content-Language: en-US To: Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: Alim Akhtar , Linus Walleij , Jakob Koschel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> <20230202153235.2412790-13-gregkh@linuxfoundation.org> From: Krzysztof Kozlowski In-Reply-To: <20230202153235.2412790-13-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2023 16:32, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. To make things simpler, just > call debugfs_lookup_and_remove() instead which handles all of the logic > at once. > Hi Greg, This driver will be removed in v6.3 via Arnd's tree: https://lore.kernel.org/all/20221021203329.4143397-13-arnd@kernel.org/ I think we can skip any work on this. Best regards, Krzysztof