From: Ian Jackson <ian.jackson@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH OSSTEST 1/2] exanime: test for SMT and add a host flag
Date: Wed, 15 Apr 2020 14:04:35 +0100 [thread overview]
Message-ID: <24215.1635.613926.945930@mariner.uk.xensource.com> (raw)
In-Reply-To: <20200415085246.7945-1-roger.pau@citrix.com>
Roger Pau Monne writes ("[PATCH OSSTEST 1/2] exanime: test for SMT and add a host flag"):
> Check if hosts have SMT based on the number of threads per core. A
> value of threads per core different than 0 implies SMT support.
...
> +logm("$ho->{Ident} threads per core: $threads");
> +hostflag_putative_record($ho, "smt", !!$threads);
This code LGTM but I wonder if it would be a good idea to start
namespacing these kind of hardware feature flags. cpu-*, hardware-*,
feature-* maybe ? Would you care to make a suggestion ?
Ian.
next prev parent reply other threads:[~2020-04-15 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:52 [PATCH OSSTEST 1/2] exanime: test for SMT and add a host flag Roger Pau Monne
2020-04-15 8:52 ` [PATCH OSSTEST 2/2] make-flight: add a core scheduling job Roger Pau Monne
2020-04-15 13:06 ` Ian Jackson
2020-04-16 16:28 ` Dario Faggioli
2020-04-16 16:36 ` Roger Pau Monné
2020-04-16 16:55 ` Dario Faggioli
2020-04-16 17:10 ` Ian Jackson
2020-04-16 16:58 ` Ian Jackson
2020-04-15 10:15 ` [PATCH OSSTEST v2 1/2] exanime: test for SMT and add a host flag Roger Pau Monne
2020-04-15 13:07 ` Ian Jackson
2020-04-15 13:04 ` Ian Jackson [this message]
2020-04-15 13:47 ` [PATCH OSSTEST " Roger Pau Monné
2020-04-15 13:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24215.1635.613926.945930@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.