From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
To: Ajay Singh <ajay.kathat@microchip.com>, <linux-wireless@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
<aditya.shankar@microchip.com>, <adham.abozaeid@microchip.com>
Subject: Re: [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char
Date: Wed, 21 Mar 2018 15:55:46 +0200 [thread overview]
Message-ID: <24234901-20d9-aef4-49ed-df9d3d4a6dee@microchip.com> (raw)
In-Reply-To: <1521564944-3565-5-git-send-email-ajay.kathat@microchip.com>
Also good for me, only one minor thing mentioned below.
On 20.03.2018 18:55, Ajay Singh wrote:
> + if (subtype == GO_NEG_REQ || subtype == GO_NEG_RSP ||
> + subtype == P2P_INV_REQ || subtype == P2P_INV_RSP) {
> + for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < size; i++) {
> + if (buff[i] == P2PELEM_ATTR_ID &&
> + !(memcmp(p2p_oui, &buff[i + 2], 4))) {
You can remove "(" ")" around memcmp. Your choice.
> + wilc_wfi_cfg_parse_rx_action(&buff[i + 6],
> + size - (i + 6));
> + break;
> + }
> + }
> + }
next prev parent reply other threads:[~2018-03-21 13:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 16:55 [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly Ajay Singh
2018-03-20 16:55 ` [PATCH 01/11] staging: wilc1000: refactor scan() to free kmalloc memory on failure cases Ajay Singh
2018-03-20 19:46 ` Dan Carpenter
2018-03-21 5:05 ` Ajay Singh
2018-03-20 16:55 ` [PATCH 02/11] staging: wilc1000: removed unused global variables for gtk and ptk information Ajay Singh
2018-03-20 16:55 ` [PATCH 03/11] staging: wilc1000: remove line over 80 char warnings in set_wiphy_params() Ajay Singh
2018-03-20 16:55 ` [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char Ajay Singh
2018-03-21 7:13 ` Dan Carpenter
2018-03-21 13:55 ` Claudiu Beznea [this message]
2018-03-20 16:55 ` [PATCH 05/11] staging: wilc1000: rename WILC_WFI_p2p_rx & s32Freq to avoid camelCase Ajay Singh
2018-03-20 16:55 ` [PATCH 06/11] staging: wilc1000: refactor mgmt_tx to fix line over 80 chars Ajay Singh
2018-03-21 7:40 ` Dan Carpenter
2018-03-21 13:59 ` Claudiu Beznea
2018-03-20 16:55 ` [PATCH 07/11] staging: wilc1000: rename hAgingTimer to avoid camelCase issue Ajay Singh
2018-03-20 16:55 ` [PATCH 08/11] staging: wilc1000: fix line over 80 char issue in clear_shadow_scan() Ajay Singh
2018-03-20 16:55 ` [PATCH 09/11] staging: wilc1000: remove line over 80 char in cfg_connect_result() Ajay Singh
2018-03-21 7:49 ` Dan Carpenter
2018-03-20 16:55 ` [PATCH 10/11] staging: wilc1000: remove unused 'struct add_key_params' Ajay Singh
2018-03-20 16:55 ` [PATCH 11/11] staging: wilc1000: remove line over 80 char warning in few functions Ajay Singh
2018-03-21 7:51 ` [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly Dan Carpenter
2018-03-21 9:20 ` Ajay Singh
2018-03-21 14:04 ` Claudiu Beznea
2018-03-27 7:22 ` Ajay Singh
2018-03-27 8:55 ` Claudiu Beznea
2018-03-27 13:16 ` Ajay Singh
2018-03-28 11:31 ` Greg KH
2018-04-04 5:15 ` Ajay Singh
2018-04-23 13:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24234901-20d9-aef4-49ed-df9d3d4a6dee@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.