From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv5 10/33] eal/vfio: adding vfio utility functions in map file Date: Thu, 19 Jan 2017 18:16:22 +0100 Message-ID: <2425753.mkcfLETo4y@xps13> References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com> <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1484832240-2048-13-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com To: Hemant Agrawal Return-path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id B5DE3591E for ; Thu, 19 Jan 2017 18:16:24 +0100 (CET) Received: by mail-lf0-f52.google.com with SMTP id n124so41487680lfd.2 for ; Thu, 19 Jan 2017 09:16:24 -0800 (PST) In-Reply-To: <1484832240-2048-13-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-19 18:53, Hemant Agrawal: > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > @@ -183,5 +183,8 @@ DPDK_17.02 { > rte_bus_register; > rte_bus_scan; > rte_bus_unregister; > + vfio_get_container_fd; > + vfio_get_group_fd; > + vfio_get_group_no; Indentation looks wrong here. You cannot export some symbols without adding them a rte_ prefix.