From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EEBC433E0 for ; Mon, 18 May 2020 16:37:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55AE1207D8 for ; Mon, 18 May 2020 16:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55AE1207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jailW-0002JF-De; Mon, 18 May 2020 16:37:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jailV-0002JA-2G for xen-devel@lists.xenproject.org; Mon, 18 May 2020 16:37:21 +0000 X-Inumbo-ID: d7b9d80e-9925-11ea-9887-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d7b9d80e-9925-11ea-9887-bc764e2007e4; Mon, 18 May 2020 16:37:20 +0000 (UTC) Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: EazD7dgrhyln6e9FNS/gLcSpODu/YgR8dXgEJwxvEotcQqESdQu6TuPP9pcquSLEXhD5MuoTIk yneyBGzzmhtOB/Zd5wrVTP22UJxpPYuU5iPGS6KwtESQc0ChHYnypj52hTLFkmrOT6EF1toPFW o3V8S+d93f976m0Ys41cypvBlN0UO7iPiaj9XNtaI3+Dc6JHia1LdZK1PVWfDNWGvaT08KuKIq Dydd0lcQwbUBgu2LgqQ2zJu8AH3I9ZPm3Cgbfrp1PMh+pPA5gtKXFjZhCpB+0iAyI6Sl0sCBZN Jbg= X-SBRS: 2.7 X-MesageID: 18071372 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,407,1583211600"; d="scan'208";a="18071372" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24258.47547.105405.754194@mariner.uk.xensource.com> Date: Mon, 18 May 2020 17:37:15 +0100 To: Jason Andryuk Subject: Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages] In-Reply-To: References: <20200428040433.23504-1-jandryuk@gmail.com> <24253.29524.798802.978257@mariner.uk.xensource.com> <24258.39029.788968.419649@mariner.uk.xensource.com> <20200428040433.23504-10-jandryuk@gmail.com> <20200518145028.GD98582@mail-itl> <24258.42794.136081.367565@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore support for qemu-xen in stubdomain [and 1 more messages]"): > On Mon, May 18, 2020 at 11:18 AM Ian Jackson wrote: > > [explanation of confusion] > > Do you want the commit message to add a blurb about this? So the > message becomes: > """ > Rely on a wrapper script in stubdomain to attach relevant consoles to > qemu. The save console (1) must be attached to fdset/1. When > performing a restore, $STUBDOM_RESTORE_INCOMING_ARG must be replaced on > the qemu command line by "fd:$FD", where $FD is an open file descriptor > number to the restore console (2). > > Existing libxl code (for dom0) already connects the stubdom's save & > restore console outputs to the save & restore files. > """ I think that would be good, thanks, yes but I won't insist on it. I think I already gave my ack for v6 of this. If you add the commit message text above you should obviously keep that ack. Thanks, Ian.