From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
David Marchand <david.marchand@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated
Date: Fri, 05 Nov 2021 16:05:14 +0100 [thread overview]
Message-ID: <2425969.3b2ZdX0MHy@thomas> (raw)
In-Reply-To: <0db26ffd-1c1c-e920-0390-ee863862b071@oktetlabs.ru>
05/11/2021 14:40, Andrew Rybchenko:
> On 11/4/21 3:59 PM, Thomas Monjalon wrote:
> > 04/11/2021 12:03, Ferruh Yigit:
> >> On 11/3/2021 10:48 PM, Ferruh Yigit wrote:
> >>> Old macros kept for backward compatibility, but this cause old macro
> >>> usage to sneak in silently.
> >>>
> >>> Marking old macros as deprecated. Downside is this will cause some noise
> >>> for applications that are using old macros.
> >>>
> >>> Fixes: 295968d17407 ("ethdev: add namespace")
> >>>
> >>> Signed-off-by: Ferruh Yigit<ferruh.yigit@intel.com>
> >>> Acked-by: Stephen Hemminger<stephen@networkplumber.org>
> >>
> >> Hi Thomas, Andrew,
> >>
> >> What do you think about marking old macros as deprecated?
> >>
> >> This will cause warning in application code that is using
> >> old macros, but shouldn't fail their build (unless -Werror
> >> is issued).
> >
> > It looks to be the right thing to do.
> > I wonder whether we could wait 22.02 to apply it,
> > so users of LTS are not annoyed by it.
>
> I have no strong opinion, but tend to agree with Thomas.
> However, if an application jumps from LTS to LTS, these
> defines will be available in 21.11 without any warnings
> and simply disappear in 22.11. So, may be it is more
> friendly to deprecate in 21.11.
That's true for a lot of deprecations done in the year.
Jumping from LTS to LTS is for production.
Intermediate releases should help in the upgrade preparation process.
next prev parent reply other threads:[~2021-11-05 15:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 21:47 [dpdk-dev] [RFC] ethdev: mark old ETH_LINK macros as deprecated Stephen Hemminger
2021-11-01 12:30 ` Ferruh Yigit
2021-11-02 23:44 ` [dpdk-dev] [PATCH] ethdev: mark old " Ferruh Yigit
2021-11-03 0:05 ` Stephen Hemminger
2021-11-03 9:00 ` Ferruh Yigit
2021-11-03 22:48 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-11-04 11:03 ` Ferruh Yigit
2021-11-04 12:59 ` Thomas Monjalon
2021-11-05 13:40 ` Andrew Rybchenko
2021-11-05 15:05 ` Thomas Monjalon [this message]
2021-11-05 16:26 ` Stephen Hemminger
2021-11-05 21:33 ` Ferruh Yigit
2021-11-06 7:46 ` Thomas Monjalon
2022-01-12 14:36 ` [PATCH v3] " Ferruh Yigit
2022-01-14 6:45 ` Xia, Chenbo
2022-01-14 9:01 ` Ferruh Yigit
2021-11-04 11:04 ` [dpdk-dev] [PATCH] ethdev: fix crash on owner delete Ferruh Yigit
2021-11-05 3:03 ` [dpdk-dev] [dpdk-stable] " Xia, Chenbo
2021-11-05 13:16 ` Thomas Monjalon
2021-11-05 13:36 ` Andrew Rybchenko
2021-11-05 14:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2425969.3b2ZdX0MHy@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.