From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B63C433DF for ; Tue, 26 May 2020 17:00:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C03A20776 for ; Tue, 26 May 2020 17:00:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C03A20776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdcve-0006CA-F8; Tue, 26 May 2020 16:59:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdcvd-0006C5-Fy for xen-devel@lists.xenproject.org; Tue, 26 May 2020 16:59:49 +0000 X-Inumbo-ID: 4e717dc4-9f72-11ea-9dbe-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4e717dc4-9f72-11ea-9dbe-bc764e2007e4; Tue, 26 May 2020 16:59:48 +0000 (UTC) Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: HiL4jJvAzT0oY0O/XFxaWSH6mJVeMrECIAY7/aklf1RLqIVa/d+YREem0bBy9P4/kkVElbpzr6 bZR64mhmdDkee7+L6lVQwnqVmJ/Jjum6/5bPNtdFM0eOqWxb1EncQ9IXuF1euKtNfSqHHoh8ak 6gW+1VInzBeDqVfM+TNLATBzqApsugvwh7U/xhZkUqIGQEqgq84C4qE53rRPs9aI2hpT/aanSU pMJVjsvPKHODmO/5MOD78GQnJJ7pUjwhiszqiCh29xIFoCDLfHq7kquIfDUHV482NDHQ69LlqO mhM= X-SBRS: 2.7 X-MesageID: 18474234 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,437,1583211600"; d="scan'208";a="18474234" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-ID: <24269.19198.604986.160896@mariner.uk.xensource.com> Date: Tue, 26 May 2020 17:59:42 +0100 To: George Dunlap Subject: Re: [PATCH 5/5] gitignore: Ignore golang package directory In-Reply-To: References: <20200522161240.3748320-1-george.dunlap@citrix.com> <20200522161240.3748320-6-george.dunlap@citrix.com> <24269.8059.28506.353748@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Konrad Wilk , Andrew Cooper , Nick Rosbrook , Julien Grall , Jan Beulich , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" George Dunlap writes ("Re: [PATCH 5/5] gitignore: Ignore golang package directory"): > [explanation] Sounds quite tangled... > Nick, any opinions? ... > > Is there not a risk that humans will try to edit it ? Anyway ISTM that you have definitely considered this so Acked-by: Ian Jackson assuming that and Nick convince yourselves you've addressed this possible issue. > I suppose someone might. If we decide we want to support older versions of go, we probably want to figure something out there. Options: > > 1. Copy the files to a temp directory instead. This is complicated because we have to find a good temp directory, and we’d have to copy them every time, slowing down the incremental build (though not that much). I don't think that helps much. > 2. Put a file in the generated directory like “GENERATED_DO_NOT_EDIT”. > > 3. Put them in tools/golang/GENERATED_DO_NOT_EDIT/src instead. Do they not have a header comment saying DO NOT EDIT ? 3 is pretty ugly. I'll leave it up to you whether to bother with 2. Thanks, Ian.