All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Xen Development List <xen-devel@lists.xenproject.org>,
	"paul@xen.org" <paul@xen.org>, Wei Liu <wl@xen.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: [[PATCH v2 for-4.14]] m4: use test instead of []
Date: Tue, 2 Jun 2020 17:47:04 +0100	[thread overview]
Message-ID: <24278.33416.384684.587646@mariner.uk.xensource.com> (raw)
In-Reply-To: <20200602092447.GV1195@Air-de-Roger>

Roger Pau Monne writes ("Re: [[PATCH v2 for-4.14]] m4: use test instead of []"):
> There's a double [] enclosure in the subject
> 
> On Tue, Jun 02, 2020 at 09:01:38AM +0000, Wei Liu wrote:
> > It is reported that [] was removed by autoconf, which caused the
> > following error:
> > 
> >   ./configure: line 4681: -z: command not found
> > 
> > Switch to test. That's what is used throughout our configure scripts.
> > Also put the variable expansion in quotes.
> > 
> > Signed-off-by: Wei Liu <wl@xen.org>
> > Reported-by: Bertrand Marquis <Bertrand.Marquis@arm.com>
> > Fixes: 8a6b1665d987 ("configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS")
> > Signed-off-by: Wei Liu <wl@xen.org>
> 
> There's a double SoB ;)
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Pushed, thanks.

Ian.


      reply	other threads:[~2020-06-02 16:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  9:01 [[PATCH v2 for-4.14]] m4: use test instead of [] Wei Liu
2020-06-02  9:14 ` Paul Durrant
2020-06-02  9:59 ` Roger Pau Monné
2020-06-02 16:47   ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24278.33416.384684.587646@mariner.uk.xensource.com \
    --to=ian.jackson@citrix.com \
    --cc=Bertrand.Marquis@arm.com \
    --cc=paul@xen.org \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.