All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com,
	stable@dpdk.org, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env
Date: Tue, 10 Nov 2020 11:45:52 +0100	[thread overview]
Message-ID: <2429206.vUhvlFYDAN@thomas> (raw)
In-Reply-To: <20201110101419.GB1641@bricha3-MOBL.ger.corp.intel.com>

10/11/2020 11:14, Bruce Richardson:
> On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote:
> > PKG_CONFIG_PATH is specific to each target, so it must be empty
> > before configuring each build from the file according to DPDK_TARGET.
> > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> > and is prone to confusion.
> > 
> > DPDK_MESON_OPTIONS might take a global initial value from environment
> > to customize a build test from the shell. Example:
> > 	DPDK_MESON_OPTIONS="b_lto=true"
> > Some target-specific options can be added in the configuration file:
> > 	DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
> > 
> > Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> 
> Patch looks fine, but I think the log (and comments in the code too,
> perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the
> local config file, to make it available to the script.

OK, I'll look at improving the "doc".
We could also provide a template for the config file.



  reply	other threads:[~2020-11-10 10:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:00 [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env Thomas Monjalon
2020-11-10 10:14 ` Bruce Richardson
2020-11-10 10:45   ` Thomas Monjalon [this message]
2020-11-10 11:20     ` Bruce Richardson
2020-11-10 14:08       ` Jerin Jacob
2020-11-10 17:18 ` Ferruh Yigit
2020-11-10 17:55   ` Thomas Monjalon
2020-11-10 18:09     ` Ferruh Yigit
2020-11-11  9:18       ` Bruce Richardson
2020-11-11 10:37         ` Thomas Monjalon
2020-11-11 11:00           ` Bruce Richardson
2020-11-11 11:13             ` Ferruh Yigit
2020-11-11 11:18               ` Thomas Monjalon
2020-11-12 14:22 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2020-11-12 14:36   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2429206.vUhvlFYDAN@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.