From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Anders Darander <anders@chargestorm.se>,
Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-webserver][PATCH 1/1] webmin: drop allarch
Date: Wed, 25 Jun 2014 08:45:55 +0100 [thread overview]
Message-ID: <2430004.5QNcodJTid@peggleto-mobl5.ger.corp.intel.com> (raw)
In-Reply-To: <1b5c27f39444bed435c8c050b2fb6def74a5adb8.1403596416.git.anders@chargestorm.se>
On Tuesday 24 June 2014 09:54:12 Anders Darander wrote:
> * runtime dependencies are TUNE_PKGARCH causing do_package_write_*
> task to have different signature for MACHINEs with different
> TUNE_PKGARCH
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
> meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb
> b/meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb index
> 7eb1d63..0f8781f 100644
> --- a/meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb
> +++ b/meta-webserver/recipes-webadmin/webmin/webmin_1.620.bb
> @@ -20,7 +20,7 @@ SRC_URI =
> "${SOURCEFORGE_MIRROR}/webadmin/webmin-${PV}.tar.gz \ SRC_URI[md5sum] =
> "e93bc5057a5b7d7e31ecb2bb228d7044"
> SRC_URI[sha256sum] =
> "3d36153406d8e5d3dcaeadba34dfb5cdbc4060b75c38339174ac97b2277f284b"
>
> -inherit allarch perlnative update-rc.d
> +inherit perlnative update-rc.d
>
> do_configure() {
> # Remove binaries and plugins for other platforms
So apart from me being reticent to make this change at all (for reasons that
we've discussed before), there is another issue - allarch.bbclass does more
than just setting PACKAGE_ARCH, it also disables certain other functionality
such as debug symbol splitting which is superfluous for these kinds of recipes;
in my testing when I originally wrote the webmin recipe this significantly
reduced the time required to build the recipe. We can't just drop this inherit
without regard to that. (I'm sure the same applies elsewhere, it's just that
the size of webmin makes the impact significant.)
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2014-06-25 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 7:54 [meta-webserver][PATCH 0/1] webmin: Drop allarch Anders Darander
2014-06-24 7:54 ` [meta-webserver][PATCH 1/1] webmin: drop allarch Anders Darander
2014-06-25 7:45 ` Paul Eggleton [this message]
2014-06-25 9:28 ` Anders Darander
2014-06-25 9:45 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2430004.5QNcodJTid@peggleto-mobl5.ger.corp.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=anders@chargestorm.se \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.