From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 4/8] ethdev: Add port representor device
	flag
Date: Thu, 29 Mar 2018 09:34:27 +0200
Message-ID: <2430508.NP3kz8ElFZ@xps>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <20180328135433.20203-5-declan.doherty@intel.com>
 <DB7PR05MB44260846B4556669591ADAC3C3A20@DB7PR05MB4426.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Declan Doherty <declan.doherty@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Alex Rosenbaum <alexr@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>,
 Remy Horton <remy.horton@intel.com>, John McNamara <john.mcnamara@intel.com>,
 Rony Efraim <ronye@mellanox.com>,
 Wu <IMCEAINVALID-Wu@eurprd05.prod.outlook.com>,
 Jingjing <jingjing.wu@intel.com>,
 Lu <IMCEAINVALID-Lu@eurprd05.prod.outlook.com>, Wenzhuo <wenzhuo.lu@intel.com>,
 Vincent JArdin <vincent.jardin@6wind.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 Richardson <IMCEAINVALID-Richardson@eurprd05.prod.outlook.com>,
 Bruce <bruce.richardson@intel.com>,
 Ananyev <IMCEAINVALID-Ananyev@eurprd05.prod.outlook.com>,
 Konstantin <konstantin.ananyev@intel.
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5F1542A62
 for <dev@dpdk.org>; Thu, 29 Mar 2018 09:34:45 +0200 (CEST)
In-Reply-To: <DB7PR05MB44260846B4556669591ADAC3C3A20@DB7PR05MB4426.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/03/2018 08:13, Shahaf Shuler:
> And device attributes like : RTE_ETH_DEV_BONDED_SLAVE and RTE_ETH_DEV_REPRESENTOR.
> I don't think they belong together under the genetic name of dev_flags. 
> 
> Moreover, I am not sure the fact device is bonded slave should be exposed to the application. It should be internal to ethdev and its port iterators.

RTE_ETH_DEV_BONDED_SLAVE flag is used to prevent a manual detach of a slave.
I think it is wrong.
The bonding PMD should be able to manage any detach at any time,
because a real hardware plug-out can happen.

So I am in favor of removing RTE_ETH_DEV_BONDED_SLAVE.