From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7D6C433E6 for ; Thu, 21 Jan 2021 20:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3CA023A58 for ; Thu, 21 Jan 2021 20:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbhAUUBq convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2021 15:01:46 -0500 Received: from mailoutvs41.siol.net ([185.57.226.232]:52768 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726848AbhAUTzB (ORCPT ); Thu, 21 Jan 2021 14:55:01 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id A146F520BDA; Thu, 21 Jan 2021 20:54:09 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id B90abY8oWMUe; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 5D80B5235B6; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id EC71B520BDA; Thu, 21 Jan 2021 20:54:07 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-arm-kernel@lists.infradead.org, Hermann Lauer Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Date: Thu, 21 Jan 2021 20:54:07 +0100 Message-ID: <2438641.b0YrFlWa0f@kista> In-Reply-To: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a): > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > packet loss rates. The realtek phy driver overrides the settings of the > pull ups for the delays, so fix this for Banana Pro. > > Signed-off-by: Hermann Lauer Much better. Now the only thing missing is "Fixes" tag, which references commit which introduced the issue. Probably this will be the commit which added ethernet node. This tag is important for deciding which commits should be backported to stable releases. Take a look in v1 for M2U fixes tag. Btw, each version should have changelog under "---" line, so maintainers and reviewers know what changed. Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D8FEC433E0 for ; Thu, 21 Jan 2021 19:55:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2AD523A58 for ; Thu, 21 Jan 2021 19:55:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2AD523A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jIQajBEs1MstO6yY3d96sV1KJBJvmfFQ+irz0OOjmEU=; b=2njzfL62995sWnfUFOJ0etbTz FMIFcqxzTpkQJevqB2DRAvKDICWTqEzUwyxy5gsP2zsjS76yfEN0l5SkvSsLEykW09CQ0bbrRJDlW YoQPpIxgw3dP0PKeXT1IOMOtlOnvBtiQfpUu0oQ5OpEswMOfnOOf5JFoM+qSjVsum58gpI+1s7fc+ CPtgMDfiE1rJq2aAWZGlUlDS/HX5aaNr3dxvJsVdIC477qQfEB2NJz1IgXqrnj5y1iNoX2aHimPkd shHlLd5phsva4qwnUZ4l/AfboIEsxUVqJoEUtJz7OhH6gLxwDqLmf9AvROtFeYgk01/JORSKcsxsr p+BRpSrfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2g24-0001Xj-0h; Thu, 21 Jan 2021 19:54:16 +0000 Received: from mailoutvs19.siol.net ([185.57.226.210] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2g21-0001XN-29 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 19:54:14 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id A146F520BDA; Thu, 21 Jan 2021 20:54:09 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id B90abY8oWMUe; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 5D80B5235B6; Thu, 21 Jan 2021 20:54:09 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id EC71B520BDA; Thu, 21 Jan 2021 20:54:07 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-arm-kernel@lists.infradead.org, Hermann Lauer Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Date: Thu, 21 Jan 2021 20:54:07 +0100 Message-ID: <2438641.b0YrFlWa0f@kista> In-Reply-To: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_145413_469976_514D71A1 X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, mripard@kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAyMS4gamFudWFyIDIwMjEgb2IgMTg6MDg6MzYgQ0VUIGplIEhlcm1hbm4g TGF1ZXIgbmFwaXNhbChhKToKPiBCUGkgUHJvIG5lZWRzIFRYIGFuZCBSWCBkZWxheSBmb3IgR2Jp dCB0byB3b3JrIHJlbGlhYmxlIGFuZCBhdm9pZCBoaWdoCj4gcGFja2V0IGxvc3MgcmF0ZXMuIFRo ZSByZWFsdGVrIHBoeSBkcml2ZXIgb3ZlcnJpZGVzIHRoZSBzZXR0aW5ncyBvZiB0aGUKPiBwdWxs IHVwcyBmb3IgdGhlIGRlbGF5cywgc28gZml4IHRoaXMgZm9yIEJhbmFuYSBQcm8uCj4gCj4gU2ln bmVkLW9mZi1ieTogSGVybWFubiBMYXVlciA8SGVybWFubi5MYXVlckB1bmktaGVpZGVsYmVyZy5k ZT4KCk11Y2ggYmV0dGVyLiBOb3cgdGhlIG9ubHkgdGhpbmcgbWlzc2luZyBpcyAiRml4ZXMiIHRh Zywgd2hpY2ggcmVmZXJlbmNlcyAKY29tbWl0IHdoaWNoIGludHJvZHVjZWQgdGhlIGlzc3VlLiBQ cm9iYWJseSB0aGlzIHdpbGwgYmUgdGhlIGNvbW1pdCB3aGljaCAKYWRkZWQgZXRoZXJuZXQgbm9k ZS4gVGhpcyB0YWcgaXMgaW1wb3J0YW50IGZvciBkZWNpZGluZyB3aGljaCBjb21taXRzIHNob3Vs ZCAKYmUgYmFja3BvcnRlZCB0byBzdGFibGUgcmVsZWFzZXMuIFRha2UgYSBsb29rIGluIHYxIGZv ciBNMlUgZml4ZXMgdGFnLgoKQnR3LCBlYWNoIHZlcnNpb24gc2hvdWxkIGhhdmUgY2hhbmdlbG9n IHVuZGVyICItLS0iIGxpbmUsIHNvIG1haW50YWluZXJzIGFuZCAKcmV2aWV3ZXJzIGtub3cgd2hh dCBjaGFuZ2VkLgoKQmVzdCByZWdhcmRzLApKZXJuZWoKCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=