From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073B3C433EF for ; Thu, 7 Jul 2022 10:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235155AbiGGK7z (ORCPT ); Thu, 7 Jul 2022 06:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbiGGK7v (ORCPT ); Thu, 7 Jul 2022 06:59:51 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDDEC57224; Thu, 7 Jul 2022 03:59:50 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0319466019AF; Thu, 7 Jul 2022 11:59:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657191588; bh=Ncasodb0mlhKue8G5um/dzJDJSNHJ442SPjDYU2q3GI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G3Wb0DHsH05SDtLOudN/tZyJYo7/p+kDkzNgTgA/qmXdIPemFSZ5Gp8mg7sHTnbo8 EPxxgeujFcYAVjQWRmi3qfj0zHSvYLfSCJC7H6tEaliGTh6w4anzitaB/H/gJ5bKg8 y6mxUghQ6cvnE7Zbp3n7ePsPsO2hydtEIAZvXjCZTbehGd3YfouYSxL2CMjMF8WUsR sVeeDqcJCbu71+gQBISChVWgpY4jm8gwFQ158lXk2y0LfWpX3u9/isgH09jXZ5KUkd LNYC/F0a9UMtAqWxw34Bh3k+NGCc4o611IAAe3qUf2hkIaZgOGItUzdibxR5gvgoB4 joD5hcJd9qoBg== Message-ID: <243b30ca-a552-3cb7-8a4e-6e54a56ff60a@collabora.com> Date: Thu, 7 Jul 2022 12:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Content-Language: en-US To: Matthias Brugger , Allen-KH Cheng , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Xiandong Wang References: <20220705122627.2273-1-allen-kh.cheng@mediatek.com> <20220705122627.2273-2-allen-kh.cheng@mediatek.com> <5916c91b-41a1-c97a-84b4-7d48739a0639@collabora.com> <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 07/07/22 12:41, Matthias Brugger ha scritto: > > > On 07/07/2022 10:52, AngeloGioacchino Del Regno wrote: >> Il 05/07/22 14:26, Allen-KH Cheng ha scritto: >>> Add mdp3 mutex compatible for mt8186 SoC. >>> >>> Signed-off-by: Allen-KH Cheng >>> Signed-off-by: Xiandong Wang >> >> >> Please drop this commit. Adding a mdp3-mutex compatible is not needed here. >> > > Thanks for checking. We probably would need a fallback compatible. We can only know > from the HW engineers that can confirm if the IP block is the same as the disp > mutex or a different one. > > I'll drop both patches for now until things got clear. > They're located in a different iospace from each other, but either the platform data needs to *not be* joined together, or if they're together, I would not like having two different compatible strings for essentially the same thing. I would at this point prefer dropping '-disp' from 'mediatek,mt8186-disp-mutex' so that we would be able to declare two 'mediatek,mt8186-mutex' in devicetree... ...or simply have two mediatek,mt8186-disp-mutex (although logically incorrect?). Cheers, Angelo > Regards, > Matthias > >>> --- >>>   .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml         | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> index 627dcc3e8b32..234fa5dc07c2 100644 >>> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml >>> @@ -30,6 +30,7 @@ properties: >>>         - mediatek,mt8173-disp-mutex >>>         - mediatek,mt8183-disp-mutex >>>         - mediatek,mt8186-disp-mutex >>> +      - mediatek,mt8186-mdp3-mutex >>>         - mediatek,mt8192-disp-mutex >>>         - mediatek,mt8195-disp-mutex >> >> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45A86C433EF for ; Thu, 7 Jul 2022 11:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tW4sJl4iv9HLADIqZsuiv3yFcGYmQ2Y96EHJb0dBpI4=; b=zrvIcWt8UKTQJu 2FMsFQFsSM+nZ7f0ddTmOdCQQzQMCw7CEu9Deu9rIqzFxVeIag/u1G0rf8TL9NkZxN4YwMTBWrr9F TG3kUHs50KTqFg2kHmmVYYFNJtHKpPSJ09Xe7tF/ySXUzus8Tiilc2YsNNMllZE18r9QwzaxJfnLt /t7RLjNzZtHVS5mFcRbMzRZycCrWaqd3YuXui8VHgAV5hhHXGw73VnP1HT5uDXEXYlfBq1vN6fDTG J8qwKxA6FdkwaKIOMAmupRzPOriZ2XIQd/8ruQaEfMbJU3XYrajYMwJRJoq2lG+Pnf1+Vp7IAH4RQ aQ1W1PnEZlHdD3JJuoNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9PEi-00FiGE-Q8; Thu, 07 Jul 2022 10:59:57 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9PEe-00FiDl-HS; Thu, 07 Jul 2022 10:59:54 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0319466019AF; Thu, 7 Jul 2022 11:59:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657191588; bh=Ncasodb0mlhKue8G5um/dzJDJSNHJ442SPjDYU2q3GI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G3Wb0DHsH05SDtLOudN/tZyJYo7/p+kDkzNgTgA/qmXdIPemFSZ5Gp8mg7sHTnbo8 EPxxgeujFcYAVjQWRmi3qfj0zHSvYLfSCJC7H6tEaliGTh6w4anzitaB/H/gJ5bKg8 y6mxUghQ6cvnE7Zbp3n7ePsPsO2hydtEIAZvXjCZTbehGd3YfouYSxL2CMjMF8WUsR sVeeDqcJCbu71+gQBISChVWgpY4jm8gwFQ158lXk2y0LfWpX3u9/isgH09jXZ5KUkd LNYC/F0a9UMtAqWxw34Bh3k+NGCc4o611IAAe3qUf2hkIaZgOGItUzdibxR5gvgoB4 joD5hcJd9qoBg== Message-ID: <243b30ca-a552-3cb7-8a4e-6e54a56ff60a@collabora.com> Date: Thu, 7 Jul 2022 12:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: soc: mediatek: add mdp3 mutex support for mt8186 Content-Language: en-US To: Matthias Brugger , Allen-KH Cheng , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Xiandong Wang References: <20220705122627.2273-1-allen-kh.cheng@mediatek.com> <20220705122627.2273-2-allen-kh.cheng@mediatek.com> <5916c91b-41a1-c97a-84b4-7d48739a0639@collabora.com> <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> From: AngeloGioacchino Del Regno In-Reply-To: <640c1a9b-f8b5-aa89-19af-7d6f5c55eb12@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220707_035952_843228_F065A339 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMDcvMDcvMjIgMTI6NDEsIE1hdHRoaWFzIEJydWdnZXIgaGEgc2NyaXR0bzoKPiAKPiAKPiBP biAwNy8wNy8yMDIyIDEwOjUyLCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToKPj4g SWwgMDUvMDcvMjIgMTQ6MjYsIEFsbGVuLUtIIENoZW5nIGhhIHNjcml0dG86Cj4+PiBBZGQgbWRw MyBtdXRleCBjb21wYXRpYmxlIGZvciBtdDgxODYgU29DLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6 IEFsbGVuLUtIIENoZW5nIDxhbGxlbi1raC5jaGVuZ0BtZWRpYXRlay5jb20+Cj4+PiBTaWduZWQt b2ZmLWJ5OiBYaWFuZG9uZyBXYW5nIDx4aWFuZG9uZy53YW5nQG1lZGlhdGVrLmNvbT4KPj4KPj4K Pj4gUGxlYXNlIGRyb3AgdGhpcyBjb21taXQuIEFkZGluZyBhIG1kcDMtbXV0ZXggY29tcGF0aWJs ZSBpcyBub3QgbmVlZGVkIGhlcmUuCj4+Cj4gCj4gVGhhbmtzIGZvciBjaGVja2luZy4gV2UgcHJv YmFibHkgd291bGQgbmVlZCBhIGZhbGxiYWNrIGNvbXBhdGlibGUuIFdlIGNhbiBvbmx5IGtub3cg Cj4gZnJvbSB0aGUgSFcgZW5naW5lZXJzIHRoYXQgY2FuIGNvbmZpcm0gaWYgdGhlIElQIGJsb2Nr IGlzIHRoZSBzYW1lIGFzIHRoZSBkaXNwIAo+IG11dGV4IG9yIGEgZGlmZmVyZW50IG9uZS4KPiAK PiBJJ2xsIGRyb3AgYm90aCBwYXRjaGVzIGZvciBub3cgdW50aWwgdGhpbmdzIGdvdCBjbGVhci4K PiAKClRoZXkncmUgbG9jYXRlZCBpbiBhIGRpZmZlcmVudCBpb3NwYWNlIGZyb20gZWFjaCBvdGhl ciwgYnV0IGVpdGhlciB0aGUgcGxhdGZvcm0KZGF0YSBuZWVkcyB0byAqbm90IGJlKiBqb2luZWQg dG9nZXRoZXIsIG9yIGlmIHRoZXkncmUgdG9nZXRoZXIsIEkgd291bGQgbm90IGxpa2UKaGF2aW5n IHR3byBkaWZmZXJlbnQgY29tcGF0aWJsZSBzdHJpbmdzIGZvciBlc3NlbnRpYWxseSB0aGUgc2Ft ZSB0aGluZy4KCkkgd291bGQgYXQgdGhpcyBwb2ludCBwcmVmZXIgZHJvcHBpbmcgJy1kaXNwJyBm cm9tICdtZWRpYXRlayxtdDgxODYtZGlzcC1tdXRleCcKc28gdGhhdCB3ZSB3b3VsZCBiZSBhYmxl IHRvIGRlY2xhcmUgdHdvICdtZWRpYXRlayxtdDgxODYtbXV0ZXgnIGluIGRldmljZXRyZWUuLi4K Li4ub3Igc2ltcGx5IGhhdmUgdHdvIG1lZGlhdGVrLG10ODE4Ni1kaXNwLW11dGV4IChhbHRob3Vn aCBsb2dpY2FsbHkgaW5jb3JyZWN0PykuCgpDaGVlcnMsCkFuZ2VsbwoKPiBSZWdhcmRzLAo+IE1h dHRoaWFzCj4gCj4+PiAtLS0KPj4+IMKgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9tZWRp YXRlay9tZWRpYXRlayxtdXRleC55YW1swqDCoMKgwqDCoMKgwqDCoCB8IDEgKwo+Pj4gwqAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvbWVkaWF0ZWsvbWVkaWF0ZWssbXV0ZXgueWFt bCAKPj4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9tZWRpYXRlay9t ZWRpYXRlayxtdXRleC55YW1sCj4+PiBpbmRleCA2MjdkY2MzZThiMzIuLjIzNGZhNWRjMDdjMiAx MDA2NDQKPj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvbWVk aWF0ZWsvbWVkaWF0ZWssbXV0ZXgueWFtbAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3NvYy9tZWRpYXRlay9tZWRpYXRlayxtdXRleC55YW1sCj4+PiBAQCAtMzAs NiArMzAsNyBAQCBwcm9wZXJ0aWVzOgo+Pj4gwqDCoMKgwqDCoMKgwqAgLSBtZWRpYXRlayxtdDgx NzMtZGlzcC1tdXRleAo+Pj4gwqDCoMKgwqDCoMKgwqAgLSBtZWRpYXRlayxtdDgxODMtZGlzcC1t dXRleAo+Pj4gwqDCoMKgwqDCoMKgwqAgLSBtZWRpYXRlayxtdDgxODYtZGlzcC1tdXRleAo+Pj4g K8KgwqDCoMKgwqAgLSBtZWRpYXRlayxtdDgxODYtbWRwMy1tdXRleAo+Pj4gwqDCoMKgwqDCoMKg wqAgLSBtZWRpYXRlayxtdDgxOTItZGlzcC1tdXRleAo+Pj4gwqDCoMKgwqDCoMKgwqAgLSBtZWRp YXRlayxtdDgxOTUtZGlzcC1tdXRleAo+Pgo+Pgo+PgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK