All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend Van Spriel <aspriel@gmail.com>
To: Ian Lin <ian.lin@infineon.com>, linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
	franky.lin@broadcom.com, hante.meuleman@broadcom.com,
	kvalo@kernel.org, Double.Lo@infineon.com
Subject: Re: [PATCH 1/3] brcmfmac: add a timer to read console periodically in PCIE bus
Date: Mon, 10 Oct 2022 11:53:07 +0200	[thread overview]
Message-ID: <243c9212-0bd0-fa08-056e-efbf6fbcb842@gmail.com> (raw)
In-Reply-To: <20220929031001.9962-2-ian.lin@infineon.com>

On 9/29/2022 5:09 AM, Ian Lin wrote:
> From: Wright Feng <wright.feng@cypress.com>
> 
> Currently, host only reads console buffer when receiving mailbox data or
> hit crash with PCIE bus. Therefore, we add timer in PCIE code to read
> console buffer periodically to help developer and user check firmware
> message when there is no data transmission between host and dongle.

These patches are already applied, but wanted to respond still. I know 
the proprietary driver does use a timer, but it was a design decision to 
drop that. It adds overhead and complexity which is not resulting in 
more information about the firmware. Maybe I am missing the exact 
scenarios in which this would be useful. Also description above says it 
would help the user, but I very much doubt that. Not much users are 
fiddling with debugfs and if they are we can call them developers ;-)

Regards,
Arend

  parent reply	other threads:[~2022-10-10  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  3:09 [PATCH 0/3] brcmfmac: PCIE debug mechanism series Ian Lin
2022-09-29  3:09 ` [PATCH 1/3] brcmfmac: add a timer to read console periodically in PCIE bus Ian Lin
2022-10-04  7:07   ` Kalle Valo
2022-10-04  8:28   ` Kalle Valo
2022-10-10  9:53   ` Arend Van Spriel [this message]
2022-09-29  3:10 ` [PATCH 2/3] brcmfmac: return error when getting invalid max_flowrings from dongle Ian Lin
2022-10-10  9:58   ` Arend Van Spriel
2023-01-08 20:53   ` chainofflowers
2023-01-09  8:52     ` Arend van Spriel
2023-01-09 17:23       ` chainofflowers
2022-09-29  3:10 ` [PATCH 3/3] brcmfmac: dump dongle memory when attaching failed Ian Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=243c9212-0bd0-fa08-056e-efbf6fbcb842@gmail.com \
    --to=aspriel@gmail.com \
    --cc=Double.Lo@infineon.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=ian.lin@infineon.com \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.