From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbeDFPkT (ORCPT ); Fri, 6 Apr 2018 11:40:19 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:35356 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbeDFPkR (ORCPT ); Fri, 6 Apr 2018 11:40:17 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Jacopo Mondi , architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, vladimir_zapolskiy@mentor.com, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 06 Apr 2018 18:40:14 +0300 Message-ID: <2441543.5xTHaLXzZ0@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180406142558.GP20945@w540> References: <1523018517-24121-1-git-send-email-jacopo+renesas@jmondi.org> <1664336.M7KDjLhzuK@avalon> <20180406142558.GP20945@w540> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w36FeQjD023226 Hi Jacopo, (CC'ing Mark Brown) On Friday, 6 April 2018 17:25:58 EEST jacopo mondi wrote: > On Fri, Apr 06, 2018 at 04:15:35PM +0300, Laurent Pinchart wrote: > > On Friday, 6 April 2018 15:41:56 EEST Jacopo Mondi wrote: > >> Document Thine THC63LVD1024 LVDS decoder device tree bindings. > >> > >> Signed-off-by: Jacopo Mondi > >> Reviewed-by: Andrzej Hajda > >> Reviewed-by: Niklas Söderlund > >> Reviewed-by: Laurent Pinchart > >> --- > >> > >> .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 > >> +++++++++++++++++++ > >> 1 file changed, 60 insertions(+) > >> create mode 100644 > >> > >> Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.tx > >> t > >> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.tx > >> t > >> new file mode 100644 > >> index 0000000..1191f17 > >> --- /dev/null > >> +++ > >> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.tx > >> t > >> @@ -0,0 +1,60 @@ > >> +Thine Electronics THC63LVD1024 LVDS decoder > >> +------------------------------------------- > >> + > >> +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS > >> streams > >> +to parallel data outputs. The chip supports single/dual input/output > >> modes, > >> +handling up to two two input LVDS stream and up to two digital CMOS/TTL > > > > s/to two two/to two/ > > s/stream/streams/ > > > >> outputs. > >> + > >> +Single or dual operation modes, output data mapping and DDR output > >> modes are > >> +configured through input signals and the chip does not expose any > >> control bus. > >> + > >> +Required properties: > >> +- compatible: Shall be "thine,thc63lvd1024" > >> + > >> +Optional properties: > >> +- vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS > >> input, > >> + PPL and digital circuitry > >> +- powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > >> +- enable-gpios: Output enable GPIO signal, pin name "OE". Active high > > > > As Rob mentioned in a reply to v6, we currently use "enable" as the > > inverse of "powerdown". I would call this one oe-gpios instead. Quoting > > Rob: > > > > "Debating "oe" vs. "output-enable" is bikeshedding IMO. Anyone familiar > > with h/w design should recognize OE." > > I got a different understanding of what Rob meant. I thought "anyone > familiar with h/w design should recognize OE" as that nobody would get > confused if a pin named OE in the chip manual is descibed by an > 'enable' property. > > But as discussed offline, enable has probably to be used as the > opposite of powerdown for complete chip sleep, not just for output > pad. > > Anyway, we spent enough time on naming issues, starting from my first > stupid 'pdwn' permutations then on this semi-standard names. > > I'll send next version with 'powerdown-gpios' and 'oe-gpios' > properties hoping that would be finally accepted by everyone. I certainly won't complain (as long as you write pwdn instead of pdwn in the driver :-)). > Same on the mandatory/optional VCC supply thing. Let's try to make > next version the final one. If the optional property with the dummy > regulator doesn't satisfy you and it is preferred to have a fixed-regulator > anyhow in DT I'll do in next version, othewise let's try not to change > it again. I'll just remark here that in the current Eagle design vcc is > connected to a power rail with no regulator at all :) I don't like the dummy regulator much, as it generates a dev_warn(), which makes me believe that it's a hack rather than a proper solution. You might want to ask Mark Brown for his opinion. > >> + > >> +The THC63LVD1024 video port connections are modeled according > >> +to OF graph bindings specified by Documentation/devicetree/bindings/ > >> graph.txt > >> + > >> +Required video port nodes: > >> +- port@0: First LVDS input port > >> +- port@2: First digital CMOS/TTL parallel output > >> + > >> +Optional video port nodes: > >> +- port@1: Second LVDS input port > >> +- port@3: Second digital CMOS/TTL parallel output > >> + > >> +Example: > >> +-------- > >> + > >> + thc63lvd1024: lvds-decoder { > >> + compatible = "thine,thc63lvd1024"; > >> + > >> + vcc-supply = <®_lvds_vcc>; > >> + powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > >> + > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + port@0 { > >> + reg = <0>; > >> + > >> + lvds_dec_in_0: endpoint { > >> + remote-endpoint = <&lvds_out>; > >> + }; > >> + }; > >> + > >> + port@2{ > >> + reg = <2>; > >> + > >> + lvds_dec_out_2: endpoint { > >> + remote-endpoint = <&adv7511_in>; > >> + }; > >> + }; > >> + }; > >> + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v7 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Date: Fri, 06 Apr 2018 18:40:14 +0300 Message-ID: <2441543.5xTHaLXzZ0@avalon> References: <1523018517-24121-1-git-send-email-jacopo+renesas@jmondi.org> <1664336.M7KDjLhzuK@avalon> <20180406142558.GP20945@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180406142558.GP20945@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, airlied@linux.ie, Mark Brown , magnus.damm@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, Jacopo Mondi , dri-devel@lists.freedesktop.org, niklas.soderlund@ragnatech.se, geert@linux-m68k.org, vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKKENDJ2luZyBNYXJrIEJyb3duKQoKT24gRnJpZGF5LCA2IEFwcmlsIDIwMTgg MTc6MjU6NTggRUVTVCBqYWNvcG8gbW9uZGkgd3JvdGU6Cj4gT24gRnJpLCBBcHIgMDYsIDIwMTgg YXQgMDQ6MTU6MzVQTSArMDMwMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IE9uIEZyaWRh eSwgNiBBcHJpbCAyMDE4IDE1OjQxOjU2IEVFU1QgSmFjb3BvIE1vbmRpIHdyb3RlOgo+ID4+IERv Y3VtZW50IFRoaW5lIFRIQzYzTFZEMTAyNCBMVkRTIGRlY29kZXIgZGV2aWNlIHRyZWUgYmluZGlu Z3MuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTogSmFjb3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNh c0BqbW9uZGkub3JnPgo+ID4+IFJldmlld2VkLWJ5OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNh bXN1bmcuY29tPgo+ID4+IFJldmlld2VkLWJ5OiBOaWtsYXMgU8O2ZGVybHVuZCA8bmlrbGFzLnNv ZGVybHVuZCtyZW5lc2FzQHJhZ25hdGVjaC5zZT4KPiA+PiBSZXZpZXdlZC1ieTogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4+IC0tLQo+ID4+ IAo+ID4+ICAuLi4vYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhjNjNsdmQxMDI0LnR4 dCB8IDYwCj4gPj4gICsrKysrKysrKysrKysrKysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDYw IGluc2VydGlvbnMoKykKPiA+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0Cj4gPj4gCj4gPj4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3RoaW5lLHRoYzYzbHZk MTAyNC50eHQKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0Cj4gPj4gYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhjNjNsdmQxMDI0LnR4Cj4gPj4g dAo+ID4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdl L3RoaW5lLHRoYzYzbHZkMTAyNC50eAo+ID4+IHQKPiA+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ ID4+IGluZGV4IDAwMDAwMDAuLjExOTFmMTcKPiA+PiAtLS0gL2Rldi9udWxsCj4gPj4gKysrCj4g Pj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGhp bmUsdGhjNjNsdmQxMDI0LnR4Cj4gPj4gdAo+ID4+IEBAIC0wLDAgKzEsNjAgQEAKPiA+PiArVGhp bmUgRWxlY3Ryb25pY3MgVEhDNjNMVkQxMDI0IExWRFMgZGVjb2Rlcgo+ID4+ICstLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gKwo+ID4+ICtUaGUgVEhDNjNM VkQxMDI0IGlzIGEgZHVhbCBsaW5rIExWRFMgcmVjZWl2ZXIgZGVzaWduZWQgdG8gY29udmVydCBM VkRTCj4gPj4gc3RyZWFtcwo+ID4+ICt0byBwYXJhbGxlbCBkYXRhIG91dHB1dHMuIFRoZSBjaGlw IHN1cHBvcnRzIHNpbmdsZS9kdWFsIGlucHV0L291dHB1dAo+ID4+IG1vZGVzLAo+ID4+ICtoYW5k bGluZyB1cCB0byB0d28gdHdvIGlucHV0IExWRFMgc3RyZWFtIGFuZCB1cCB0byB0d28gZGlnaXRh bCBDTU9TL1RUTAo+ID4gCj4gPiBzL3RvIHR3byB0d28vdG8gdHdvLwo+ID4gcy9zdHJlYW0vc3Ry ZWFtcy8KPiA+IAo+ID4+IG91dHB1dHMuCj4gPj4gKwo+ID4+ICtTaW5nbGUgb3IgZHVhbCBvcGVy YXRpb24gbW9kZXMsIG91dHB1dCBkYXRhIG1hcHBpbmcgYW5kIEREUiBvdXRwdXQKPiA+PiBtb2Rl cyBhcmUKPiA+PiArY29uZmlndXJlZCB0aHJvdWdoIGlucHV0IHNpZ25hbHMgYW5kIHRoZSBjaGlw IGRvZXMgbm90IGV4cG9zZSBhbnkKPiA+PiBjb250cm9sIGJ1cy4KPiA+PiArCj4gPj4gK1JlcXVp cmVkIHByb3BlcnRpZXM6Cj4gPj4gKy0gY29tcGF0aWJsZTogU2hhbGwgYmUgInRoaW5lLHRoYzYz bHZkMTAyNCIKPiA+PiArCj4gPj4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPj4gKy0gdmNjLXN1 cHBseTogUG93ZXIgc3VwcGx5IGZvciBUVEwgb3V0cHV0LCBUVEwgQ0xPQ0tPVVQgc2lnbmFsLCBM VkRTCj4gPj4gaW5wdXQsCj4gPj4gKyAgUFBMIGFuZCBkaWdpdGFsIGNpcmN1aXRyeQo+ID4+ICst IHBvd2VyZG93bi1ncGlvczogUG93ZXIgZG93biBHUElPIHNpZ25hbCwgcGluIG5hbWUgIi9QRFdO Ii4gQWN0aXZlIGxvdwo+ID4+ICstIGVuYWJsZS1ncGlvczogT3V0cHV0IGVuYWJsZSBHUElPIHNp Z25hbCwgcGluIG5hbWUgIk9FIi4gQWN0aXZlIGhpZ2gKPiA+IAo+ID4gQXMgUm9iIG1lbnRpb25l ZCBpbiBhIHJlcGx5IHRvIHY2LCB3ZSBjdXJyZW50bHkgdXNlICJlbmFibGUiIGFzIHRoZQo+ID4g aW52ZXJzZSBvZiAicG93ZXJkb3duIi4gSSB3b3VsZCBjYWxsIHRoaXMgb25lIG9lLWdwaW9zIGlu c3RlYWQuIFF1b3RpbmcKPiA+IFJvYjoKPiA+IAo+ID4gIkRlYmF0aW5nICJvZSIgdnMuICJvdXRw dXQtZW5hYmxlIiBpcyBiaWtlc2hlZGRpbmcgSU1PLiBBbnlvbmUgZmFtaWxpYXIKPiA+IHdpdGgg aC93IGRlc2lnbiBzaG91bGQgcmVjb2duaXplIE9FLiIKPiAKPiBJIGdvdCBhIGRpZmZlcmVudCB1 bmRlcnN0YW5kaW5nIG9mIHdoYXQgUm9iIG1lYW50LiBJIHRob3VnaHQgImFueW9uZQo+IGZhbWls aWFyIHdpdGggaC93IGRlc2lnbiBzaG91bGQgcmVjb2duaXplIE9FIiBhcyB0aGF0IG5vYm9keSB3 b3VsZCBnZXQKPiBjb25mdXNlZCBpZiBhIHBpbiBuYW1lZCBPRSBpbiB0aGUgY2hpcCBtYW51YWwg aXMgZGVzY2liZWQgYnkgYW4KPiAnZW5hYmxlJyBwcm9wZXJ0eS4KPiAKPiBCdXQgYXMgZGlzY3Vz c2VkIG9mZmxpbmUsIGVuYWJsZSBoYXMgcHJvYmFibHkgdG8gYmUgdXNlZCBhcyB0aGUKPiBvcHBv c2l0ZSBvZiBwb3dlcmRvd24gZm9yIGNvbXBsZXRlIGNoaXAgc2xlZXAsIG5vdCBqdXN0IGZvciBv dXRwdXQKPiBwYWQuCj4gCj4gQW55d2F5LCB3ZSBzcGVudCBlbm91Z2ggdGltZSBvbiBuYW1pbmcg aXNzdWVzLCBzdGFydGluZyBmcm9tIG15IGZpcnN0Cj4gc3R1cGlkICdwZHduJyBwZXJtdXRhdGlv bnMgdGhlbiBvbiB0aGlzIHNlbWktc3RhbmRhcmQgbmFtZXMuCj4gCj4gSSdsbCBzZW5kIG5leHQg dmVyc2lvbiB3aXRoICdwb3dlcmRvd24tZ3Bpb3MnIGFuZCAnb2UtZ3Bpb3MnCj4gcHJvcGVydGll cyBob3BpbmcgdGhhdCB3b3VsZCBiZSBmaW5hbGx5IGFjY2VwdGVkIGJ5IGV2ZXJ5b25lLgoKSSBj ZXJ0YWlubHkgd29uJ3QgY29tcGxhaW4gKGFzIGxvbmcgYXMgeW91IHdyaXRlIHB3ZG4gaW5zdGVh ZCBvZiBwZHduIGluIHRoZSAKZHJpdmVyIDotKSkuCgo+IFNhbWUgb24gdGhlIG1hbmRhdG9yeS9v cHRpb25hbCBWQ0Mgc3VwcGx5IHRoaW5nLiBMZXQncyB0cnkgdG8gbWFrZQo+IG5leHQgdmVyc2lv biB0aGUgZmluYWwgb25lLiBJZiB0aGUgb3B0aW9uYWwgcHJvcGVydHkgd2l0aCB0aGUgZHVtbXkK PiByZWd1bGF0b3IgZG9lc24ndCBzYXRpc2Z5IHlvdSBhbmQgaXQgaXMgcHJlZmVycmVkIHRvIGhh dmUgYSBmaXhlZC1yZWd1bGF0b3IKPiBhbnlob3cgaW4gRFQgSSdsbCBkbyBpbiBuZXh0IHZlcnNp b24sIG90aGV3aXNlIGxldCdzIHRyeSBub3QgdG8gY2hhbmdlCj4gaXQgYWdhaW4uIEknbGwganVz dCByZW1hcmsgaGVyZSB0aGF0IGluIHRoZSBjdXJyZW50IEVhZ2xlIGRlc2lnbiB2Y2MgaXMKPiBj b25uZWN0ZWQgdG8gYSBwb3dlciByYWlsIHdpdGggbm8gcmVndWxhdG9yIGF0IGFsbCA6KQoKSSBk b24ndCBsaWtlIHRoZSBkdW1teSByZWd1bGF0b3IgbXVjaCwgYXMgaXQgZ2VuZXJhdGVzIGEgZGV2 X3dhcm4oKSwgd2hpY2ggCm1ha2VzIG1lIGJlbGlldmUgdGhhdCBpdCdzIGEgaGFjayByYXRoZXIg dGhhbiBhIHByb3BlciBzb2x1dGlvbi4gWW91IG1pZ2h0IAp3YW50IHRvIGFzayBNYXJrIEJyb3du IGZvciBoaXMgb3Bpbmlvbi4KCj4gPj4gKwo+ID4+ICtUaGUgVEhDNjNMVkQxMDI0IHZpZGVvIHBv cnQgY29ubmVjdGlvbnMgYXJlIG1vZGVsZWQgYWNjb3JkaW5nCj4gPj4gK3RvIE9GIGdyYXBoIGJp bmRpbmdzIHNwZWNpZmllZCBieSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvCj4g Pj4gZ3JhcGgudHh0Cj4gPj4gKwo+ID4+ICtSZXF1aXJlZCB2aWRlbyBwb3J0IG5vZGVzOgo+ID4+ ICstIHBvcnRAMDogRmlyc3QgTFZEUyBpbnB1dCBwb3J0Cj4gPj4gKy0gcG9ydEAyOiBGaXJzdCBk aWdpdGFsIENNT1MvVFRMIHBhcmFsbGVsIG91dHB1dAo+ID4+ICsKPiA+PiArT3B0aW9uYWwgdmlk ZW8gcG9ydCBub2RlczoKPiA+PiArLSBwb3J0QDE6IFNlY29uZCBMVkRTIGlucHV0IHBvcnQKPiA+ PiArLSBwb3J0QDM6IFNlY29uZCBkaWdpdGFsIENNT1MvVFRMIHBhcmFsbGVsIG91dHB1dAo+ID4+ ICsKPiA+PiArRXhhbXBsZToKPiA+PiArLS0tLS0tLS0KPiA+PiArCj4gPj4gKwl0aGM2M2x2ZDEw MjQ6IGx2ZHMtZGVjb2RlciB7Cj4gPj4gKwkJY29tcGF0aWJsZSA9ICJ0aGluZSx0aGM2M2x2ZDEw MjQiOwo+ID4+ICsKPiA+PiArCQl2Y2Mtc3VwcGx5ID0gPCZyZWdfbHZkc192Y2M+Owo+ID4+ICsJ CXBvd2VyZG93bi1ncGlvcyA9IDwmZ3BpbzQgMTUgR1BJT19BQ1RJVkVfTE9XPjsKPiA+PiArCj4g Pj4gKwkJcG9ydHMgewo+ID4+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+PiArCQkJI3Np emUtY2VsbHMgPSA8MD47Cj4gPj4gKwo+ID4+ICsJCQlwb3J0QDAgewo+ID4+ICsJCQkJcmVnID0g PDA+Owo+ID4+ICsKPiA+PiArCQkJCWx2ZHNfZGVjX2luXzA6IGVuZHBvaW50IHsKPiA+PiArCQkJ CQlyZW1vdGUtZW5kcG9pbnQgPSA8Jmx2ZHNfb3V0PjsKPiA+PiArCQkJCX07Cj4gPj4gKwkJCX07 Cj4gPj4gKwo+ID4+ICsJCQlwb3J0QDJ7Cj4gPj4gKwkJCQlyZWcgPSA8Mj47Cj4gPj4gKwo+ID4+ ICsJCQkJbHZkc19kZWNfb3V0XzI6IGVuZHBvaW50IHsKPiA+PiArCQkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JmFkdjc1MTFfaW4+Owo+ID4+ICsJCQkJfTsKPiA+PiArCQkJfTsKPiA+PiArCQl9Owo+ ID4+ICsJfTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK