From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Pavel Dovgalyuk" <pavel.dovgalyuk@ispras.ru>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PATCH] util/log: flush TB cache when log level changes
Date: Fri, 22 Jan 2021 15:05:24 +0100 [thread overview]
Message-ID: <2447642f-6e8f-61b2-13ba-929ff640e80f@redhat.com> (raw)
In-Reply-To: <87y2glry84.fsf@linaro.org>
On 1/22/21 12:42 PM, Alex Bennée wrote:
>
> Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> writes:
>
>> Sometimes we need to collect the translation logs starting
>> from some point of the execution. Some TB listings may
>> be missed in this case, when blocks were translated before.
>> This patch clears TB cache to allow re-translation of such
>> code blocks.
>>
>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
>> ---
>> accel/tcg/translate-all.c | 8 ++++++++
>> include/sysemu/tcg.h | 1 +
>> stubs/meson.build | 1 +
>> stubs/tcg.c | 12 ++++++++++++
>> util/log.c | 3 +++
>> 5 files changed, 25 insertions(+)
>> create mode 100644 stubs/tcg.c
...
> I would call tb_flush(current_cpu) or first_cpu here. But two things:
>
> - I'm not sure you have a CPU at all times qemu_set_log is called
Indeed, with QTest accelerator it is NULL. I also remember
some odd cases when running commands from the monitor.
Regards,
Phil.
next prev parent reply other threads:[~2021-01-22 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 10:03 [PATCH] util/log: flush TB cache when log level changes Pavel Dovgalyuk
2021-01-22 10:32 ` Philippe Mathieu-Daudé
2021-01-22 10:47 ` Pavel Dovgalyuk
2021-01-22 11:42 ` Alex Bennée
2021-01-22 14:05 ` Philippe Mathieu-Daudé [this message]
2021-01-25 6:52 ` Pavel Dovgalyuk
2021-01-25 11:09 ` Alex Bennée
2021-02-01 7:21 ` Pavel Dovgalyuk
2021-02-01 8:46 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2447642f-6e8f-61b2-13ba-929ff640e80f@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.