From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbdLFMG7 (ORCPT ); Wed, 6 Dec 2017 07:06:59 -0500 Received: from mout.web.de ([212.227.15.14]:54338 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbdLFMGy (ORCPT ); Wed, 6 Dec 2017 07:06:54 -0500 To: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() Message-ID: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> Date: Wed, 6 Dec 2017 13:06:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jqtkFAUlKXQwg6BOOXabkAhTUsGS26BKHi/pN31rZ/G5UBIUMTQ Q6lPsaB2qdmuRRah2la6INCT3/fvZBMIasg9TDPD8/dqsLdvq6gii+siEQRjny6KCD47ftR 8bLxowR3hPdnhf91aZLnoTKKtstwST1I3RwReFPeT6C3kEVebwvRjM0oEFBSZwDwvTk9i2B NxKwEEbuoVTExQOwYZzCw== X-UI-Out-Filterresults: notjunk:1;V01:K0:V/gQGmiAR8Y=:8n0Mw4zIBXdFOYm2JRhjjL ng6RPyJVJKVcZfDSrh1mBTcT0SN909yXQttDsLyQ5+95mlDZ6sOflNgcE2gfxDK7An6ZZ0HPY A1FSl71nNybDGmuDA+A8blrHD0QuBFG+vGXi/9K3XuxWTMmKX5pESIls8qiqhsG3QewtOmZxu rZUFGCDAxxLlR+SFnEB+MINvRsva65y1nk5SGeeyLVdIGrOcJ1shsZgmODw+O72Mck96UACjK 0g3lQPLvHCW2VxG43kqgPLjo9x7rHf67w8FEmC3hX0tRhV94X5XCL8kYPFZkWr2cfbtCJxYJ7 BJcCPvNpYz6MoNj6Z8kdOMkxOo8Cql6eGj7Lq6BrEDj+7V9SH3vXmALHyCuN1p5dDnMsmusNO QWV/F0xiL19CPihkC/f1ZAtRSqW2yvME/+BxVIGg+7dy+IlnxJj69IUnUlJ3pb2PC3/f3yF4N 7cfi6YxnAQ2vmXqn4E/2DU+YwJoXHxPokaqQeuBK2C/UxGFKNkMJPKE8KDpy+V+QZnsivYNj+ rOgDAPIKIb3HKMS80x7FEgvXO5Fh6slTchZl7ckzf62QxGTnrdfcbDpUydRrko/F8m7nHWZh6 xgLX1//BJPf8m8y1G0HTIRJixiZLbDAtKCPrROkjIEaNuydAC7u1hRgicGzktDaG5WNJ6NZQ7 4X/RBgEV2IISAfFqtcduaYrOoMGX8I7H0QZSFGOAHjeHTcmZayv2mJ8pdAuXiXBsGod93EiyT vPO8V5qLlFe7ws9ksuKW70qzDRS8cHu7Ez3wR1k82rVuK+DN4SyDpZDbmAGf+k8WiVXq4sV1Q gBZCaWfxyULY52r8sTDcMk6QDfYTfoz+udvL+vBvBPFsC9PcUY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 6 Dec 2017 13:03:21 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/misc/emi26.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c index 24d841850e05..654e93857d65 100644 --- a/drivers/usb/misc/emi26.c +++ b/drivers/usb/misc/emi26.c @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, int result; unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); - if (!buffer) { - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); + if (!buffer) return -ENOMEM; - } + /* Note: usb_control_msg returns negative value on error or length of the * data that was written! */ result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 06 Dec 2017 12:06:32 +0000 Subject: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() Message-Id: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Wed, 6 Dec 2017 13:03:21 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/misc/emi26.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/emi26.c b/drivers/usb/misc/emi26.c index 24d841850e05..654e93857d65 100644 --- a/drivers/usb/misc/emi26.c +++ b/drivers/usb/misc/emi26.c @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address, int result; unsigned char *buffer = kmemdup(data, length, GFP_KERNEL); - if (!buffer) { - dev_err(&dev->dev, "kmalloc(%d) failed.\n", length); + if (!buffer) return -ENOMEM; - } + /* Note: usb_control_msg returns negative value on error or length of the * data that was written! */ result = usb_control_msg (dev, usb_sndctrlpipe(dev, 0), request, 0x40, address, 0, buffer, length, 300); -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory() From: SF Markus Elfring Message-Id: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net> Date: Wed, 6 Dec 2017 13:06:32 +0100 To: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Johan Hovold Cc: LKML , kernel-janitors@vger.kernel.org List-ID: RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBXZWQsIDYgRGVjIDIwMTcgMTM6MDM6MjEgKzAxMDAKCk9taXQgYW4gZXh0cmEgbWVzc2FnZSBm b3IgYSBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlIGluIHRoaXMgZnVuY3Rpb24uCgpUaGlzIGlz c3VlIHdhcyBkZXRlY3RlZCBieSB1c2luZyB0aGUgQ29jY2luZWxsZSBzb2Z0d2FyZS4KClNpZ25l ZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4K LS0tCiBkcml2ZXJzL3VzYi9taXNjL2VtaTI2LmMgfCA1ICsrLS0tCiAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L21pc2MvZW1pMjYuYyBiL2RyaXZlcnMvdXNiL21pc2MvZW1pMjYuYwppbmRleCAyNGQ4NDE4NTBl MDUuLjY1NGU5Mzg1N2Q2NSAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2IvbWlzYy9lbWkyNi5jCisr KyBiL2RyaXZlcnMvdXNiL21pc2MvZW1pMjYuYwpAQCAtNDIsMTAgKzQyLDkgQEAgc3RhdGljIGlu dCBlbWkyNl93cml0ZW1lbW9yeSAoc3RydWN0IHVzYl9kZXZpY2UgKmRldiwgaW50IGFkZHJlc3Ms CiAJaW50IHJlc3VsdDsKIAl1bnNpZ25lZCBjaGFyICpidWZmZXIgPSAga21lbWR1cChkYXRhLCBs ZW5ndGgsIEdGUF9LRVJORUwpOwogCi0JaWYgKCFidWZmZXIpIHsKLQkJZGV2X2VycigmZGV2LT5k ZXYsICJrbWFsbG9jKCVkKSBmYWlsZWQuXG4iLCBsZW5ndGgpOworCWlmICghYnVmZmVyKQogCQly ZXR1cm4gLUVOT01FTTsKLQl9CisKIAkvKiBOb3RlOiB1c2JfY29udHJvbF9tc2cgcmV0dXJucyBu ZWdhdGl2ZSB2YWx1ZSBvbiBlcnJvciBvciBsZW5ndGggb2YgdGhlCiAJICogCQkgZGF0YSB0aGF0 IHdhcyB3cml0dGVuISAqLwogCXJlc3VsdCA9IHVzYl9jb250cm9sX21zZyAoZGV2LCB1c2Jfc25k Y3RybHBpcGUoZGV2LCAwKSwgcmVxdWVzdCwgMHg0MCwgYWRkcmVzcywgMCwgYnVmZmVyLCBsZW5n dGgsIDMwMCk7Cg==