From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37F3C433EF for ; Mon, 4 Oct 2021 14:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB98E6136F for ; Mon, 4 Oct 2021 14:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233874AbhJDO3l (ORCPT ); Mon, 4 Oct 2021 10:29:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233767AbhJDO3l (ORCPT ); Mon, 4 Oct 2021 10:29:41 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDACC061745 for ; Mon, 4 Oct 2021 07:27:52 -0700 (PDT) Received: from [IPv6:2a01:e0a:4cb:a870:445e:c29d:10aa:bf6] (unknown [IPv6:2a01:e0a:4cb:a870:445e:c29d:10aa:bf6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1A7041F43211; Mon, 4 Oct 2021 15:27:50 +0100 (BST) Subject: Re: [PATCH v4 10/18] soc: imx: add i.MX8M blk-ctrl driver To: Lucas Stach , Shawn Guo Cc: Rob Herring , Fabio Estevam , NXP Linux Team , Adam Ford , Frieder Schrempf , Marek Vasut , Tim Harvey , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de References: <20210910202640.980366-1-l.stach@pengutronix.de> <20210910202640.980366-11-l.stach@pengutronix.de> <5b5609e9-cbba-79be-218c-0dd508e26ecf@collabora.com> <763dff4c948a5c435dc4d51224e825071c0a3cd6.camel@pengutronix.de> From: Benjamin Gaignard Message-ID: <24568eb4-11d5-1fd7-e111-382b41cdb4da@collabora.com> Date: Mon, 4 Oct 2021 16:27:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <763dff4c948a5c435dc4d51224e825071c0a3cd6.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le 02/10/2021 à 03:07, Lucas Stach a écrit : > Hi Benjamin, > > Am Dienstag, dem 14.09.2021 um 17:46 +0200 schrieb Benjamin Gaignard: >> Le 10/09/2021 à 22:26, Lucas Stach a écrit : >>> This adds a driver for the blk-ctrl blocks found in the i.MX8M* line of >>> SoCs. The blk-ctrl is a top-level peripheral located in the various *MIX >>> power domains and interacts with the GPC power controller to provide the >>> peripherals in the power domain access to the NoC and ensures that those >>> peripherals are properly reset when their respective power domain is >>> brought back to life. >>> >>> Software needs to do different things to make the bus handshake happen >>> after the GPC *MIX domain is powered up and before it is powered down. >>> As the requirements are quite different between the various blk-ctrls >>> there is a callback function provided to hook in the proper sequence. >>> >>> The peripheral domains are quite uniform, they handle the soft clock >>> enables and resets in the blk-ctrl address space and sequencing with the >>> upstream GPC power domains. >> Hi Lucas, >> >> I have tried to use your patches for IMX8MQ but it seems that the hardware >> have different architecture. >> On IMX8MQ there is only one VPU domain for G1 and G2 and that doesn't match >> with your implementation where it is needed to have "bus" and devices power domain. >> From what I experiment in current IMX8MQ implementation of blk-ctrl (inside VPU driver) >> enabling the 3 clocks (bus, G1, G2) is needed to reset the VPUs. >> >> Do you think you can update your design to take care of these hardware variations ? > The clocking/reset of the blk-ctrl and ADB in the i.MX8MQ VPU power > domain is really a bit strange, as the ADB reset is tied to the VPU > resets and the clk-ctrl seem to require all 3 VPU clocks, instead of > only the bus clock as in newer designs. However I was able to make it > work with the existing blk-ctrl driver design. > > My current WIP patches (only tested with the G1 core so far) on top of > the v5 of the series I just sent out can be found here: > https://git.pengutronix.de/cgit/lst/linux/log/?h=imx8mq-vpu-blk-ctrl > > Hope this helps. Hi Lucas, I have been able to test your branch on my iMX8MQ. I confirm that G1 is working fine, I able to decode H264 files. I wasn't able to make G2 works, I think it is coming from the reset sequence done before each frame decoding in G2 driver. I have change imx8mq_runtime_resume() and imx8m_vpu_reset() to call pm_runtime_put() and pm_runtime_get() to perform a reset like. Without that G2 hangs when decoding the first frame. One G1 it seems that doing a reset before each frame decoding is not needed. On DT I had to assignee G1 and G2 on the both nodes to avoid a warning at probe time. assigned-clocks = <&clk IMX8MQ_CLK_VPU_G1>, <&clk IMX8MQ_CLK_VPU_G2>, <&clk IMX8MQ_VPU_PLL_BYPASS>; assigned-clock-parents = <&clk IMX8MQ_VPU_PLL_OUT>, <&clk IMX8MQ_VPU_PLL_OUT>, <&clk IMX8MQ_VPU_PLL>; assigned-clock-rates = <600000000>, <300000000>, <0>; I also set G2 clock at 300Mhz as specify in the TRM. Even with all this G2 doesn't fire interrupts. Benjamin > > Regards, > Lucas > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD47C433EF for ; Mon, 4 Oct 2021 14:29:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA1F061360 for ; Mon, 4 Oct 2021 14:29:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA1F061360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1l2+3XIyqiNaP7VdNzcc56ouqFrga8uYY5Rkc1HfTXs=; b=BnsZjJ6smYEpDP4gAxA8CzyoaR AzO+mJio8+4tst8kKxOAN2Bfa5A+pkJZW9QrFLGZvKzvUL0olrx+CGNe6TixbKVe+b2yNhqZDRo30 3lBRqJWUKU6nk+5ij+4i9JC5pv4P3EkzupjWJXSyjbFIV8xzA3gPPDt8vn6LyDmRSXlpwVeBSMBh0 x2aR7xQQteP3G9KfXYI7acb8qcc+9J6sxhmLpjmN971b8FT87Kigg0M286izmSFiJDxcjx3h0lYpw EcFraAOWFl0VqB7xJxH3LdXhM/gyXyzeECTrj08mXa7mSy13+6A+OOHGkIMCe72up3OjCJozW8oNi L1ASpiRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXOwg-006kvU-Ao; Mon, 04 Oct 2021 14:27:58 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXOwc-006kv3-Gf for linux-arm-kernel@lists.infradead.org; Mon, 04 Oct 2021 14:27:56 +0000 Received: from [IPv6:2a01:e0a:4cb:a870:445e:c29d:10aa:bf6] (unknown [IPv6:2a01:e0a:4cb:a870:445e:c29d:10aa:bf6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1A7041F43211; Mon, 4 Oct 2021 15:27:50 +0100 (BST) Subject: Re: [PATCH v4 10/18] soc: imx: add i.MX8M blk-ctrl driver To: Lucas Stach , Shawn Guo Cc: Rob Herring , Fabio Estevam , NXP Linux Team , Adam Ford , Frieder Schrempf , Marek Vasut , Tim Harvey , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de References: <20210910202640.980366-1-l.stach@pengutronix.de> <20210910202640.980366-11-l.stach@pengutronix.de> <5b5609e9-cbba-79be-218c-0dd508e26ecf@collabora.com> <763dff4c948a5c435dc4d51224e825071c0a3cd6.camel@pengutronix.de> From: Benjamin Gaignard Message-ID: <24568eb4-11d5-1fd7-e111-382b41cdb4da@collabora.com> Date: Mon, 4 Oct 2021 16:27:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <763dff4c948a5c435dc4d51224e825071c0a3cd6.camel@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211004_072754_732091_278D3F34 X-CRM114-Status: GOOD ( 27.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkxlIDAyLzEwLzIwMjEgw6AgMDM6MDcsIEx1Y2FzIFN0YWNoIGEgw6ljcml0wqA6Cj4gSGkgQmVu amFtaW4sCj4KPiBBbSBEaWVuc3RhZywgZGVtIDE0LjA5LjIwMjEgdW0gMTc6NDYgKzAyMDAgc2No cmllYiBCZW5qYW1pbiBHYWlnbmFyZDoKPj4gTGUgMTAvMDkvMjAyMSDDoCAyMjoyNiwgTHVjYXMg U3RhY2ggYSDDqWNyaXTCoDoKPj4+IFRoaXMgYWRkcyBhIGRyaXZlciBmb3IgdGhlIGJsay1jdHJs IGJsb2NrcyBmb3VuZCBpbiB0aGUgaS5NWDhNKiBsaW5lIG9mCj4+PiBTb0NzLiBUaGUgYmxrLWN0 cmwgaXMgYSB0b3AtbGV2ZWwgcGVyaXBoZXJhbCBsb2NhdGVkIGluIHRoZSB2YXJpb3VzICpNSVgK Pj4+IHBvd2VyIGRvbWFpbnMgYW5kIGludGVyYWN0cyB3aXRoIHRoZSBHUEMgcG93ZXIgY29udHJv bGxlciB0byBwcm92aWRlIHRoZQo+Pj4gcGVyaXBoZXJhbHMgaW4gdGhlIHBvd2VyIGRvbWFpbiBh Y2Nlc3MgdG8gdGhlIE5vQyBhbmQgZW5zdXJlcyB0aGF0IHRob3NlCj4+PiBwZXJpcGhlcmFscyBh cmUgcHJvcGVybHkgcmVzZXQgd2hlbiB0aGVpciByZXNwZWN0aXZlIHBvd2VyIGRvbWFpbiBpcwo+ Pj4gYnJvdWdodCBiYWNrIHRvIGxpZmUuCj4+Pgo+Pj4gU29mdHdhcmUgbmVlZHMgdG8gZG8gZGlm ZmVyZW50IHRoaW5ncyB0byBtYWtlIHRoZSBidXMgaGFuZHNoYWtlIGhhcHBlbgo+Pj4gYWZ0ZXIg dGhlIEdQQyAqTUlYIGRvbWFpbiBpcyBwb3dlcmVkIHVwIGFuZCBiZWZvcmUgaXQgaXMgcG93ZXJl ZCBkb3duLgo+Pj4gQXMgdGhlIHJlcXVpcmVtZW50cyBhcmUgcXVpdGUgZGlmZmVyZW50IGJldHdl ZW4gdGhlIHZhcmlvdXMgYmxrLWN0cmxzCj4+PiB0aGVyZSBpcyBhIGNhbGxiYWNrIGZ1bmN0aW9u IHByb3ZpZGVkIHRvIGhvb2sgaW4gdGhlIHByb3BlciBzZXF1ZW5jZS4KPj4+Cj4+PiBUaGUgcGVy aXBoZXJhbCBkb21haW5zIGFyZSBxdWl0ZSB1bmlmb3JtLCB0aGV5IGhhbmRsZSB0aGUgc29mdCBj bG9jawo+Pj4gZW5hYmxlcyBhbmQgcmVzZXRzIGluIHRoZSBibGstY3RybCBhZGRyZXNzIHNwYWNl IGFuZCBzZXF1ZW5jaW5nIHdpdGggdGhlCj4+PiB1cHN0cmVhbSBHUEMgcG93ZXIgZG9tYWlucy4K Pj4gSGkgTHVjYXMsCj4+Cj4+IEkgaGF2ZSB0cmllZCB0byB1c2UgeW91ciBwYXRjaGVzIGZvciBJ TVg4TVEgYnV0IGl0IHNlZW1zIHRoYXQgdGhlIGhhcmR3YXJlCj4+IGhhdmUgZGlmZmVyZW50IGFy Y2hpdGVjdHVyZS4KPj4gT24gSU1YOE1RIHRoZXJlIGlzIG9ubHkgb25lIFZQVSBkb21haW4gZm9y IEcxIGFuZCBHMiBhbmQgdGhhdCBkb2Vzbid0IG1hdGNoCj4+IHdpdGggeW91ciBpbXBsZW1lbnRh dGlvbiB3aGVyZSBpdCBpcyBuZWVkZWQgdG8gaGF2ZSAiYnVzIiBhbmQgZGV2aWNlcyBwb3dlciBk b21haW4uCj4+ICAgRnJvbSB3aGF0IEkgZXhwZXJpbWVudCBpbiBjdXJyZW50IElNWDhNUSBpbXBs ZW1lbnRhdGlvbiBvZiBibGstY3RybCAoaW5zaWRlIFZQVSBkcml2ZXIpCj4+IGVuYWJsaW5nIHRo ZSAzIGNsb2NrcyAoYnVzLCBHMSwgRzIpIGlzIG5lZWRlZCB0byByZXNldCB0aGUgVlBVcy4KPj4K Pj4gRG8geW91IHRoaW5rIHlvdSBjYW4gdXBkYXRlIHlvdXIgZGVzaWduIHRvIHRha2UgY2FyZSBv ZiB0aGVzZSBoYXJkd2FyZSB2YXJpYXRpb25zID8KPiBUaGUgY2xvY2tpbmcvcmVzZXQgb2YgdGhl IGJsay1jdHJsIGFuZCBBREIgaW4gdGhlIGkuTVg4TVEgVlBVIHBvd2VyCj4gZG9tYWluIGlzIHJl YWxseSBhIGJpdCBzdHJhbmdlLCBhcyB0aGUgQURCIHJlc2V0IGlzIHRpZWQgdG8gdGhlIFZQVQo+ IHJlc2V0cyBhbmQgdGhlIGNsay1jdHJsIHNlZW0gdG8gcmVxdWlyZSBhbGwgMyBWUFUgY2xvY2tz LCBpbnN0ZWFkIG9mCj4gb25seSB0aGUgYnVzIGNsb2NrIGFzIGluIG5ld2VyIGRlc2lnbnMuIEhv d2V2ZXIgSSB3YXMgYWJsZSB0byBtYWtlIGl0Cj4gd29yayB3aXRoIHRoZSBleGlzdGluZyBibGst Y3RybCBkcml2ZXIgZGVzaWduLgo+Cj4gTXkgY3VycmVudCBXSVAgcGF0Y2hlcyAob25seSB0ZXN0 ZWQgd2l0aCB0aGUgRzEgY29yZSBzbyBmYXIpIG9uIHRvcCBvZgo+IHRoZSB2NSBvZiB0aGUgc2Vy aWVzIEkganVzdCBzZW50IG91dCBjYW4gYmUgZm91bmQgaGVyZToKPiBodHRwczovL2dpdC5wZW5n dXRyb25peC5kZS9jZ2l0L2xzdC9saW51eC9sb2cvP2g9aW14OG1xLXZwdS1ibGstY3RybAo+Cj4g SG9wZSB0aGlzIGhlbHBzLgoKSGkgTHVjYXMsCgpJIGhhdmUgYmVlbiBhYmxlIHRvIHRlc3QgeW91 ciBicmFuY2ggb24gbXkgaU1YOE1RLgpJIGNvbmZpcm0gdGhhdCBHMSBpcyB3b3JraW5nIGZpbmUs IEkgYWJsZSB0byBkZWNvZGUgSDI2NCBmaWxlcy4KCkkgd2Fzbid0IGFibGUgdG8gbWFrZSBHMiB3 b3JrcywgSSB0aGluayBpdCBpcyBjb21pbmcgZnJvbSB0aGUgcmVzZXQgc2VxdWVuY2UKZG9uZSBi ZWZvcmUgZWFjaCBmcmFtZSBkZWNvZGluZyBpbiBHMiBkcml2ZXIuCkkgaGF2ZSBjaGFuZ2UgaW14 OG1xX3J1bnRpbWVfcmVzdW1lKCkgYW5kICBpbXg4bV92cHVfcmVzZXQoKQp0byBjYWxsIHBtX3J1 bnRpbWVfcHV0KCkgYW5kIHBtX3J1bnRpbWVfZ2V0KCkgdG8gcGVyZm9ybSBhIHJlc2V0IGxpa2Uu CldpdGhvdXQgdGhhdCBHMiBoYW5ncyB3aGVuIGRlY29kaW5nIHRoZSBmaXJzdCBmcmFtZS4KCk9u ZSBHMSBpdCBzZWVtcyB0aGF0IGRvaW5nIGEgcmVzZXQgYmVmb3JlIGVhY2ggZnJhbWUgZGVjb2Rp bmcgaXMgbm90IG5lZWRlZC4KCk9uIERUIEkgaGFkIHRvIGFzc2lnbmVlIEcxIGFuZCBHMiBvbiB0 aGUgYm90aCBub2RlcyB0byBhdm9pZCBhIHdhcm5pbmcgYXQgcHJvYmUgdGltZS4KYXNzaWduZWQt Y2xvY2tzID0gPCZjbGsgSU1YOE1RX0NMS19WUFVfRzE+LAoJCQkJCSAgPCZjbGsgSU1YOE1RX0NM S19WUFVfRzI+LAoJCQkJCSAgPCZjbGsgSU1YOE1RX1ZQVV9QTExfQllQQVNTPjsKCQkJYXNzaWdu ZWQtY2xvY2stcGFyZW50cyA9IDwmY2xrIElNWDhNUV9WUFVfUExMX09VVD4sCgkJCQkJCSA8JmNs ayBJTVg4TVFfVlBVX1BMTF9PVVQ+LAoJCQkJCQkgPCZjbGsgSU1YOE1RX1ZQVV9QTEw+OwoJCQlh c3NpZ25lZC1jbG9jay1yYXRlcyA9IDw2MDAwMDAwMDA+LCA8MzAwMDAwMDAwPiwgPDA+OwoKSSBh bHNvIHNldCBHMiBjbG9jayBhdCAzMDBNaHogYXMgc3BlY2lmeSBpbiB0aGUgVFJNLgpFdmVuIHdp dGggYWxsIHRoaXMgRzIgZG9lc24ndCBmaXJlIGludGVycnVwdHMuCgpCZW5qYW1pbgoKPgo+IFJl Z2FyZHMsCj4gTHVjYXMKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=