From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03710C433DB for ; Wed, 27 Jan 2021 15:57:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FE21207C4 for ; Wed, 27 Jan 2021 15:57:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE21207C4 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.76217.137434 (Exim 4.92) (envelope-from ) id 1l4nCU-0004yV-HD; Wed, 27 Jan 2021 15:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 76217.137434; Wed, 27 Jan 2021 15:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4nCU-0004yO-EG; Wed, 27 Jan 2021 15:57:46 +0000 Received: by outflank-mailman (input) for mailman id 76217; Wed, 27 Jan 2021 15:57:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4nCT-0004yC-Bn for xen-devel@lists.xenproject.org; Wed, 27 Jan 2021 15:57:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4nCT-0000up-Ax for xen-devel@lists.xenproject.org; Wed, 27 Jan 2021 15:57:45 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1l4nCT-0002ml-A7 for xen-devel@lists.xenproject.org; Wed, 27 Jan 2021 15:57:45 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1l4nCO-0001fk-R6; Wed, 27 Jan 2021 15:57:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=7Rv6QuZZUijellN/KGVcOODdtODCFq3AOWLbEUSPZjw=; b=Ye8Kdw5jlyNqwKqv3IJh3ochXf 4FPozYbMRyr4oivJMHuFIn+JJAR8H4NrFMxwL3RcXn5hoqlSvlLMdwIaV7A0Y1LpTT8xFgtqlklEO yeIRxJfv99Zhfg+E6kfTfP4QkUa1Q8K+Rg0IeLM0UZzlR+Ng8tS5ne3rWlCESJ4285NA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24593.36212.617275.862147@mariner.uk.xensource.com> Date: Wed, 27 Jan 2021 15:57:40 +0000 To: Manuel Bouyer Cc: xen-devel@lists.xenproject.org, Manuel Bouyer , Wei Liu Subject: Re: [PATCH] xenpmd.c: use dynamic allocation In-Reply-To: <20210112181242.1570-21-bouyer@antioche.eu.org> References: <20210112181242.1570-1-bouyer@antioche.eu.org> <20210112181242.1570-21-bouyer@antioche.eu.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Manuel Bouyer writes ("[PATCH] xenpmd.c: use dynamic allocation"): > From: Manuel Bouyer > > On NetBSD, d_name is larger than 256, so file_name[284] may not be large > enough (and gcc emits a format-truncation error). > Use asprintf() instead of snprintf() on a static on-stack buffer. Reviewed-by: Ian Jackson