From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33F2C433E0 for ; Thu, 28 Jan 2021 11:39:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B4E564DDB for ; Thu, 28 Jan 2021 11:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B4E564DDB Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.76948.139113 (Exim 4.92) (envelope-from ) id 1l55do-0003hw-2x; Thu, 28 Jan 2021 11:39:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 76948.139113; Thu, 28 Jan 2021 11:39:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l55dn-0003hp-Vt; Thu, 28 Jan 2021 11:39:11 +0000 Received: by outflank-mailman (input) for mailman id 76948; Thu, 28 Jan 2021 11:39:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l55dm-0003gd-Ak for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 11:39:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l55dm-0004Wt-58 for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 11:39:10 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1l55dm-0001RI-4D for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 11:39:10 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1l55df-00047v-B2; Thu, 28 Jan 2021 11:39:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=2xsUwPNTtlshm2WMqw1F75iopXm4+mjHsjBFpQNrVBc=; b=K/tCnlKTtZkea1Kfuax5uyOkOm cAJxekuL/kCbFd8Oj077PCV9EomgDJFQWzXZats6NZzyXgSFmkUH4d8RU7+GmyCBUU1y/5fp3Oj3w +ojrfH5xJ0rTfiOcSz9QL5HFoktVo5ZLExuf/11dZmHeI+PyqCIfc4LvgQPog6ZTlH7I=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24594.41559.85184.745760@mariner.uk.xensource.com> Date: Thu, 28 Jan 2021 11:39:03 +0000 To: Manuel Bouyer Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD Subject: Re: [PATCH] libs/light: make it build without setresuid() In-Reply-To: <20210127193430.GB26055@mail.soc.lip6.fr> References: <20210112181242.1570-16-bouyer@antioche.eu.org> <20210118181656.2abblbjg2jvhlad7@Air-de-Roger> <24584.17302.958286.788145@mariner.uk.xensource.com> <20210120151321.GB4175@antioche.eu.org> <24584.19725.745755.464840@mariner.uk.xensource.com> <20210120165615.GB5035@antioche.eu.org> <24584.25612.523093.188718@mariner.uk.xensource.com> <20210120172046.GA5772@antioche.eu.org> <24584.26722.347244.50758@mariner.uk.xensource.com> <24593.36536.770883.890760@mariner.uk.xensource.com> <20210127193430.GB26055@mail.soc.lip6.fr> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without setresuid()"): > On Wed, Jan 27, 2021 at 04:03:04PM +0000, Ian Jackson wrote: > > How about I write a patch splitting the relevant part up into a > > version for systems with setresuid and systems without ? Then you > > could fill in the missing part. > > Yesterday I sent a v2 with the rewriting you suggested. But I'm fine > with you doing the rewrite. OK. > > Should I expect the non-setresuid OS to provide effectively the whole > > orf kill_device_model_uid_child, or just a replacement for the > > setresuid call and surrounding logging, something like > > kill_device_model_uid_child_setresuid > > As far as I'm concerned, kill_device_model_uid_child_setresuid() is enough. > > Unfortunably I don't think I'll have time to work on dm restriction > for NetBSD before 4.15 No problem. Taking a step back, I think this series is very close to going in, if not actually ready. Do you have a git branch version of this ? I find the series of un-numbered patches you have posted make it hard to see the wood for the trees, and collect all the relevant pieces. A git branch version would make the life of the committer considerably easier. If you don't have a favourite public git server you can post me a link to, you could use gitlab.com where we have a mirror of xen.git. https://gitlab.com/xen-project/xen (If you need instructions mail me privately.) Regards, Ian.