From: Ian Jackson <iwj@xenproject.org>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Michał Leszczyński" <michal.leszczynski@cert.pl>,
"Wei Liu" <wl@xen.org>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Tamas K Lengyel" <tamas@tklengyel.com>
Subject: Re: [PATCH v9 03/11] tools/[lib]xl: Add vmtrace_buf_size parameter
Date: Tue, 2 Feb 2021 12:17:22 +0000 [thread overview]
Message-ID: <24601.17106.625570.402466@mariner.uk.xensource.com> (raw)
In-Reply-To: <24601.17068.666597.295268@mariner.uk.xensource.com>
Ian Jackson writes ("Re: [PATCH v9 03/11] tools/[lib]xl: Add vmtrace_buf_size parameter"):
> Andrew Cooper writes ("[PATCH v9 03/11] tools/[lib]xl: Add vmtrace_buf_size parameter"):
> > From: Michał Leszczyński <michal.leszczynski@cert.pl>
> >
> > Allow to specify the size of per-vCPU trace buffer upon
> > domain creation. This is zero by default (meaning: not enabled).
> ...
>
> Wearing my maintainer/reviewer hat:
>
> Release risk assessment for this patch:
>
> * This contains golang changes which might break the build or need
> updates to golang generated files. This ought to be detected by
> our tests so we can fix it. At this stage of the release that is
> probably OK. The risk of actually shipping a broken build is low.
>
> * The patch introduces a new libxl config parameter. That has API
> and UI implications. But it is a very small change and the
> semantics are fairly obvious. The name likewise is fine. So I am
> very comfortable with recommending this late addition to these
> APIs.
>
> * The patch contains buffer size handling code. In the general case
> that might produce a risk of buffer overruns. But at least here in
> this patch this is actually just the configured size of a buffer,
> and actual length/use checks are done elsewhere, so this is is not
> a real risk.
Consequently, wearing my RM hat, this patch:
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
next prev parent reply other threads:[~2021-02-02 12:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 23:26 [PATCH v9 00/11] acquire_resource size and external IPT monitoring Andrew Cooper
2021-02-01 23:26 ` [PATCH v9 01/11] xen/memory: Fix mapping grant tables with XENMEM_acquire_resource Andrew Cooper
2021-02-04 21:23 ` Andrew Cooper
2021-02-01 23:26 ` [PATCH v9 02/11] xen/domain: Add vmtrace_size domain creation parameter Andrew Cooper
2021-02-02 9:04 ` Jan Beulich
2021-02-03 16:04 ` Andrew Cooper
2021-02-04 11:11 ` Jan Beulich
2021-02-01 23:26 ` [PATCH v9 03/11] tools/[lib]xl: Add vmtrace_buf_size parameter Andrew Cooper
2021-02-02 12:16 ` Ian Jackson
2021-02-02 12:17 ` Ian Jackson [this message]
2021-02-01 23:26 ` [PATCH v9 04/11] xen/memory: Add a vmtrace_buf resource type Andrew Cooper
2021-02-01 23:26 ` [PATCH v9 05/11] x86/vmx: Add Intel Processor Trace support Andrew Cooper
2021-02-01 23:26 ` [PATCH v9 06/11] xen/domctl: Add XEN_DOMCTL_vmtrace_op Andrew Cooper
2021-02-01 23:26 ` [PATCH v9 07/11] tools/libxc: Add xc_vmtrace_* functions Andrew Cooper
2021-02-01 23:27 ` [PATCH v9 08/11] tools/misc: Add xen-vmtrace tool Andrew Cooper
2021-02-01 23:27 ` [PATCH v9 09/11] xen/vmtrace: support for VM forks Andrew Cooper
2021-02-01 23:27 ` [PATCH v9 10/11] x86/vm_event: Carry the vmtrace buffer position in vm_event Andrew Cooper
2021-02-01 23:27 ` [PATCH v9 11/11] x86/vm_event: add response flag to reset vmtrace buffer Andrew Cooper
2021-02-02 12:20 ` [PATCH v9 00/11] acquire_resource size and external IPT monitoring Ian Jackson
2021-02-02 12:44 ` Andrew Cooper
2021-02-02 20:19 ` Andrew Cooper
2021-02-05 15:36 ` [PATCH v9 00/11] acquire_resource size and external IPT monitoring [and 1 more messages] Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24601.17106.625570.402466@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=michal.leszczynski@cert.pl \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.