From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C02C433DB for ; Wed, 3 Feb 2021 17:26:58 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4688364DF6 for ; Wed, 3 Feb 2021 17:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4688364DF6 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.80989.148770 (Exim 4.92) (envelope-from ) id 1l7LvW-0007G7-Ig; Wed, 03 Feb 2021 17:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 80989.148770; Wed, 03 Feb 2021 17:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l7LvW-0007G0-FU; Wed, 03 Feb 2021 17:26:50 +0000 Received: by outflank-mailman (input) for mailman id 80989; Wed, 03 Feb 2021 17:26:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l7LvV-0007Fr-6R for xen-devel@lists.xenproject.org; Wed, 03 Feb 2021 17:26:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l7LvV-0004p9-5j for xen-devel@lists.xenproject.org; Wed, 03 Feb 2021 17:26:49 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1l7LvV-0000gl-4q for xen-devel@lists.xenproject.org; Wed, 03 Feb 2021 17:26:49 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1l7LvQ-0005Zq-Ca; Wed, 03 Feb 2021 17:26:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=MvQxSNbrKt2Zb6XufKKBOCD/1HuYdGafTzpPSfhEj3c=; b=AsNCNLLhwzzmwN6qeGfyfW8237 sUA00NBUyL+FQfM/bhskL7NXdM7SIWFk5QAnp1LTPmKb3xb6Ka1E07+wUKXh6mv3iRapa19zbNI5Y VQnrRy2Te3Nf1MzgLJgVw3L1paKFAdNaW617NwZlyVHVdWQciDZzJZSZWcIS/R4t1IAY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24602.56532.169889.71270@mariner.uk.xensource.com> Date: Wed, 3 Feb 2021 17:26:44 +0000 To: Roger Pau =?iso-8859-1?Q?Monn=E9?= CC: Manuel Bouyer , xen-devel@lists.xenproject.org, Elena Ufimtseva , Ian Jackson , Wei Liu Subject: Re: [PATCH v3] NetBSD: use system-provided headers In-Reply-To: <20210203165421.1550-4-bouyer@netbsd.org> References: <20210203165421.1550-1-bouyer@netbsd.org> <20210203165421.1550-4-bouyer@netbsd.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Manuel Bouyer writes ("[PATCH v3] NetBSD: use system-provided headers"): > +#ifdef __NetBSD__ > +#include > +#else > #include > +#endif > #include > #include Maneul, thanks. I think this is a bugfix and ought in principle to go in but I think we probably want to do this with configure rather than ad-hoc ifdefs. Roger, what do you think ? Were you going to add a configure test for the #ifdef that we put in earlier ? Thanks, Ian.