From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 295DAC433EF for ; Tue, 7 Jun 2022 12:11:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C57B842B6; Tue, 7 Jun 2022 14:11:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="LMQuWdaU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 63DD58430D; Tue, 7 Jun 2022 14:11:40 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20625.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::625]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2030842B1 for ; Tue, 7 Jun 2022 14:11:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/gQqeTBNZZevDgOm1N4X8+uVXwPckoWUmkGwjVIOC/SYWPg3bByhlaoyaU+1IMCbCWg6oSvreVrrwXQ3cxz0jIVrAL75ShB3TfgL6O8QHzme6SEH5kT74ufxPRAmsaomupZ3FMFaCAm6R5UdETWay33qHj2VEtvfCkXDlrWtG9RfmYl4NQJS9e0PD0bOwfEBJRH9CruALKX5V3sanEMb1SH9MyEgmDdguwEXF8M43D/sptnbe8LWvoN93cSvWgvHDRY2QusSAl2pQWvMUdLXyQr3h8ij7GrILsvk9//33VPYEd3Eqp5yQfBhNa6CFiUDlWwqxhQh0ku6IOLYTU/nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PzkXgCsGPDKD9uHIQHRUkrVZHLFrFqeNZU6Uy+FFDTk=; b=cr1498jy7wvPAaFTbf42eEuaM8JKa47OSnlqmHxGDF4e5afeXx1Xg9v22VPTgs4GgGW8BkgqqHoqeGW98PreDw7Gj14qZb/Y4KRwRuwPVcIlBh1pvbnBCe6pt1i+O4V30YalefV/8bP+8xGcXtd4cYZ24GKpP/1WA4QnJM5JtIM8IxgV4HVgEOQD80W6LW1isbvnAy9OVpRpEc/6PsVOhAwJyVOlQeUaEW69QoGLhdy1LazkJ1ANJcBl9jnYW07rqE+BhsE5mi+U4QiqSmLfdKIno7HitA4B2yJm6rR9sPWd7ovA2LAI1jkBM/O4UAHSt3eA+41h9kc+HKEV0OxDJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=foundries.io smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PzkXgCsGPDKD9uHIQHRUkrVZHLFrFqeNZU6Uy+FFDTk=; b=LMQuWdaUyxXlGU37ZuRX02tizIGHXrun0e5j+ToAEHLCkU5MH0PBu/p26hPDJS4VEbCzhBuRpko2ULywhUy9zu7wUXRMm742wah5Agmbr5uZbieCdH0NdesJVMU/BrqL9aaK0QWKdu7Woc2/iC1ap75Cl6QvFYfmQwfxdbRz2n4= Received: from DS7PR03CA0335.namprd03.prod.outlook.com (2603:10b6:8:55::34) by DM6PR02MB5579.namprd02.prod.outlook.com (2603:10b6:5:7b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 7 Jun 2022 12:11:31 +0000 Received: from DM3NAM02FT018.eop-nam02.prod.protection.outlook.com (2603:10b6:8:55:cafe::e9) by DS7PR03CA0335.outlook.office365.com (2603:10b6:8:55::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Tue, 7 Jun 2022 12:11:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT018.mail.protection.outlook.com (10.13.4.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Tue, 7 Jun 2022 12:11:30 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 7 Jun 2022 05:11:30 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 7 Jun 2022 05:11:30 -0700 Envelope-to: oleksandr.suvorov@foundries.io, u-boot@lists.denx.de, adrian.fiergolski@fastree3d.com, jorge@foundries.io, ricardo@foundries.io, igor.opaniuk@foundries.io, michal.simek@amd.com Received: from [10.254.241.50] (port=40840) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nyY3V-000EaP-No; Tue, 07 Jun 2022 05:11:29 -0700 Message-ID: <2460241d-7008-9e42-425c-2e348ab784c2@xilinx.com> Date: Tue, 7 Jun 2022 14:11:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v9 05/13] fpga: add fpga_compatible2flag Content-Language: en-US To: Oleksandr Suvorov , CC: Adrian Fiergolski , Jorge Ramirez-Ortiz , Michal Simek , Ricardo Salveti , Igor Opaniuk , Michal Simek References: <20220601084623.16006-1-oleksandr.suvorov@foundries.io> <20220601084623.16006-2-oleksandr.suvorov@foundries.io> <20220601084623.16006-3-oleksandr.suvorov@foundries.io> <20220601084623.16006-4-oleksandr.suvorov@foundries.io> <20220601084623.16006-5-oleksandr.suvorov@foundries.io> <20220601084623.16006-6-oleksandr.suvorov@foundries.io> From: Michal Simek In-Reply-To: <20220601084623.16006-6-oleksandr.suvorov@foundries.io> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7372c6a6-673f-4026-9fe8-08da487edb4f X-MS-TrafficTypeDiagnostic: DM6PR02MB5579:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IgGdwL53h4IMa6Rw9Agk/6SidBYqP48KY51s6rS3uAlT46IpUOoRVzhtji/3ofvHmqCmEwDD46/iVzUVLRHxaTs3R3jEPPF4W11+7Qve8FAcb0iJLVzbizd00xH90hGZf0L+XjeOthmvsvcyiqukoe2DQm0uAqvpg2kViGQESAPac8NsCB8YdYC7mBTdtQEShQIVwRSPmCdRbAUce4Qy6ha2PaSRpPVo2XT/3+PKEhHYwbqUub/7BiTw7pw+8F0wHY2C/MK043EpGWRJsx9cWZX7WHI65Kvax/03S8evEi3oKhcDHayVFRQhdwDbOfS5lKeucUNiVmt3/nbwZOgP2yA2SBhmfU19QuXrKo7DajkqRlIup/Lshw3xXxDqFRPm2oVWEWz1jdnuIOVKH02kip2k6XnGF7L/hBcVJPCqeCM6gi6NWE50bSyCWMXsD8y59hHYEee3mvsE7X9xsnAn1MWDw4SG3uAk7svFFB3/O0KkW9b6a0gLLXIc+ekwlctk/wmLUo9KlO13lYB2ImsOyb6qnweR9lwGsAzM/TJ2qxIpIG9kPI6rmiVNfzXk8XtK6jkb4F7SeJdfI+0jYykWxiLWBaYViL/eJN19zUH1vYgwmCIUUDpldmS1J7aNBMz12zKuq3gtnh3+HxbGBapCHH5CV6I3MiZh7rR244E40+U1nNWX/1895zrT8tW6Wfr/2iV4ZK5c3yHnDmFfgHufZOecx4D4yQ07tDP/2verMSE= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(31686004)(47076005)(2906002)(336012)(426003)(53546011)(2616005)(31696002)(110136005)(316002)(54906003)(26005)(82310400005)(8936002)(9786002)(356005)(40460700003)(36756003)(508600001)(36860700001)(186003)(4326008)(44832011)(7636003)(8676002)(70206006)(70586007)(5660300002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 12:11:30.7916 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7372c6a6-673f-4026-9fe8-08da487edb4f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT018.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5579 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 6/1/22 10:46, Oleksandr Suvorov wrote: > Add a "compatible" string to binary flag converter, which uses > a callback str2flag() of given FPGA driver if available. > > Signed-off-by: Oleksandr Suvorov > --- > > (no changes since v1) > > drivers/fpga/fpga.c | 26 ++++++++++++++++++++++++++ > include/fpga.h | 1 + > 2 files changed, 27 insertions(+) > > diff --git a/drivers/fpga/fpga.c b/drivers/fpga/fpga.c > index 3b0a44b2420..fbfdd406e3b 100644 > --- a/drivers/fpga/fpga.c > +++ b/drivers/fpga/fpga.c > @@ -356,3 +356,29 @@ int fpga_info(int devnum) > > return fpga_dev_info(devnum); > } > + > +int fpga_compatible2flag(int devnum, const char *compatible) > +{ > + const fpga_desc * const desc = fpga_get_desc(devnum); > + > + if (!desc) > + return FPGA_FAIL; > + > + switch (desc->devtype) { > + case fpga_xilinx: > +#if defined(CONFIG_FPGA_XILINX) > + { > + xilinx_desc *xdesc = (xilinx_desc *)desc->devdesc; > + > + if (xdesc->operations->str2flag) > + return xdesc->operations->str2flag(xdesc, compatible); This function is returning FPGA_FAIL or 0 (FPGA_SUCCESS) but str2flag is returning based on 4/14 flags. It means you are mixing two things here together. Thanks, Michal