From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78F8C433DB for ; Tue, 16 Feb 2021 16:00:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A67564D9E for ; Tue, 16 Feb 2021 16:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A67564D9E Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.85897.160745 (Exim 4.92) (envelope-from ) id 1lC2lq-0008IM-NY; Tue, 16 Feb 2021 16:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 85897.160745; Tue, 16 Feb 2021 16:00:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC2lq-0008IF-Jn; Tue, 16 Feb 2021 16:00:14 +0000 Received: by outflank-mailman (input) for mailman id 85897; Tue, 16 Feb 2021 16:00:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC2lp-0008I9-NI for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:00:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC2lp-0003zW-MZ for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:00:13 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lC2lp-0003KD-LR for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:00:13 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lC2lm-0000hw-H6; Tue, 16 Feb 2021 16:00:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=P6eWWio+X0l5UPkWFzkpOKLW9fWf8eZJUZuO0IBWcXo=; b=lB/hLiaBBaMQ7GMhFWJvenGH0I JRv9c6mL8BtcX96AfRbfA/HA9HrZZPLYwhhbW6SwWhJFFASveU9yTDftO3FszzbGlAVtjr7poukPz MUTIRrhpDd8tfjcz003YKaS35tqoYxdm/lVaajDhaO9WrQevTVq0OAEezXucaWBmEcik=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24619.60426.285539.113926@mariner.uk.xensource.com> Date: Tue, 16 Feb 2021 16:00:10 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v1.1 03/10] tools/libxg: Drop stale p2m logic from ARM's meminit() In-Reply-To: <20210212200139.26911-1-andrew.cooper3@citrix.com> References: <20210212153953.4582-4-andrew.cooper3@citrix.com> <20210212200139.26911-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH v1.1 03/10] tools/libxg: Drop stale p2m logic from ARM's meminit()"): > Various version of gcc, when compiling with -Og, complain: > > xg_dom_arm.c: In function 'meminit': > xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] > 420 | dom->p2m_size = p2m_size; > | ~~~~~~~~~~~~~~^~~~~~~~~~ > > This is actually entirely stale code since ee21f10d70^..97e34ad22d which > removed the 1:1 identity p2m for translated domains. > > Drop the write of d->p2m_size, and the p2m_size local variable. Reposition > the p2m_size field in struct xc_dom_image and correct some stale > documentation. > > This change really ought to have been part of the original cleanup series. > > No actual change to how ARM domains are constructed. > > Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson