From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC82C433E0 for ; Tue, 16 Feb 2021 16:31:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5931264DEC for ; Tue, 16 Feb 2021 16:31:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5931264DEC Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.85954.160916 (Exim 4.92) (envelope-from ) id 1lC3FV-0004At-P6; Tue, 16 Feb 2021 16:30:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 85954.160916; Tue, 16 Feb 2021 16:30:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3FV-0004Am-Lr; Tue, 16 Feb 2021 16:30:53 +0000 Received: by outflank-mailman (input) for mailman id 85954; Tue, 16 Feb 2021 16:30:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3FT-0004Ah-L1 for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:30:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3FT-0004Xx-Gx for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:30:51 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lC3FT-0005tN-EK for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:30:51 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lC3FQ-0000pm-3u; Tue, 16 Feb 2021 16:30:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=OhJRJlAMpzAAh07WuVPnM89I4Bmu//KXS2FG5XMcqVk=; b=lT4/iBXjo+IsctsMKaRK/FCSHM Ru1xR5NMxNKhUVU7J6qVzzAZ6X0v+uKbZCGH28izGJ/CAKbQ5LPY8CGXl8OXEAMjElvIXU8V7tk2T zRyKbqjPNyj645CXMKwNVgRP+RnY6Alvas91LDvHkx8477re3/ZhGu9iMfJ6w3c0P/NA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24619.62263.884017.217332@mariner.uk.xensource.com> Date: Tue, 16 Feb 2021 16:30:47 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Juergen Gross Subject: Re: [PATCH 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available In-Reply-To: <20210212153953.4582-11-andrew.cooper3@citrix.com> References: <20210212153953.4582-1-andrew.cooper3@citrix.com> <20210212153953.4582-11-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 10/10] tools/libs: Write out an ABI analysis when abi-dumper is available"): > Signed-off-by: Andrew Cooper ... > +# If abi-dumper is available, write out the ABI analysis > +ifneq ($(ABI_DUMPER),) > +libs: $(PKG_ABI) > +$(PKG_ABI): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) headers.lst > + abi-dumper $< -o $@ -public-headers headers.lst -lver $(MAJOR).$(MINOR) > +endif Kind of annoying that we don't have a variable for lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) Reviewed-by: Ian Jackson