From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4FDCE2194D3AE for ; Fri, 28 Sep 2018 01:17:43 -0700 (PDT) From: David Howells In-Reply-To: <153799481498.71621.12671693381009469035.stgit@djiang5-desk3.ch.intel.com> References: <153799481498.71621.12671693381009469035.stgit@djiang5-desk3.ch.intel.com> <153799466529.71621.10728628542331983376.stgit@djiang5-desk3.ch.intel.com> Subject: Re: [PATCH v10 02/12] libnvdimm: create keyring to store security keys MIME-Version: 1.0 Content-ID: <24619.1538122660.1@warthog.procyon.org.uk> Date: Fri, 28 Sep 2018 09:17:40 +0100 Message-ID: <24620.1538122660@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Jiang Cc: alison.schofield@intel.com, keescook@chromium.org, linux-nvdimm@lists.01.org, ebiggers3@gmail.com, dhowells@redhat.com, keyrings@vger.kernel.org List-ID: Dave Jiang wrote: > +static void nvdimm_unregister_keyring(void) > +{ > + key_put(nvdimm_keyring); > + key_revoke(nvdimm_keyring); oops. ;-) David _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Fri, 28 Sep 2018 08:17:40 +0000 Subject: Re: [PATCH v10 02/12] libnvdimm: create keyring to store security keys Message-Id: <24620.1538122660@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <153799481498.71621.12671693381009469035.stgit@djiang5-desk3.ch.intel.com> <153799466529.71621.10728628542331983376.stgit@djiang5-desk3.ch.intel.com> In-Reply-To: <153799481498.71621.12671693381009469035.stgit@djiang5-desk3.ch.intel.com> To: Dave Jiang Cc: alison.schofield@intel.com, keescook@chromium.org, linux-nvdimm@lists.01.org, ebiggers3@gmail.com, dhowells@redhat.com, keyrings@vger.kernel.org Dave Jiang wrote: > +static void nvdimm_unregister_keyring(void) > +{ > + key_put(nvdimm_keyring); > + key_revoke(nvdimm_keyring); oops. ;-) David