From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B02C433E0 for ; Tue, 16 Feb 2021 17:58:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4777E64E08 for ; Tue, 16 Feb 2021 17:58:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4777E64E08 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.86008.161021 (Exim 4.92) (envelope-from ) id 1lC4bo-0003oQ-D8; Tue, 16 Feb 2021 17:58:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 86008.161021; Tue, 16 Feb 2021 17:58:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC4bo-0003oJ-8y; Tue, 16 Feb 2021 17:58:00 +0000 Received: by outflank-mailman (input) for mailman id 86008; Tue, 16 Feb 2021 17:57:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC4bm-0003oE-VJ for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 17:57:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC4bm-0005y0-RS for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 17:57:58 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lC4bm-0001PP-OZ for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 17:57:58 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lC4bj-00013M-F7; Tue, 16 Feb 2021 17:57:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=zdLuxJR9BFfxTCVW0soQh3MiN+REhXu+qW4qHAdtfF0=; b=4HpC/DHi+wtnXoLYxYOOOZBpJi ilvzPRF6g3UQ1UW2qP75PCrI4ZpaGZVQuAE/9dK56sQpynGim/0t/8TobkNUfuYNay9Rifgka6v8A VGaOHfZuptgx2yXVMPa72FnakQN7L00diYLPxUpSJYigksY9sbEhd5nHXIle8yWTZlUY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24620.1955.243860.253052@mariner.uk.xensource.com> Date: Tue, 16 Feb 2021 17:57:55 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Anthony PERARD Subject: Re: [PATCH v2 04/10] tools/libxl: Fix uninitialised variable in libxl__domain_get_device_model_uid() In-Reply-To: <20210216174327.8086-1-andrew.cooper3@citrix.com> References: <20210212153953.4582-5-andrew.cooper3@citrix.com> <20210216174327.8086-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH v2 04/10] tools/libxl: Fix uninitialised variable in libxl__domain_get_device_model_uid()"): > Various version of gcc, when compiling with -Og, complain: > > libxl_dm.c: In function 'libxl__domain_get_device_model_uid': > libxl_dm.c:256:12: error: 'kill_by_uid' may be used uninitialized in this function [-Werror=maybe-uninitialized] > 256 | if (kill_by_uid) ... > @@ -176,7 +176,6 @@ static int libxl__domain_get_device_model_uid(libxl__gc *gc, > LOGD(DEBUG, guest_domid, > "dm_restrict disabled, starting QEMU as root"); > user = NULL; /* Should already be null, but just in case */ > - kill_by_uid = false; /* Keep older versions of gcc happy */ > rc = 0; > goto out; Uhhhhh. I think this and the other one seem to be stray hunks which each introduce a new uninitialised variable bug ? Isn.