From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2E4C10F13 for ; Thu, 11 Apr 2019 12:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95C9421852 for ; Thu, 11 Apr 2019 12:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfDKMqT convert rfc822-to-8bit (ORCPT ); Thu, 11 Apr 2019 08:46:19 -0400 Received: from gloria.sntech.de ([185.11.138.130]:58096 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726676AbfDKMqS (ORCPT ); Thu, 11 Apr 2019 08:46:18 -0400 Received: from wf0380.dip.tu-dresden.de ([141.76.181.124] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEZ5r-0007ws-Or; Thu, 11 Apr 2019 14:46:15 +0200 From: Heiko Stuebner To: Robin Murphy Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs Date: Thu, 11 Apr 2019 14:46:15 +0200 Message-ID: <2463729.IUJ8mRE5Ts@phil> In-Reply-To: <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, Am Samstag, 30. März 2019, 00:24:16 CEST schrieb Robin Murphy: > On 2019-03-27 12:00 pm, Heiko Stuebner wrote: > > Hi, > > > > Am Dienstag, 26. März 2019, 14:49:16 CET schrieb Katsuhiro Suzuki: > >> Hello Robin, > >> > >> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, > >> please revert my patch if you need. > > > > I've dropped the patch from my queue now. > > > >> BTW, there are DMA properties in RK3328 device-tree like as this patch. > >> RK3328 UART DMA could not work correctly too...?? > > > > I remember Rockcihip dma-controllers having issues with burst-sizes > > and flushing (there is a no-flushp option in pl330), so it's > > possible that all share the same error up to rk3399 and rk3328 > > > > But so far no-one has shouted regarding the rk3328. > > Let me be the first, then, I guess :) > > I found an easy way to observe the problem on my 3399, and I've just > fired up my 3328 box with a 5.0 distro kernel to find that it behaves > the same. Basically just dump a large pile of text into 'less' on the > serial console, and scroll through line-by-line - certain lines get > dropped except for a few characters at the end. > > I'll see if I can narrow it down a bit, starting with trying > broken-flushp... did you manage to find time for that test you wanted to do? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92153C10F13 for ; Thu, 11 Apr 2019 12:46:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6150C2184E for ; Thu, 11 Apr 2019 12:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eVgN6CxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6150C2184E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VzWlFRrXQIRsPEwVJ8YGnDIOeFTlImjN8dXg1lpKQk=; b=eVgN6CxQLzARFV zh7PNUrr/o/3cJb9QCpaLOTIHJFWtHfXry1MSMfpEqEzdVdE9abTLIha7ms3ITRohRLnIXdipDR+Y CFQFSHGdmfHXSrbAAiZ8LWHASqOZnA4HAU6P1lmmr0wZ3v82nX63SDrbTQA+KOvBkHdLWe/b5UHps ppZWGlJhsEn6VBHubOV3XaEE+bPYOC2RddBglRy+e/bbeHQlSgtDmfz1ncwgOp9rqCJG9tIeh7jqq 2arVCP5BYvk9WewfwBouiYN+JwJAYdaV/Mxk8kYJJ8PJ84W8Rwi9iy6B+9uAaqNKWiDB2459nseEk Bmy4m94lHm31edeJMIsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEZ60-0003Ru-W1; Thu, 11 Apr 2019 12:46:24 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEZ5w-0003Mm-83; Thu, 11 Apr 2019 12:46:21 +0000 Received: from wf0380.dip.tu-dresden.de ([141.76.181.124] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEZ5r-0007ws-Or; Thu, 11 Apr 2019 14:46:15 +0200 From: Heiko Stuebner To: Robin Murphy Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs Date: Thu, 11 Apr 2019 14:46:15 +0200 Message-ID: <2463729.IUJ8mRE5Ts@phil> In-Reply-To: <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> References: <20190321162244.10080-1-katsuhiro@katsuster.net> <14265087.Gbs4YZABJo@phil> <69d5d0fd-00c3-36ae-596e-1b9f9452a07a@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_054620_496361_83B00A5C X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Katsuhiro Suzuki , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, Am Samstag, 30. M=E4rz 2019, 00:24:16 CEST schrieb Robin Murphy: > On 2019-03-27 12:00 pm, Heiko Stuebner wrote: > > Hi, > > = > > Am Dienstag, 26. M=E4rz 2019, 14:49:16 CET schrieb Katsuhiro Suzuki: > >> Hello Robin, > >> > >> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs, > >> please revert my patch if you need. > > = > > I've dropped the patch from my queue now. > > = > >> BTW, there are DMA properties in RK3328 device-tree like as this patch. > >> RK3328 UART DMA could not work correctly too...?? > > = > > I remember Rockcihip dma-controllers having issues with burst-sizes > > and flushing (there is a no-flushp option in pl330), so it's > > possible that all share the same error up to rk3399 and rk3328 > > = > > But so far no-one has shouted regarding the rk3328. > = > Let me be the first, then, I guess :) > = > I found an easy way to observe the problem on my 3399, and I've just = > fired up my 3328 box with a 5.0 distro kernel to find that it behaves = > the same. Basically just dump a large pile of text into 'less' on the = > serial console, and scroll through line-by-line - certain lines get = > dropped except for a few characters at the end. > = > I'll see if I can narrow it down a bit, starting with trying = > broken-flushp... did you manage to find time for that test you wanted to do? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel