From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A99C433E0 for ; Fri, 5 Mar 2021 13:24:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E9FE64FDD for ; Fri, 5 Mar 2021 13:24:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E9FE64FDD Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.93691.176763 (Exim 4.92) (envelope-from ) id 1lIAR4-0006Uk-W2; Fri, 05 Mar 2021 13:24:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93691.176763; Fri, 05 Mar 2021 13:24:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR4-0006Ud-Sr; Fri, 05 Mar 2021 13:24:06 +0000 Received: by outflank-mailman (input) for mailman id 93691; Fri, 05 Mar 2021 13:24:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0006UW-MS for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0006h5-G8 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAR3-0001kA-El for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:24:05 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAR0-0008Nz-3O; Fri, 05 Mar 2021 13:24:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=v8BwmWVXumSpTnT5yALGy/i+hc30fZFIsTozBDrd3RA=; b=VmJUv5lPXCiIVUPX1JUAkBK+G6 Uq+uxth/eNdGz2JvqmLKnSNP/6RTEHfXGpSPoFHH9VxRwHOl1sLeaeyviFeTYQ6fZokLDnY+ywRRb wls8qPTN/gdmW3nQ0VdPcvXrHA98gdi5jo2+qWXkc4cJF2Y4DMY/dhUCcFOr0YeIBRLg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12529.753822.114284@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:24:01 +0000 To: Julien Grall Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h In-Reply-To: <20210305124003.13582-2-julien@xen.org> References: <20210305124003.13582-1-julien@xen.org> <20210305124003.13582-2-julien@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("[PATCH for-4.15 1/2] tools/xenstore: Consolidate PRINTF_ATTRIBUTE() in utils.h"): > From: Julien Grall > > At the moment PRINTF_ATTRIBUTE() is defined in two places: > - tdb.h: Defined as a NOP > - talloc.h: Defined as a NOP for GCC older than 3.0 otherwise will > add the attribute to check the printf format > > Xen requires to build with minimum GCC 4.1 and we want to check the > printf format for all the printf-like functions. > > Only implement PRINTF_ATTRIBUTE() once in utils.h and drop the > conditional check for GCC < 3.0. Release-Acked-by: Ian Jackson