From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74844C433C1 for ; Mon, 22 Mar 2021 14:32:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 155C66187E for ; Mon, 22 Mar 2021 14:32:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 155C66187E Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.100245.190893 (Exim 4.92) (envelope-from ) id 1lOLbP-0007od-3B; Mon, 22 Mar 2021 14:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 100245.190893; Mon, 22 Mar 2021 14:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbP-0007oW-08; Mon, 22 Mar 2021 14:32:19 +0000 Received: by outflank-mailman (input) for mailman id 100245; Mon, 22 Mar 2021 14:32:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0007oH-P5 for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0005EU-Np for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lOLbN-0002Ba-Mn for xen-devel@lists.xenproject.org; Mon, 22 Mar 2021 14:32:17 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lOLbK-0000AQ-Bs; Mon, 22 Mar 2021 14:32:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=mmQETQBI35ScJsVnqDaaPgevsGpc2rmSd+HCoW5ptp4=; b=53Yk5vfoJ6kbcZwZnu5ze/huAR KSC6al/GJx9AnzrazCZMtVCO4GAgWCDr/B96fILZPahIgjOt2IRTNNf3UybUBxcVUKN5pI1af6wUo ZMtPAewROMgwFm3oah81fx8D6crKK4Z3P5UpRnLtfBQ+9zRBD9oeA2ltuN3heFuKoi7Y=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24664.43630.78608.264828@mariner.uk.xensource.com> Date: Mon, 22 Mar 2021 14:32:14 +0000 To: Anthony PERARD Cc: , Wei Liu , Daniel P. =?iso-8859-1?Q?Berrang=E9?= Subject: Re: [XEN PATCH for-4.15] libxl: Replace deprecated QMP command by "query-cpus-fast" In-Reply-To: <20210322141744.522041-1-anthony.perard@citrix.com> References: <20210322141744.522041-1-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) We use the deprecated QMP command "query-cpus" which will be remove in > the upcoming QEMU 6.0 release. There's a replacement which is > "query-cpus-fast", and have been available since QEMU 2.12 (April > 2018). > > In order to been able to keep using recent version of QEMU, this patch > replace the deprecated command by the newer version. And because we > are in the "feature freeze" period, this patch is kept simple without > fallback (which could have been used when "query-cpus-fast" wasn't > available). Thank you. I observe that Daniel Berrange also wrote a libxl patch to solve this problem. I read the interdiff and the only difference is that Anthony's patch changes the internal function name to qmp_parse_query_cpus_fast whereas Daniel's doesn't. This gives me a fairly high confidence in the patch :-). Acked-by: Ian Jackson Release-Acked-by: Ian Jackson Ian.