From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E82BC433ED for ; Wed, 7 Apr 2021 16:12:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F5D261177 for ; Wed, 7 Apr 2021 16:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F5D261177 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.106817.204237 (Exim 4.92) (envelope-from ) id 1lUAn4-0002n9-6z; Wed, 07 Apr 2021 16:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 106817.204237; Wed, 07 Apr 2021 16:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUAn4-0002n1-3K; Wed, 07 Apr 2021 16:12:26 +0000 Received: by outflank-mailman (input) for mailman id 106817; Wed, 07 Apr 2021 16:12:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUAn3-0002mw-DS for xen-devel@lists.xenproject.org; Wed, 07 Apr 2021 16:12:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUAn3-0000tt-AO for xen-devel@lists.xenproject.org; Wed, 07 Apr 2021 16:12:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lUAn3-00023u-8V for xen-devel@lists.xenproject.org; Wed, 07 Apr 2021 16:12:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lUAmx-0005BJ-5B; Wed, 07 Apr 2021 17:12:19 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=h/d/PKBiJh1UD5ptvk2ftxxSZVOMD5M19GXLqBilFqY=; b=W1OD5+PhR9ZiRkiFTInF/1yEKg IJ+kd8w/+9e9BQscihHZAjSzHzpou/MjXEDs2H35xwX4vzwSYA4qI0lJSLyL2B5hvorcY+BdydIVd xn4bQPFP/c4e/G3uMbbkaI1oXsnY+ZZ7K5DE9sbSIvQuigCVYqChjbA4pBKWCnYe83cA=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24685.55778.953134.793523@mariner.uk.xensource.com> Date: Wed, 7 Apr 2021 17:12:18 +0100 To: Bertrand Marquis Cc: Julien Grall , Luca Fancellu , "xen-devel\@lists.xenproject.org" , Wei Chen , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h In-Reply-To: <9B8BD2C5-297C-4BE3-8476-5D10699712E2@arm.com> References: <20210406103603.8530-1-luca.fancellu@arm.com> <20210406103603.8530-4-luca.fancellu@arm.com> <7f143615-acdf-5a97-5e07-57cab49031d6@xen.org> <0F20064C-418C-4A4F-9883-4452A726B038@arm.com> <24685.52599.234444.705703@mariner.uk.xensource.com> <03084EF9-F130-41F7-9D8D-9AF86A87717F@arm.com> <8b0fafe2-989e-5a5a-05ec-f55e096e4b54@xen.org> <9B8BD2C5-297C-4BE3-8476-5D10699712E2@arm.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Bertrand Marquis writes ("Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h"): > Somehow in the documentation when you have a union you will need to document that it is a union and the possible entries. I would expect to find the documentation for an anonymous struct or union folded into the documentation of the containing structure, just as it is in the source. > One way or an other most standards like MISRA are forbidding anonymous entries as they cannot be referred to. An anonymous union or struct like this is always the type of a single field in a containing aggegate type. So if one needs to speak of it, one can specify the container's type and the field. So it *can* be named. I am assuming we don't have *unused* anonymous structs and unions. Ian.