From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Burton Subject: Re: [PATCH v3 16/18] dt-bindings: Document img,boston-clock binding Date: Tue, 11 Oct 2016 17:00:44 +0100 Message-ID: <2468748.fALFhzhDcI@np-p-burton> References: <20161005171824.18014-1-paul.burton@imgtec.com> <20161005171824.18014-17-paul.burton@imgtec.com> <20161010130121.GA31827@rob-hp-laptop> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1510261.TKAFVGyAAe"; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <20161010130121.GA31827@rob-hp-laptop> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Rob Herring Cc: linux-mips@linux-mips.org, Ralf Baechle , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org --nextPart1510261.TKAFVGyAAe Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, 10 October 2016 08:01:21 BST Rob Herring wrote: > On Wed, Oct 05, 2016 at 06:18:22PM +0100, Paul Burton wrote: > > Add device tree binding documentation for the clocks provided by the > > MIPS Boston development board from Imagination Technologies, and a > > header file describing the available clocks for use by device trees & > > driver. > > > > Signed-off-by: Paul Burton > > Cc: Michael Turquette > > Cc: Stephen Boyd > > Cc: linux-clk@vger.kernel.org > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: devicetree@vger.kernel.org > > > > --- > > > > Changes in v3: None > > Changes in v2: > > - Add BOSTON_CLK_INPUT to expose the input clock. > > > > .../devicetree/bindings/clock/img,boston-clock.txt | 27 > > ++++++++++++++++++++++ include/dt-bindings/clock/boston-clock.h > > | 14 +++++++++++ 2 files changed, 41 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/img,boston-clock.txt create mode > > 100644 include/dt-bindings/clock/boston-clock.h > > > > diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock.txt > > b/Documentation/devicetree/bindings/clock/img,boston-clock.txt new file > > mode 100644 > > index 0000000..c01ea60 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/img,boston-clock.txt > > @@ -0,0 +1,27 @@ > > +Binding for Imagination Technologies MIPS Boston clock sources. > > + > > +This binding uses the common clock binding[1]. > > + > > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt > > + > > +Required properties: > > +- compatible : Should be "img,boston-clock". > > +- #clock-cells : Should be set to 1. > > + Values available for clock consumers can be found in the header file: > > + > > +- regmap : Phandle to the Boston platform register system controller. > > + This should contain a phandle to the system controller node covering > > the > > + platform registers provided by the Boston board. > > Can you just make the clock node a child of the system controller and > drop this? > > Rob Hi Rob, (Apologies to anyone who received my last; my mail client seems to be misconfigured & previously sent HTML mail.) As I mentioned before technically that could be done, but it would really not be at all reflective of the hardware & so seems somewhat contrary to the purpose of a device tree. Thanks, Paul --nextPart1510261.TKAFVGyAAe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJX/QysAAoJEIIg2fppPBxl8D8P/jZEbGy4OwrZEmOTXP+Der/O n0oNrjzD6VkgKOAc4lIZNjRPgHxUXb/qFdL6ObfOnVYxmlfs+KrvzZoO6YbleaG2 Oq3qMqvJsV+VKxPqB2HKVRM/S9pN+GpXdp553oRkPUJwCFJrrTuuW9YHE6c6gegm O57H2nG/M6KF4mXfQj9sN/H1fU14kwwfEgTRovPZg6m2imLS8yd1behdAY9nRlZj tanMDIEZlWnrdP61ZAfVAsa/V+ussaJWc40miqHyDEGprLHZ4n9PrwJeMdrJ1SOa aaFv8Qpk+UiY9Ia+7wL2K9Gdn1aCmbfqcoXZWTQ1hZi1SPTuLYGrXw8FmGnxh5FW X1SKtW458oP5uW6aQX+r5ixqzoCF6/eUgjH/8BAa60q9nDdA1MlYDk1SfmxnQ+/0 0H5gj+7bR9RoLkGthxCYQuRBncxO3zTL4f6EcNNdjpPiGIVju3BWe2MNTqycf+HO Acpr5gOAyiK7xDxkRBU4kzL3HxUJuC0VyC61FljgSh1ZAUcKRp8BeULY6W4+haxF P2UCRXv0bX0l5OEr0YGaOB+yMyEc4JxyxkrCeRNK6iMFR7vDY16Ng+UhHNa1bpog C1QxPNrkaqSlYAZzF/Q9FnNhCZS1a17z9SszCVO2yAm2w2CZ1MHUK3ib90wWrTkX 10x2FoSR4zN6GDY6AlC/ =Oluv -----END PGP SIGNATURE----- --nextPart1510261.TKAFVGyAAe-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Paul Burton To: Rob Herring CC: , Ralf Baechle , "Michael Turquette" , Stephen Boyd , , Mark Rutland , Subject: Re: [PATCH v3 16/18] dt-bindings: Document img,boston-clock binding Date: Tue, 11 Oct 2016 17:00:44 +0100 Message-ID: <2468748.fALFhzhDcI@np-p-burton> In-Reply-To: <20161010130121.GA31827@rob-hp-laptop> References: <20161005171824.18014-1-paul.burton@imgtec.com> <20161005171824.18014-17-paul.burton@imgtec.com> <20161010130121.GA31827@rob-hp-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1510261.TKAFVGyAAe"; micalg=pgp-sha256; protocol="application/pgp-signature" List-ID: --nextPart1510261.TKAFVGyAAe Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, 10 October 2016 08:01:21 BST Rob Herring wrote: > On Wed, Oct 05, 2016 at 06:18:22PM +0100, Paul Burton wrote: > > Add device tree binding documentation for the clocks provided by the > > MIPS Boston development board from Imagination Technologies, and a > > header file describing the available clocks for use by device trees & > > driver. > > > > Signed-off-by: Paul Burton > > Cc: Michael Turquette > > Cc: Stephen Boyd > > Cc: linux-clk@vger.kernel.org > > Cc: Rob Herring > > Cc: Mark Rutland > > Cc: devicetree@vger.kernel.org > > > > --- > > > > Changes in v3: None > > Changes in v2: > > - Add BOSTON_CLK_INPUT to expose the input clock. > > > > .../devicetree/bindings/clock/img,boston-clock.txt | 27 > > ++++++++++++++++++++++ include/dt-bindings/clock/boston-clock.h > > | 14 +++++++++++ 2 files changed, 41 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/img,boston-clock.txt create mode > > 100644 include/dt-bindings/clock/boston-clock.h > > > > diff --git a/Documentation/devicetree/bindings/clock/img,boston-clock.txt > > b/Documentation/devicetree/bindings/clock/img,boston-clock.txt new file > > mode 100644 > > index 0000000..c01ea60 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/img,boston-clock.txt > > @@ -0,0 +1,27 @@ > > +Binding for Imagination Technologies MIPS Boston clock sources. > > + > > +This binding uses the common clock binding[1]. > > + > > +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt > > + > > +Required properties: > > +- compatible : Should be "img,boston-clock". > > +- #clock-cells : Should be set to 1. > > + Values available for clock consumers can be found in the header file: > > + > > +- regmap : Phandle to the Boston platform register system controller. > > + This should contain a phandle to the system controller node covering > > the > > + platform registers provided by the Boston board. > > Can you just make the clock node a child of the system controller and > drop this? > > Rob Hi Rob, (Apologies to anyone who received my last; my mail client seems to be misconfigured & previously sent HTML mail.) As I mentioned before technically that could be done, but it would really not be at all reflective of the hardware & so seems somewhat contrary to the purpose of a device tree. Thanks, Paul --nextPart1510261.TKAFVGyAAe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJX/QysAAoJEIIg2fppPBxl8D8P/jZEbGy4OwrZEmOTXP+Der/O n0oNrjzD6VkgKOAc4lIZNjRPgHxUXb/qFdL6ObfOnVYxmlfs+KrvzZoO6YbleaG2 Oq3qMqvJsV+VKxPqB2HKVRM/S9pN+GpXdp553oRkPUJwCFJrrTuuW9YHE6c6gegm O57H2nG/M6KF4mXfQj9sN/H1fU14kwwfEgTRovPZg6m2imLS8yd1behdAY9nRlZj tanMDIEZlWnrdP61ZAfVAsa/V+ussaJWc40miqHyDEGprLHZ4n9PrwJeMdrJ1SOa aaFv8Qpk+UiY9Ia+7wL2K9Gdn1aCmbfqcoXZWTQ1hZi1SPTuLYGrXw8FmGnxh5FW X1SKtW458oP5uW6aQX+r5ixqzoCF6/eUgjH/8BAa60q9nDdA1MlYDk1SfmxnQ+/0 0H5gj+7bR9RoLkGthxCYQuRBncxO3zTL4f6EcNNdjpPiGIVju3BWe2MNTqycf+HO Acpr5gOAyiK7xDxkRBU4kzL3HxUJuC0VyC61FljgSh1ZAUcKRp8BeULY6W4+haxF P2UCRXv0bX0l5OEr0YGaOB+yMyEc4JxyxkrCeRNK6iMFR7vDY16Ng+UhHNa1bpog C1QxPNrkaqSlYAZzF/Q9FnNhCZS1a17z9SszCVO2yAm2w2CZ1MHUK3ib90wWrTkX 10x2FoSR4zN6GDY6AlC/ =Oluv -----END PGP SIGNATURE----- --nextPart1510261.TKAFVGyAAe--