From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yongseok Koh Subject: Re: [PATCH 2/2] net/mlx5: fix probe return value polarity Date: Wed, 2 May 2018 01:54:37 +0000 Message-ID: <246A35AF-2BFD-41C6-BEFC-A93D559FBA88@mellanox.com> References: <20180501111806.112319-1-shahafs@mellanox.com> <20180501111806.112319-2-shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , "dev@dpdk.org" To: Shahaf Shuler Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0061.outbound.protection.outlook.com [104.47.0.61]) by dpdk.org (Postfix) with ESMTP id C18E6200 for ; Wed, 2 May 2018 03:54:40 +0200 (CEST) In-Reply-To: <20180501111806.112319-2-shahafs@mellanox.com> Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On May 1, 2018, at 4:18 AM, Shahaf Shuler wrote: >=20 > mlx5 prefixed function returns a negative errno value. > the error handler on mlx5_pci_probe is doing the same. >=20 > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > Cc: nelio.laranjeiro@6wind.com >=20 > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 46cb370a29..ab860b5985 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -804,12 +804,16 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte= _unused, > goto error; Shouldn't you do the same for mlx5_uar_init_secondary()? Looks like a few more. E.g. mlx5_args(), mlx5_get_mtu() and mlx5_uar_init_p= rimary(). What about ibv_query_port() and mlx5_flow_create_drop_queue()?=20 Thanks > /* Receive command fd from primary process */ > err =3D mlx5_socket_connect(eth_dev); > - if (err < 0) > + if (err < 0) { > + err =3D -err; Instead of changing sign, how about 'err =3D rte_errno;' ? However, err looks redundant to me because mlx5_* funcs set rte_errno. Here, err is used to set rte_errno at the end. Thanks, Yongseok > goto error; > + } > /* Remap UAR for Tx queues. */ > err =3D mlx5_tx_uar_remap(eth_dev, err); > - if (err) > + if (err) { > + err =3D -err; > goto error; > + } > /* > * Ethdev pointer is still required as input since > * the primary device is not accessible from the > --=20 > 2.12.0 >=20