From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4621C433EF for ; Mon, 6 Dec 2021 23:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243047AbhLFXZm (ORCPT ); Mon, 6 Dec 2021 18:25:42 -0500 Received: from out2.migadu.com ([188.165.223.204]:47613 "EHLO out2.migadu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242479AbhLFXZl (ORCPT ); Mon, 6 Dec 2021 18:25:41 -0500 Message-ID: <246bcb01-95f4-c6a7-15ae-2553047b7698@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1638832930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7IvlrCtoKjp5xd4xDDKc/Sxwxwqn6nlOxXKDx4LRjI=; b=dJcXjdqUg8/yFxwViZVGv+r0E3hwunwPrpF6jzMouO3W7eM+DuTskZOeBOXoBFWjJrpS9n HeGWM9Z71aoRNRgy8tBpjF6YPu00DmiNmJPRYgGe1Lye9jZx+TJ4dORnftVxbiVoiE/uhA y9fXHpCv8fdwoCZcpQHZZ6Q0PFrxh5k= Date: Tue, 7 Dec 2021 07:22:04 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/1] RDMA/uverbs: remove the unnecessary assignment To: Haakon Bugge , "yanjun.zhu@linux.dev" Cc: Doug Ledford , "jgg@ziepe.ca" , OFED mailing list , Leon Romanovsky References: <20211207064607.541695-1-yanjun.zhu@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanjun Zhu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org 在 2021/12/6 22:27, Haakon Bugge 写道: > > >> On 7 Dec 2021, at 07:46, yanjun.zhu@linux.dev wrote: >> >> From: Zhu Yanjun >> >> The struct member variable create_flags are assigned twice. > > may be "... is assigned twice." ? My bad. Thanks. Zhu Yanjun > >> Remove the unnecessary assignment. >> >> Fixes: ece9ca97ccdc8 ("RDMA/uverbs: Do not check the input length on create_cq/qp paths") >> Signed-off-by: Zhu Yanjun > > LGTM, so > > Reviewed-by: Håkon Bugge > > > > Thxs, Håkon > >> --- >> drivers/infiniband/core/uverbs_cmd.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c >> index d1345d76d9b1..6b6393176b3c 100644 >> --- a/drivers/infiniband/core/uverbs_cmd.c >> +++ b/drivers/infiniband/core/uverbs_cmd.c >> @@ -1399,7 +1399,6 @@ static int create_qp(struct uverbs_attr_bundle *attrs, >> attr.sq_sig_type = cmd->sq_sig_all ? IB_SIGNAL_ALL_WR : >> IB_SIGNAL_REQ_WR; >> attr.qp_type = cmd->qp_type; >> - attr.create_flags = 0; >> >> attr.cap.max_send_wr = cmd->max_send_wr; >> attr.cap.max_recv_wr = cmd->max_recv_wr; >> -- >> 2.27.0 >> >